From patchwork Wed Jan 15 10:04:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhenqiang Chen X-Patchwork-Id: 311046 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 766A82C00A2 for ; Wed, 15 Jan 2014 21:04:34 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:date:message-id:subject:from:to:cc:content-type; q=dns; s=default; b=eGKRtrbADr05wM2rNwrWeDP2CXG7bHrxIcds6f4qBQe HMy7Tq00K6Y3UBQFT0wuJeauSO6QApGtlPM8vejB2ICvL7r8amL/aBkoZ/cHogvl +IxgW0nvdMMOXc5fi7TyiR729NqNH5ComnAahXcKJVpUryfUHLzZ26RPyO2e2KCw = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:date:message-id:subject:from:to:cc:content-type; s=default; bh=nOW+BjAspXpaCaJS2d0lSaowGdo=; b=quzJXiqj62KmPiOqc GcR4CbyFpaO8PXlyzWDZAJVC75KHno5ULRc3VywHBv/SDRSY3IRZKqgpxFecYDip l0a1IJigZqaf9UtJ3IWhddWPQ6WgXUsKvlScK7h62Q2PdL4X+6fiLeeBDqd+ZkOn WmvWtoRWraRIwPpNIDr9wMfvYQ= Received: (qmail 807 invoked by alias); 15 Jan 2014 10:04:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 798 invoked by uid 89); 15 Jan 2014 10:04:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SEM_URI, SEM_URIRED, SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-lb0-f178.google.com Received: from mail-lb0-f178.google.com (HELO mail-lb0-f178.google.com) (209.85.217.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 15 Jan 2014 10:04:25 +0000 Received: by mail-lb0-f178.google.com with SMTP id u14so601403lbd.9 for ; Wed, 15 Jan 2014 02:04:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to:cc :content-type; bh=1YtxiYkPqk8LhRjwvCTikevKEdNfmkm3f/wM8Q+AzUA=; b=F74YmBgRabjhz0WAIuCwUN47yZx/9o7ab/A1qlnKnxvNC1/0ynfGWbaxjx/jzbjRu7 7r2HjkUR7LDrwZGKPWowAwVFHZ5Rs5z1PWvfqDXTU+1w9maofRx/+q360GuZw6bp+g9e 7oItqKJhzKRXJgb+bBGusZhlL2ceA1CaJ/BByfDb5gTJCZL4Mp3qF1DiyllpmEPiIyiJ gZX3N+TDaIjne8Kt8yGvGwqqhbk6Ko52PE0UZd2oM1IJXQlMv94hyvQ5L9ayqCW79NgU rMnP0ujsKSALVcIAf5Ml4lm6s8Xbdc9TxfVqAere0SKeE+1Vj1dZI5Y3mil0SCF4/+Jk qxTA== X-Gm-Message-State: ALoCoQm4CZsp6qkRuVcKehGdMFXWKWfBhtEAGVtgxGXRhYxmF8l4+mr1zdZzAOjz/cM8nWGfshc3 MIME-Version: 1.0 X-Received: by 10.152.219.133 with SMTP id po5mr959589lac.34.1389780261946; Wed, 15 Jan 2014 02:04:21 -0800 (PST) Received: by 10.112.173.137 with HTTP; Wed, 15 Jan 2014 02:04:21 -0800 (PST) Date: Wed, 15 Jan 2014 18:04:21 +0800 Message-ID: Subject: [PATCH, ARM] ICE when building kernel raid6 neon code From: Zhenqiang Chen To: "gcc-patches@gcc.gnu.org" Cc: Richard Earnshaw , Ramana Radhakrishnan Hi, The patch fixes ICE when building kernel raid6 neon code. lib/raid6/neon4.c: In function 'raid6_ neon4_gen_syndrome_real': lib/raid6/neon4.c:113:1: internal compiler error: in dwarf2out_frame_debug_adjust_cfa, at dwarf2cfi.c:1090 } https://bugs.launchpad.net/gcc-linaro/+bug/1268893 Root cause: When expanding epilogue, REG_CFA_ADJUST_CFA NOTE is added to handle dwarf info issue for shrink-wrap. But for TARGET_APCS_FRAME, shrink-wrap is disabled. And not all dwarf info in arm_expand_epilogue_apcs_frame are correctly updated. arm_emit_vfp_multi_reg_pop is called by both arm_expand_epilogue_apcs_frame and arm_expand_epilogue. So we should not add the NOTE in arm_emit_vfp_multi_reg_pop if shrink-wrap is not enabled. Boot strap and no make check regression on ARM Chromebook. OK for trunk? Thanks! -Zhenqiang ChangeLog: 2014-01-15 Zhenqiang Chen * config/arm/arm.c (arm_emit_vfp_multi_reg_pop): Do not add REG_CFA_ADJUST_CFA NOTE if shrink-wrap is not enabled. /* Generate and emit a pattern that will be recognized as LDRD pattern. If even diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index 18196b3..1ccb796 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -19890,8 +19890,12 @@ arm_emit_vfp_multi_reg_pop (int first_reg, int num_regs, rtx base_reg) par = emit_insn (par); REG_NOTES (par) = dwarf; - arm_add_cfa_adjust_cfa_note (par, 2 * UNITS_PER_WORD * num_regs, - base_reg, base_reg); + /* REG_CFA_ADJUST_CFA NOTE is added to handle dwarf info issue when + shrink-wrap is enabled. So when shrink-wrap is not enabled, we should + not add the note. */ + if (flag_shrink_wrap) + arm_add_cfa_adjust_cfa_note (par, 2 * UNITS_PER_WORD * num_regs, + base_reg, base_reg); }