From patchwork Tue Dec 6 01:02:21 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramana Radhakrishnan X-Patchwork-Id: 129487 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 2CD201007D4 for ; Tue, 6 Dec 2011 12:02:41 +1100 (EST) Received: (qmail 6598 invoked by alias); 6 Dec 2011 01:02:37 -0000 Received: (qmail 6534 invoked by uid 22791); 6 Dec 2011 01:02:36 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-pz0-f47.google.com (HELO mail-pz0-f47.google.com) (209.85.210.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Dec 2011 01:02:21 +0000 Received: by dake40 with SMTP id e40so5197940dak.20 for ; Mon, 05 Dec 2011 17:02:21 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.25.69 with SMTP id a5mr27663944pbg.43.1323133341250; Mon, 05 Dec 2011 17:02:21 -0800 (PST) Received: by 10.68.64.138 with HTTP; Mon, 5 Dec 2011 17:02:21 -0800 (PST) Date: Tue, 6 Dec 2011 01:02:21 +0000 Message-ID: Subject: [Patch ARM] Obvious - fix formatting character for register with vmov.f64 From: Ramana Radhakrishnan To: gcc-patches Cc: Patch Tracking X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi, There was a missing %P with the last commit for the fixed to floating point conversion idioms which caused ffmpeg builds to break by accidentally putting out a vmov.f64 s0, r0, r0 instead of the vmov.f64 d0, r0, r0. Tested with a simple testcase and made sure that the output obtained is sane. Committed as obvious. cheers Ramana 2011-12-06 Ramana Radhakrishnan * config/arm/vfp.md (*combine_vcvt_f64_): Fix formatting character for vmov.f64 case. Index: gcc/config/arm/vfp.md =================================================================== --- gcc/config/arm/vfp.md (revision 182037) +++ gcc/config/arm/vfp.md (working copy) @@ -1171,7 +1171,7 @@ "@ vmov.f32\\t%0, %1\;vcvt.f64.\\t%P0, %P0, %v2 vmov.f32\\t%0, %1\;vcvt.f64.\\t%P0, %P0, %v2 - vmov.f64\\t%0, %1, %1\; vcvt.f64.\\t%P0, %P0, %v2" + vmov.f64\\t%P0, %1, %1\;vcvt.f64.\\t%P0, %P0, %v2" [(set_attr "predicable" "no") (set_attr "type" "f_cvt") (set_attr "length" "8")]