From patchwork Tue Jul 10 12:20:19 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Bosscher X-Patchwork-Id: 170167 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 7BC302C007B for ; Tue, 10 Jul 2012 22:21:01 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1342527661; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: MIME-Version:Received:From:Date:Message-ID:Subject:To:Cc: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=jT4Qwy+ 861n/Htqy5Jr7b+NVL5M=; b=Q/NLWFnwyMqKmAjvlVtrUXsDl6eGhpAOx4C5rzE xqIP+qnTPr/ArR7gIAKRuAsi8L+qq2lPWDMNer1gPShZgyBdIZg3mAxhWO9wbNYz LGfqYueqPXEhkCNPvfFsR5eZ3z3BJrz5LbBJI2gVgy6cXJI4u5UiYCtTfboVoyUn FJHg= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:MIME-Version:Received:From:Date:Message-ID:Subject:To:Cc:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=EIoQbAsA/JOZi1BMp1BAp7EVFnxHSHPOi0BMORoUOfdjr3CJXgpw5yoicw1czL xmy67E0lkiz4zu4YysF8zisRo6dnSS5ZUcZtz+Y5TDWLLBJuKYYzmR5P6gcwoGGw aKomff/e4Ox3oa0S2+OrPlG6yCkCf+oXO8a+WFYhsoFYU=; Received: (qmail 23742 invoked by alias); 10 Jul 2012 12:20:56 -0000 Received: (qmail 23731 invoked by uid 22791); 10 Jul 2012 12:20:54 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-lb0-f175.google.com (HELO mail-lb0-f175.google.com) (209.85.217.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Jul 2012 12:20:40 +0000 Received: by lbol5 with SMTP id l5so199416lbo.20 for ; Tue, 10 Jul 2012 05:20:39 -0700 (PDT) Received: by 10.112.88.34 with SMTP id bd2mr19257047lbb.33.1341922839318; Tue, 10 Jul 2012 05:20:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.4.229 with HTTP; Tue, 10 Jul 2012 05:20:19 -0700 (PDT) From: Steven Bosscher Date: Tue, 10 Jul 2012 14:20:19 +0200 Message-ID: Subject: [patch] fixes for power4 scheduler description To: Alan Modra , GCC Patches Cc: David Edelsohn X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hello, These look like typos: * "power4-store-update" wants "iuX,iuY" for X=1|2 and Y=1|2. The "iu2,iu1" case appeared twice. * "power4-three" wants "iuX,iuX,iuY|iuX,iuY,iuY" for X=1|2 and Y=1|2. The "iu1,iu1,iu2" case appeared twice. Bootstrapped&tested on powerpc64-unknown-linux-gnu. OK for trunk? Note, it'd be nice if the size of the power4iu automaton could be reduced somehow. It is by far the largest automaton in the rs6000 back end, accounting for ~40% of the total. Automaton `power4iu' 8128 NDFA states, 68391 NDFA arcs 12609 DFA states, 104521 DFA arcs 10894 minimal DFA states, 89248 minimal DFA arcs 683 all insns 23 insn equivalence classes 0 locked states 107203 transition comb vector els, 250562 trans table els: use simple vect 250562 min delay table els, compression factor 1 (All:) 124282 all allocated states, 493955 all allocated arcs 811237 all allocated alternative states 248236 all transition comb vector els, 613376 all trans table els 613376 all min delay table els 0 all locked states For comparison, power7iu: Automaton `power7iu' 7697 NDFA states, 23034 NDFA arcs 3738 DFA states, 10277 DFA arcs 3690 minimal DFA states, 10056 minimal DFA arcs 683 all insns 9 insn equivalence classes 0 locked states 10690 transition comb vector els, 33210 trans table els: use comb vect 33210 min delay table els, compression factor 1 I don't understand well enough how the scheduler descriptions are translated to DFAs, so I don't really understand why the power4iu automaton needs so many table elts, but the above seems disproportional to me. Ciao! Steven * config/rs6000/power4.md (power4-store-update): Fix reservation. (power4-three): Likewise. Index: config/rs6000/power4.md =================================================================== --- config/rs6000/power4.md (revision 189388) +++ config/rs6000/power4.md (working copy) @@ -145,7 +145,7 @@ |(du3_power4+du4_power4,lsu2_power4))+\ ((nothing,iu2_power4,iu1_power4)\ |(nothing,iu2_power4,iu2_power4)\ - |(nothing,iu1_power4,iu2_power4)\ + |(nothing,iu1_power4,iu1_power4)\ |(nothing,iu1_power4,iu2_power4))") (define_insn_reservation "power4-store-update-indexed" 12 @@ -212,7 +212,7 @@ ((iu1_power4,nothing,iu2_power4,nothing,iu2_power4)\ |(iu2_power4,nothing,iu2_power4,nothing,iu1_power4)\ |(iu2_power4,nothing,iu1_power4,nothing,iu1_power4)\ - |(iu1_power4,nothing,iu2_power4,nothing,iu2_power4))") + |(iu1_power4,nothing,iu1_power4,nothing,iu2_power4))") (define_insn_reservation "power4-insert" 4 (and (eq_attr "type" "insert_word")