From patchwork Sat Dec 1 17:40:31 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Bosscher X-Patchwork-Id: 203145 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 4A67E2C0085 for ; Sun, 2 Dec 2012 04:41:25 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1354988486; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: MIME-Version:Received:In-Reply-To:References:From:Date: Message-ID:Subject:To:Cc:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=x/MjWrd+g1sY/lmQjZeuJ6+YyoM=; b=NaVI3/gXtbAu7wM HPxh3oa1rnO9VWJ/67znqlYIDgwsf4iNx8wEiAFpOzJc8DSvtLFeWHYDMsL3RL1g YdF0dtuhs7eGQ/ZewY/s4O/0xt7qdrvSmtd65jsDPtUVZklI5M1CQhUvg0StEEue iR+01Y8Jvx/Jgb5fvXMWVxD9lhCk= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:MIME-Version:Received:In-Reply-To:References:From:Date:Message-ID:Subject:To:Cc:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=gwBEDnsvO5jvLY4y+/hIO1TWY6BHNvuIE+/YeZ2VxgeEQhCmuWrBJCG4KEN9+L GBd9gW+L8f/oezQAljYVEzCHDH9jlY6AIcDWGMoHLr59TvRsF+eittv/xIBCkCKe jwrLcuz2Hqx3JQOSp8OntaicQQ7DLQh5112ceaMbSsgD0=; Received: (qmail 809 invoked by alias); 1 Dec 2012 17:41:20 -0000 Received: (qmail 791 invoked by uid 22791); 1 Dec 2012 17:41:19 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, TW_PH X-Spam-Check-By: sourceware.org Received: from mail-ie0-f171.google.com (HELO mail-ie0-f171.google.com) (209.85.223.171) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 01 Dec 2012 17:41:12 +0000 Received: by mail-ie0-f171.google.com with SMTP id 17so2328708iea.2 for ; Sat, 01 Dec 2012 09:41:11 -0800 (PST) Received: by 10.50.40.138 with SMTP id x10mr1824559igk.41.1354383671605; Sat, 01 Dec 2012 09:41:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.166.230 with HTTP; Sat, 1 Dec 2012 09:40:31 -0800 (PST) In-Reply-To: References: From: Steven Bosscher Date: Sat, 1 Dec 2012 18:40:31 +0100 Message-ID: Subject: Re: [patch] Rework RTL CFG graph dumping to dump DOT format To: Richard Biener Cc: GCC Patches , rsandifo@gcc.gnu.org X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Sat, Dec 1, 2012 at 2:23 PM, Steven Bosscher wrote: > On Mon, Nov 26, 2012 at 4:46 PM, Richard Biener wrote: >> Btw, I of course have my own CFG dumper (producing graphviz input) >> in my local tree - attached for reference (I'm simply using it from >> gdb sessions). > > Here's my version of it. I still have to fix some minor fall-out of > not flushing the pretty-printers all over the (inappropriate) place, > but the graph dumps seem to work nicely so far. Perhaps you can try it > out and see if this is to your liking? :-) > > Bootstrapped&tested on {powerpc64,x86_64}-unknown-linux-gnu. As I > said: Still fixing some minor tree dump related fall-out. I only need this fix on top of the patch: Bootstrapped&tested on powerpc64-unknown-linux-gnu. OK for trunk? Ciao! Steven diff -u tree-pretty-print.c tree-pretty-print.c --- tree-pretty-print.c (working copy) +++ tree-pretty-print.c (working copy) @@ -161,6 +161,7 @@ { maybe_init_pretty_print (file); dump_generic_node (&buffer, t, 0, flags, false); + pp_flush (&buffer); } /* Dump the name of a _DECL node and its DECL_UID if TDF_UID is set