From patchwork Sat Jan 23 12:45:26 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Buclaw X-Patchwork-Id: 572100 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id D4D65140A98 for ; Sat, 23 Jan 2016 23:45:41 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=jP/PlO0w; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:date:message-id:subject:from:to:cc:content-type; q=dns; s=default; b=k2jcKZKnAHH89pAq2NYOQYSQzzPj6WZ4RJT8fULLpqT 9/LCThbFnoeOjxlk0YsLnq+La9nRq9kTU9wD3xVhSbFvSCMPYmNXN01pN5gObj3c UBbzXGsHTYaABJEZs1Oqs9iG/J3m4OS5O6PyecJP6IjkqhNBqe1WI5KKoZcVyMKw = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:date:message-id:subject:from:to:cc:content-type; s=default; bh=rxd7BSC22eypmggKC29alqnQ5sI=; b=jP/PlO0w+KXUm1QT6 h4QToKwMdIYJy9jZSG+MEV4uxg8KW+FcDzflTyYP0WjKCWOcIyxl0YD1CfVPZf2e 97MZj+U1PmjIeUWxdcL2NUCw0zcuNvZk6fGynRdaTBV1GdIpiOTX9ZtrjeJTbeWF K/QGSs4EcRCNIpJd5K1DyntNno= Received: (qmail 119418 invoked by alias); 23 Jan 2016 12:45:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 119379 invoked by uid 89); 23 Jan 2016 12:45:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=CONSTRUCTOR, Hx-languages-length:1261 X-Spam-User: qpsmtpd, 4 recipients X-HELO: mail-lb0-f170.google.com Received: from mail-lb0-f170.google.com (HELO mail-lb0-f170.google.com) (209.85.217.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 23 Jan 2016 12:45:30 +0000 Received: by mail-lb0-f170.google.com with SMTP id bc4so53923457lbc.2; Sat, 23 Jan 2016 04:45:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:date:message-id:subject:from :to:cc:content-type; bh=fWw0nr9BXwHFohiI7gP3HoGBPjrdtqrc/PaqdRg6cBI=; b=QFDBDRC18osQadef9eo8G+oPmWJaFPmKi1y25s+ZHLYXhU0/go7FNNFLucUf0h2xwj 0QNfCW/SkqJNspBV6rIqJXBwnEM67NnyG3Q0fsoGJcGOKCi2rEVaVRqjFckQmbPn1JEr s3QRSElA2nx9rOxkIHUW30LJFbUdHzZEnAkThpG7IU6hnvumqyZXTfj2qd7MGMPS1Dac THjiLBmL3uaJKZalmBZAvSP63geJ1p6rUhERTdoYuTgppsDS/uYYfowAF2cC0HmWq/bm GxyVvFXqzHTsUJRNquKkGmhAuTV2fxGfBJMU4uAdOb3H7hQuLQFSnwZ0smgO2k8nxxzV eGCg== X-Gm-Message-State: AG10YOTtGjYkgH6RIaWC4zPAkgMFuybCS7WBG4hMIQuFGj8tnrYEN1p968LbC7K7vVyKy9Z2+czEhI9wqHE+SQ== MIME-Version: 1.0 X-Received: by 10.112.219.35 with SMTP id pl3mr2458288lbc.32.1453553126844; Sat, 23 Jan 2016 04:45:26 -0800 (PST) Received: by 10.25.208.142 with HTTP; Sat, 23 Jan 2016 04:45:26 -0800 (PST) Date: Sat, 23 Jan 2016 13:45:26 +0100 Message-ID: Subject: [PATCH, 69217]: [6 Regression] ICE at var-tracking.c:5038 Segmentation fault From: Iain Buclaw To: gcc-patches Cc: jakub@gcc.gnu.org, ebotcazou@gcc.gnu.org, aoliva@gcc.gnu.org X-IsSubscribed: yes Hi, This fixes the regression seen from a change at revision 231897. Unfortunately I don't have any tests as it was noticed in my frontend (D). And equivalent C/C++ doesn't trigger because: - C set the mode of empty struct types as BLKmode. - C++ lowered passing around empty struct types as CONSTRUCTOR expressions. Perhaps other front-ends could trigger this, but I would not know how to write an equivalent test for them. In any case, I hope this is an obvious patch. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69217 Regards, Iain. Author: Iain Buclaw Date: Sat Jan 23 13:42:51 2016 +0100 PR rtl-optimization/69217 * var-tracking.c (tracked_record_parameter_p): Don't segfault if there are no TYPE_FIELDS set for the record type. diff --git a/gcc/var-tracking.c b/gcc/var-tracking.c index 86183b3..de3a80b 100644 --- a/gcc/var-tracking.c +++ b/gcc/var-tracking.c @@ -5128,7 +5128,8 @@ tracked_record_parameter_p (tree t) if (TREE_CODE (type) != RECORD_TYPE) return false; - if (DECL_CHAIN (TYPE_FIELDS (type)) == NULL_TREE) + if (TYPE_FIELDS (type) == NULL_TREE + || DECL_CHAIN (TYPE_FIELDS (type)) == NULL_TREE) return false; return true;