From patchwork Thu Oct 17 22:08:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sriraman Tallam X-Patchwork-Id: 284370 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 38ABF2C00B8 for ; Fri, 18 Oct 2013 09:08:32 +1100 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; q=dns; s= default; b=JWenhVvhPAqXbWW5WGEI3OfZs2C2E5M/EljH2MHDA/gdGhLX1RHCK FUnNMmXnEWkGtgwS4TfiQbJq1xs0cxIDJ2Jamz7xzP2FuXV6FqTQmPyvHgph+JEW atJenUESPvTyKeSGk9MHCgRcVqMdZYULVLG0Ckz1ctbmJyTEXMvFb0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type:content-transfer-encoding; s=default; bh=NuxJLNoiDzcVZcruhufAgD39kaA=; b=IpXMq5b8qcv7TzwmOp+FQUIG3nbT Kz/Qu7q6PLf0Gyq9l9fP729aOWvgLKZKYJbYYR1deBHo8kzYuEmCmgJ6waY5PgiU TbLGvFmOTIPVboigrGgenkDE8E5osqGEfSUf4NdtHEUSooypqWbh3P6Aijy6v+qS ZQ9x2wjz/TXyiD0= Received: (qmail 13189 invoked by alias); 17 Oct 2013 22:08:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 13157 invoked by uid 89); 17 Oct 2013 22:08:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f177.google.com Received: from mail-vc0-f177.google.com (HELO mail-vc0-f177.google.com) (209.85.220.177) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 17 Oct 2013 22:08:24 +0000 Received: by mail-vc0-f177.google.com with SMTP id ib11so12271vcb.22 for ; Thu, 17 Oct 2013 15:08:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=tFHzsX7jPWAlEq6nLzBSFx3hm6yuobziwGKyIjQE/xg=; b=O4bBz80GeIdLUo/x5p4yr1zIm29UN6UrpJgQv2E9H8ZForeno9Y6jyAc7ztrsaotpj 1WnxYNav4mYEA7cWb/dDeBsnB06Ys6K0XPqyeNbh841bI+fPV3xwwDPe4YwwjaJcC+Un pea1xfZ86f1fU0MjAIO8LasxSm/QPelWBLYgQa9Juv9rk/JTgredcGdy2FIEpKzUUBN6 0yu8htHJmpJiFRJfO0nRAfgVjuy7//zeqnLQdFtEOU6vUU2JlxDLQ0eHOvmibx9+JWlT YVK0oSQsEy2jOoSGzkrQTNU/WMPPtdsoRb21LEtbfifz3jbbomXJkwvARIQwbFhnbfgF qO+g== X-Gm-Message-State: ALoCoQnFwKC7MwwxfhTkewzoJAoQ6YulONco4fuGYdxvq+yh5nheVnxaBkBQi1iq7nbRsGHnino12rR1z6DlD4FR66e5pfa3adFH6eFfDM83lH7TMD7AK41Keo0MHzUYYLe5du+TRIUXR54/n4Mi9uLOL5Eo3Wq7jQWkdZIciwAYooGofEe+6rG+Inoan1yHhtACm3v7SMjpAsyQhymDL/Ve0RVD1G1i2w== MIME-Version: 1.0 X-Received: by 10.52.188.201 with SMTP id gc9mr3464vdc.104.1382047701988; Thu, 17 Oct 2013 15:08:21 -0700 (PDT) Received: by 10.52.167.35 with HTTP; Thu, 17 Oct 2013 15:08:20 -0700 (PDT) In-Reply-To: <16677523-21ED-4FC8-B668-32233B329808@comcast.net> References: <1382027306.2558.16.camel@ubuntu-sellcey> <20131017165206.GA25894@ibm-tiger.the-meissners.org> <16677523-21ED-4FC8-B668-32233B329808@comcast.net> Date: Thu, 17 Oct 2013 15:08:20 -0700 Message-ID: Subject: Re: [PATCH][i386]Fix PR 57756 From: Sriraman Tallam To: Mike Stump Cc: Michael Meissner , Steve Ellcey , Diego Novillo , David Edelsohn , GCC Patches , David Edelsohn , David Li , Richard Biener X-IsSubscribed: yes On Thu, Oct 17, 2013 at 1:23 PM, Mike Stump wrote: > On Oct 17, 2013, at 10:23 AM, Sriraman Tallam wrote: >>> You probably want to do something similar to what I did in the powerpc. >> >> I would need the help of target maintainers to fix it this way since >> it touches every target and it would take time for me to build and >> test every target. > > For changes that only need a compile to ensure one didn't brake a port, a configure and build of a target is 2 minutes. Over night (6 hours), you can 180 targets. Before you laugh, there are people that have done this sort of building in the past as well. The hardest part, literally, would be to come up with the list of targets. Thanks. This is the list of affected targets extracted from the link JBG pointed to: http://toolchain.lug-owl.de/buildbot/?limit=1500 "alpha-linux,bfin-elf,cr16-elf,epiphany-elf,frv-linux,h8300-elf,hppa-linux,m32c-elf,m68k-linux,mep-elf,microblaze-linux,mips64el-linux,mips64-linux,mipsel-linux,mips-linux,mmix,nios2-elf,powerpc64le-linux,powerpc64-linux,powerpcle-linux,powerpc-linux,ppc64-linux,ppc-linux,rl78-elf,rs6000-ibm-aix4.3,s390-linux,s390x-linux,sparc64-linux,sparc-linux,spu,spu-elf,vax-linux,xtensa-linux" Status: With the patch below, x86_64, i386 and powerpc native bootstrap is fine. x86_64 has one test regression in gfortran.dg/lto/pr45586 which I am looking into. Also, mips and mips-64 cross-compiler builds fine. I can check cross-compile builds on all the affected targets listed above. If this all works, I suggest using this patch to put out the current fires and proceed with individual changes to each target later. Also, there are some test case failures when built in non-sse configs in i386. I can get to it after unbreaking this. Is this reasonable? Thanks Sri Index: opth-gen.awk =================================================================== --- opth-gen.awk (revision 203779) +++ opth-gen.awk (working copy) @@ -114,6 +114,7 @@ print "extern struct gcc_options global_options;" print "extern const struct gcc_options global_options_init;" print "extern struct gcc_options global_options_set;" +print "#define target_flags_explicit global_options_set.x_target_flags" print "#endif" print "#endif" print ""