From patchwork Fri May 27 07:11:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Prathamesh Kulkarni X-Patchwork-Id: 1636155 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=MFnCyQN+; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4L8bbS3j8pz9sFx for ; Fri, 27 May 2022 17:12:19 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 85D3438356A1 for ; Fri, 27 May 2022 07:12:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 85D3438356A1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1653635535; bh=4tN4XXGQtWyy4kUfJACKgTFLwdvmqUAqmxDlGwYVyBY=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=MFnCyQN+pLFUimVVv5CZgCS07Qtjj1nqMEcIydtAyScqNWVxNhZ9CUtlMLGA40hU9 dDxNmFaYFO2icMSHPjYhpwoRaXFi6A21kbk82AVMNitoUo4TQJjMh+56RcCN//zpl1 sAQSM2Pq+uzfT9i2ccYh6uP3R0RdWI4IthAqceuo= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 7BDE73836643 for ; Fri, 27 May 2022 07:11:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7BDE73836643 Received: by mail-ej1-x635.google.com with SMTP id q21so7082170ejm.1 for ; Fri, 27 May 2022 00:11:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=4tN4XXGQtWyy4kUfJACKgTFLwdvmqUAqmxDlGwYVyBY=; b=DD7i3EIL+TdgDfIp3NJZIOfrLm4Z4NVKBJiVuG2aZaNhTXAEs3RTDqyzjnyaRrvAg0 CZXQTzBcNLkn7d9jv7CNGh23k2htiYd1w+2Lzvxbeg9wPq/mbxuz+CP9TODrxvXKuPp3 l7Q4QS+dXYT4QaSIKbL2L53ANAtZMpNGBRdrEzTaydMrWxaClrx1Tcu/i1cSQE3MaBGJ 0SoeDmrWRL5zoZ9VcZ+pOSJ4n/qZmjANyPFZBuIu8/zpguQcDy54PtqqeJD1vxqrTKae pdVfoTKSQavPukIF0VcemUYc3AEwY02Yp7bI5YjXec8v158TkGEya/aS8BPpADSuF3p7 v+sQ== X-Gm-Message-State: AOAM5326ryZDe7bkHlaRPcrTJkqw6PMgMqDCzb+bwAJczRG8QRx/Qmnf Z4U4PzP1dMjS02f3TKQRRqHDPWdS0C5c50XJowpgluQwGf8TWwuX X-Google-Smtp-Source: ABdhPJyEPqI94d3Zs8Ufv3E8tdqZJ+1ycMSKA5x6WgXrP4n4M/8ReikHeLsivknOOTo1BIrBuNjjsyXRPcSfUbxlkj8= X-Received: by 2002:a17:907:3f0f:b0:6ff:11b7:f037 with SMTP id hq15-20020a1709073f0f00b006ff11b7f037mr10550352ejc.253.1653635513040; Fri, 27 May 2022 00:11:53 -0700 (PDT) MIME-Version: 1.0 Date: Fri, 27 May 2022 12:41:17 +0530 Message-ID: Subject: vec_perm_const hook -- Fix build failure in ARM backend To: gcc Patches , Richard Sandiford X-Spam-Status: No, score=-9.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Prathamesh Kulkarni via Gcc-patches From: Prathamesh Kulkarni Reply-To: Prathamesh Kulkarni Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" Hi, I forgot to adjust prototype for arm_vectorize_vec_perm_const, which, resulted in following build error: # 00:05:33 make[3]: [Makefile:1787: armv8l-unknown-linux-gnueabihf/bits/largefile-config.h] Error 1 (ignored) # 00:10:53 /home/tcwg-buildslave/workspace/tcwg_gnu_4/abe/snapshots/gcc.git~master/gcc/config/arm/arm.cc:299:13: error: ‘bool arm_vectorize_vec_perm_const(machine_mode, rtx, rtx, rtx, const vec_perm_indices&)’ declared ‘static’ but never defined [-Werror=unused-function] # 00:12:22 make[3]: *** [Makefile:2418: arm.o] Error 1 # 00:23:34 make[2]: *** [Makefile:5005: all-stage2-gcc] Error 2 # 00:23:34 make[1]: *** [Makefile:25739: stage2-bubble] Error 2 # 00:23:34 make: *** [Makefile:1072: all] Error 2 https://gcc.gnu.org/pipermail/gcc-regression/2022-May/076645.html The attached patch fixes it. OK to commit ? Thanks, Prathamesh diff --git a/gcc/config/arm/arm.cc b/gcc/config/arm/arm.cc index 70c2d50f0cc..7ecf7b74ffa 100644 --- a/gcc/config/arm/arm.cc +++ b/gcc/config/arm/arm.cc @@ -296,8 +296,8 @@ static int arm_cortex_a5_branch_cost (bool, bool); static int arm_cortex_m_branch_cost (bool, bool); static int arm_cortex_m7_branch_cost (bool, bool); -static bool arm_vectorize_vec_perm_const (machine_mode, rtx, rtx, rtx, - const vec_perm_indices &); +static bool arm_vectorize_vec_perm_const (machine_mode, machine_mode, rtx, rtx, + rtx, const vec_perm_indices &); static bool aarch_macro_fusion_pair_p (rtx_insn*, rtx_insn*);