From patchwork Sat Oct 20 01:41:52 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Mi X-Patchwork-Id: 192885 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id E0B8C2C0093 for ; Sat, 20 Oct 2012 12:42:11 +1100 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1351302132; h=Comment: DomainKey-Signature:Received:Received:Received:Received: MIME-Version:Received:Received:In-Reply-To:References:Date: Message-ID:Subject:From:To:Cc:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=axLNLTlhtACqND37SVUSvKwudO0=; b=LvaQfx9lP1tQbt3KmYMgk+R6wscDxURXLczeSBYiOQI7q9WgX+QNIxssRZgJx3 QOxNUBJkrliWMSEe7WTyIwdxw5RXDphP8lhTTCc69g/yxgC2fBOEewJFN3GtxBJr IHVes3m7/N8ghSkDiiz7/4F7oKkzvrt5O9+D6HUwEdwBg= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:X-Google-DKIM-Signature:MIME-Version:Received:Received:In-Reply-To:References:Date:Message-ID:Subject:From:To:Cc:Content-Type:X-System-Of-Record:X-Gm-Message-State:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Qx7Fow3PqC8Zu1KJnPohD5sjUE2xFQPxH81DVe2RADgiArIC92Uo9MRdWXrv8I WtvExpH7laLjk19f4K7j8gZeWO26clxKtMhJAKFo03tn3Opj8cr/x4usFQaPwmPx pLeS8KEeM9TeGTR0w+/3PEmk9uzAGvEIxNH+Q5E0rgg0Y=; Received: (qmail 6431 invoked by alias); 20 Oct 2012 01:42:02 -0000 Received: (qmail 6420 invoked by uid 22791); 20 Oct 2012 01:42:01 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, KHOP_RCVD_TRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD, TW_LV X-Spam-Check-By: sourceware.org Received: from mail-qa0-f47.google.com (HELO mail-qa0-f47.google.com) (209.85.216.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 20 Oct 2012 01:41:54 +0000 Received: by mail-qa0-f47.google.com with SMTP id i29so457928qaf.20 for ; Fri, 19 Oct 2012 18:41:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-system-of-record:x-gm-message-state; bh=RZoompNQZ1N2zvPofvXrcyo02mzgdNoi6zWj/OtK7cM=; b=E/TU6aa6EcMVQkix6i1i1c8y8Io05YMW2wpBK831gBRCKdMZ/+tYEQITDYGFSrTN/V H4b4cQNZC3bXaIxDI4DMfPoTky6xQE+adPR5pkJRGFZsFknQaqYFcLGu7CShr+uSuV28 kS+GqvSEXMASO6KLDNN0G8pXD+EoFVTa8A85Jv7YT82C50KOq5BUXA3N9Uu6XmlCQnEa J3Uaj4HsCl2fnP9uo/Mz3v2Gi/eISL9ljz6Hgk1/3I9m+khQNcKtfEosUauPzEmt1gTd Enl5mNLmFjmzc5cCH5IBfoxjrLk/gAVU2Qv3RHmOschaKbe0qJSwiscg9yJs1tVridNQ IUQQ== MIME-Version: 1.0 Received: by 10.229.137.85 with SMTP id v21mr303810qct.17.1350697313326; Fri, 19 Oct 2012 18:41:53 -0700 (PDT) Received: by 10.49.108.194 with HTTP; Fri, 19 Oct 2012 18:41:52 -0700 (PDT) In-Reply-To: References: <20121016072730.GE584@tucnak.redhat.com> <20121018181636.GZ584@tucnak.redhat.com> Date: Fri, 19 Oct 2012 18:41:52 -0700 Message-ID: Subject: Re: [asan] migrate runtime from llvm From: Wei Mi To: Xinliang David Li Cc: Jakub Jelinek , Andrew Pinski , gcc-patches@gcc.gnu.org, Diego Novillo X-System-Of-Record: true X-Gm-Message-State: ALoCoQkaLbu6qX24uHgFUiwfI3AdoG6KtnPu4BausmCOCA0ZiVeqmP7kNs0iMcS6BZnT8/5JMZEb7o/CCADQN8iuLUtz0auUyicmcRZchFMtBHrpW8k7kJynuKEL9PHqX0MOEkhLN6/NpZv+W8BKyVG08Gewpp6gEJLr4etcNKigBZWiOFfwVXQXrR2b4R56dM7zyf0lBESK Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Thanks David. Here is the patch after removing m4 directory under libasan. And I add the dependence libasan on libstdc++-v3 to avoid problem under parallel making for now. The patch is too big even after compressed, so I have to split the patch into two parts contained in two mails. patch.part1.txt and patch.part2.txt. This is the first part. // generated by the libgomp configure. Unfortunately, due to the use of // recursive make, we can't be that specific. Thanks, Wei. On Fri, Oct 19, 2012 at 12:52 PM, Xinliang David Li wrote: > The library builds fine with the following diff. The file acinclude.m4 > is cloned from libmudflap. > > David > > index 485d169..3e847f1 100644 > --- a/libasan/aclocal.m4 > +++ b/libasan/aclocal.m4 > @@ -1037,8 +1037,8 @@ AC_SUBST([am__tar]) > AC_SUBST([am__untar]) > ]) # _AM_PROG_TAR > > -m4_include([m4/libtool.m4]) > -m4_include([m4/ltoptions.m4]) > -m4_include([m4/ltsugar.m4]) > -m4_include([m4/ltversion.m4]) > -m4_include([m4/lt~obsolete.m4]) > +m4_include([../config/ltoptions.m4]) > +m4_include([../config/ltsugar.m4]) > +m4_include([../config/ltversion.m4]) > +#m4_include([../config/lt~obsolete.m4]) > +m4_include([acinclude.m4]) > > > On Fri, Oct 19, 2012 at 11:02 AM, Wei Mi wrote: >> David, I put the m4 subdir under libasan because once I use the .m4 >> files (libtool.m4 lt~obsolete.m4 ltoptions.m4 ltsugar.m4 >> ltversion.m4) and ltmain.sh under $topsrcdir, the problem that a bad >> libtool was generated under >> $topbuilddir/x86_64-unknown-linux-gnu/libasan you met yesterday >> appeared. That is why I had to generate the new libtool m4 files and >> ltmain.sh using libtoolize. >> >> Thanks, >> Wei. >> >> On Fri, Oct 19, 2012 at 10:16 AM, Xinliang David Li wrote: >>> I tried it, and this version works for me. >>> >>> Your probably do not need to add the m4 subdir under libasan. The >>> required m4 files are either in .. or ../config dir. See how >>> libmudflap does it. >>> >>> Other than that, if there are no other comments, the change is good to >>> check into the branch. Remaining bugs can always be found and fixed >>> later. >>> >>> thanks, >>> >>> David >>> >>> >>> >>> On Thu, Oct 18, 2012 at 8:04 PM, Wei Mi wrote: >>>> Hi, >>>> >>>> David cought a problem in the last patch when he tries to built >>>> libasan. The problem was that an incomplete libtool under libasan >>>> build directory was generated. The cause is that the old patch used an >>>> old ltmain.sh to generate libtool. I fix it and attach a new patch. >>>> And the new patch move -lpthread and -ldl to libasan LDFLAGS. >>>> >>>> Thanks, >>>> Wei. --- a/Makefile.def 2012-10-19 15:36:36.156106282 -0700 +++ b/Makefile.def 2012-10-19 15:36:51.656186869 -0700 @@ -504,7 +504,6 @@ dependencies = { module=configure-target-libobjc; on=configure-target-boehm-gc; }; dependencies = { module=all-target-libobjc; on=all-target-boehm-gc; }; dependencies = { module=configure-target-libstdc++-v3; on=configure-target-libgomp; }; +dependencies = { module=configure-target-libasan; on=all-target-libstdc++-v3; }; // parallel_list.o and parallel_settings.o depend on omp.h, which is