From patchwork Fri Feb 12 20:39:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Mike Stump X-Patchwork-Id: 582291 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1C224140317 for ; Sat, 13 Feb 2016 07:43:17 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=oB9cBc6P; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; q=dns; s= default; b=Q6JvP5gmXkCUw5rvnd9EcG5cPXusxD9XbnoAo1Jlrw1VR9PK8jXuQ 8WhMBwDqJTzmmtTrEipRGu9RK+QlCOb9zJVUjMokIY+GhHrdEYxNFaclWCQbvZid 89n+/96XY5Ce+TpBdrnSyOa0PFGWiqrAyf7rEBROTTqc1l5dW7dsXI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=default; bh=K0wMGRq4ugBVgUtWAx9BFdBPDAc=; b=oB9cBc6PavFT6GP0iyWGoqcEw3Ov xP+ZdiKFrjvDTbcUUGCLuqIIaAgolt8/El0x+MhPZMcuwiuzfqc3fBD4p8c/1LzJ GBYmCyTzKFvbIDHPsJ3NCOOtN8+2fkPcyCn8nK5miFk8vdpXCYmv1Wm4mx29P0dN zkqtwKz3D3dy6z4= Received: (qmail 55794 invoked by alias); 12 Feb 2016 20:43:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 55770 invoked by uid 89); 12 Feb 2016 20:42:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_PASS autolearn=unavailable version=3.3.2 spammy=1099, 1096, 109, 9, mrs X-HELO: resqmta-po-04v.sys.comcast.net Received: from resqmta-po-04v.sys.comcast.net (HELO resqmta-po-04v.sys.comcast.net) (96.114.154.163) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 12 Feb 2016 20:42:58 +0000 Received: from resomta-po-10v.sys.comcast.net ([96.114.154.234]) by resqmta-po-04v.sys.comcast.net with comcast id HYiw1s00753iAfU01YiwkB; Fri, 12 Feb 2016 20:42:56 +0000 Received: from [IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d] ([IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d]) by resomta-po-10v.sys.comcast.net with comcast id HYiu1s0082ztT3H01Yivq5; Fri, 12 Feb 2016 20:42:55 +0000 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: TR29124 C++ Special Maths - Make pull functions into global namespace. From: Mike Stump In-Reply-To: <20160212180701.GI8441@redhat.com> Date: Fri, 12 Feb 2016 12:39:46 -0800 Cc: Ed Smith-Rowland <3dw4rd@verizon.net>, "libstdc++@gcc.gnu.org" , gcc-patches Message-Id: References: <56A0349C.4090406@verizon.net> <20160121122912.GS15084@redhat.com> <56A172CE.7090408@verizon.net> <20160122103933.GE15084@redhat.com> <56A2B8F5.8060505@verizon.net> <20160211115707.GP8441@redhat.com> <9DEAAB23-9B86-4DAF-99D8-13F22C3A3A1D@comcast.net> <20160212180701.GI8441@redhat.com> To: Jonathan Wakely X-IsSubscribed: yes On Feb 12, 2016, at 10:07 AM, Jonathan Wakely wrote: > On 12/02/16 09:52 -0800, Mike Stump wrote: >> On Feb 11, 2016, at 3:57 AM, Jonathan Wakely wrote: >>> On 10/02/16 22:36 -0800, Mike Stump wrote: >>>> I’m seeing: >>>> >>>> /home/mrs/work1/gcc/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc: In function 'void test(const testcase_riemann_zeta (&)[Num], Tp)': >>>> /home/mrs/work1/gcc/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc:285:15: error: 'riemann_zeta' is not a member of 'std' >>>> compiler exited with status 1 >>>> output is: >>>> /home/mrs/work1/gcc/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc: In function 'void test(const testcase_riemann_zeta (&)[Num], Tp)': >>>> /home/mrs/work1/gcc/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc:285:15: error: 'riemann_zeta' is not a member of 'std' >>>> >>>> FAIL: special_functions/18_riemann_zeta/check_value.cc (test for excess errors) >>>> Excess errors: >>>> /home/mrs/work1/gcc/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc:285:15: error: 'riemann_zeta' is not a member of 'std' >>>> >>>> UNRESOLVED: special_functions/18_riemann_zeta/check_value.cc compilation failed to produce executable >>>> extra_tool_flags are: >>>> -D__STDCPP_WANT_MATH_SPEC_FUNCS__ >>>> >>>> on a recent trunk. This is a typical newlib port. Not sure if this is a real bug or not, but thought I’d forward it long. >>> >>> This confused me at first, but I think what must be happening is that >>> your newlib port doesn't use c_model=c_global, so it uses a >>> header that doesn't #include . >> >>> What does your $target/libstdc++-v3/config.log show instead of >>> c_global here? >> >> configure:16304: "C" header strategy set to c_global >> >> So, I don’t know of a better way to do this, other than just provide the .ii file. You can see what it was including, and where it didn’t include what you wanted. We can then go from there. I fear a longer series of 20 questions. The good news is that this is the _only_ recent failure. >> >> /home/mrs/work1/gcc-obj/./gcc/xg++ -shared-libgcc -B/home/mrs/work1/gcc-obj/./gcc -nostdinc++ -L/home/mrs/work1/gcc-obj/machine/libstdc++-v3/src -L/home/mrs/work1/gcc-obj/machine/libstdc++-v3/src/.libs -L/home/mrs/work1/gcc-obj/machine/libstdc++-v3/libsupc++/.libs -B/home/mrs/work1/install/machine/bin/ -B/home/mrs/work1/install/machine/lib/ -isystem /home/mrs/work1/install/machine/include -isystem /home/mrs/work1/install/machine/sys-include -B/home/mrs/work1/gcc-obj/machine/./libstdc++-v3/src/.libs -D_GLIBCXX_ASSERT -fmessage-length=0 -ffunction-sections -fdata-sections -g -O2 -mno-oe -DLOCALEDIR="." -nostdinc++ -I/home/mrs/work1/gcc-obj/machine/libstdc++-v3/include/machine -I/home/mrs/work1/gcc-obj/machine/libstdc++-v3/include -I/home/mrs/work1/gcc/libstdc++-v3/libsupc++ -I/home/mrs/work1/gcc/libstdc++-v3/include/backward -I/home/mrs/work1/gcc/libstdc++-v3/testsuite/util /home/mrs/work1/gcc/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc -DMAX_ITERATIONS=5 -fno-diagnostics-show-caret -fdiagnostics-color=never ./libtestc++.a -Wl,--gc-sections -L/home/mrs/work1/gcc-obj/machine/libstdc++-v3/src/filesystem/.libs -mno-oe -lm -o ./check_value.exe -E > > Thanks, the preprocessed file did help, because it showed that > -D__STDCPP_WANT_MATH_SPEC_FUNCS__ was not being used, which is because > we have this in the test: > > // { dg-options "-D__STDCPP_WANT_MATH_SPEC_FUNCS__" } > ... > // { dg-options "-DMAX_ITERATIONS=5" { target simulator } } > Should the dg-options directive for simulators be using > dg-additional-options instead? I think that’s a good call. Testing it out: Old tests that failed, that have disappeared: (Eeek!) : special_functions/18_riemann_zeta/check_value.cc (test for excess errors) Ok? diff --git a/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc b/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc index d6b3171..f84edd8 100644 --- a/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc +++ b/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc @@ -20,7 +20,7 @@ // riemann_zeta // This can take long on simulators, timing out the test. -// { dg-options "-DMAX_ITERATIONS=5" { target simulator } } +// { dg-additional-options "-DMAX_ITERATIONS=5" { target simulator } } #ifndef MAX_ITERATIONS #define MAX_ITERATIONS (sizeof(data001) / sizeof(testcase_riemann_zeta)) @@ -109,9 +109,6 @@ data001[55] = const double toler001 = 2.5000000000000020e-13; // riemann_zeta -// This can take long on simulators, timing out the test. -// { dg-options "-DMAX_ITERATIONS=5" { target simulator } } - #ifndef MAX_ITERATIONS #define MAX_ITERATIONS (sizeof(data001) / sizeof(testcase_riemann_zeta)) #endif