From patchwork Sun Jun 12 13:18:31 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 100095 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id EE694B70A7 for ; Sun, 12 Jun 2011 23:18:56 +1000 (EST) Received: (qmail 17185 invoked by alias); 12 Jun 2011 13:18:52 -0000 Received: (qmail 17175 invoked by uid 22791); 12 Jun 2011 13:18:51 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-qw0-f47.google.com (HELO mail-qw0-f47.google.com) (209.85.216.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 12 Jun 2011 13:18:33 +0000 Received: by qwh5 with SMTP id 5so2117296qwh.20 for ; Sun, 12 Jun 2011 06:18:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.106.34 with SMTP id v34mr3057444qco.111.1307884711809; Sun, 12 Jun 2011 06:18:31 -0700 (PDT) Received: by 10.229.47.78 with HTTP; Sun, 12 Jun 2011 06:18:31 -0700 (PDT) In-Reply-To: References: <20110611150953.GA18253@intel.com> Date: Sun, 12 Jun 2011 06:18:31 -0700 Message-ID: Subject: Re: PATCH [1/n]: Prepare x32: PR middle-end/47364: internal compiler error: in emit_move_insn, at expr.c:3355 From: "H.J. Lu" To: Richard Guenther Cc: gcc-patches@gcc.gnu.org X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Sun, Jun 12, 2011 at 3:48 AM, Richard Guenther wrote: > On Sat, Jun 11, 2011 at 5:09 PM, H.J. Lu wrote: >> Hi, >> >> expand_builtin_strlen has >> >> src_reg = gen_reg_rtx (Pmode); >> ... >> pat = expand_expr (src, src_reg, ptr_mode, EXPAND_NORMAL); >> if (pat != src_reg) >>  emit_move_insn (src_reg, pat); >> >> But src_reg may be in ptr_mode, wich may not be the same as Pmode. >> This patch checks it.  OK for trunk? >> >> Thanks. >> >> >> H.J. >> --- >> 2011-06-11  H.J. Lu   >> >>        PR middle-end/47364 >>        * builtins.c (expand_builtin_strlen): Properly handle target >>        not in Pmode. >> >> diff --git a/gcc/builtins.c b/gcc/builtins.c >> index 7b24a0c..4e2cf31 100644 >> --- a/gcc/builtins.c >> +++ b/gcc/builtins.c >> @@ -2941,7 +2941,11 @@ expand_builtin_strlen (tree exp, rtx target, >>       start_sequence (); >>       pat = expand_expr (src, src_reg, ptr_mode, EXPAND_NORMAL); >>       if (pat != src_reg) >> -       emit_move_insn (src_reg, pat); >> +       { >> +         if (GET_MODE (pat) != Pmode) >> +           pat = convert_to_mode (Pmode, pat, 1); > > Shouldn't this be POINTERS_EXTEND_UNSIGNED instead of 1? > >> +         emit_move_insn (src_reg, pat); > > Why not use convert_move unconditionally? > > Or, why not expand src in Pmode from the start?  After all, src_reg is > created as Pmode reg. > This patch works for my testcase. OK for trunk? Thanks. diff --git a/gcc/builtins.c b/gcc/builtins.c index 7b24a0c..7db4e6d 100644 --- a/gcc/builtins.c +++ b/gcc/builtins.c @@ -2939,7 +2939,7 @@ expand_builtin_strlen (tree exp, rtx target, /* Now that we are assured of success, expand the source. */ start_sequence (); - pat = expand_expr (src, src_reg, ptr_mode, EXPAND_NORMAL); + pat = expand_expr (src, src_reg, Pmode, EXPAND_NORMAL); if (pat != src_reg) emit_move_insn (src_reg, pat); pat = get_insns ();