Message ID | B71DF1153024A14EABB94E39368E44A6042D63F4@SJEXCHMB13.corp.ad.broadcom.com |
---|---|
State | New |
Headers | show |
On 07/30/14 09:20, Bingfeng Mei wrote: > Yes, that fix is better. Here are updated patches. LTO-bootstrapped and tested. OK? > > Bingfeng > > Index: ChangeLog > =================================================================== > --- ChangeLog (revision 213152) > +++ ChangeLog (working copy) > @@ -1,3 +1,10 @@ > +2014-07-29 Bingfeng Mei <bmei@broadcom.com> > + > + PR lto/61868 > + * toplev.c (init_random_seed): Move piece of code never called to > + set_random_seed. > + (set_random_seed): see above. > + > 2014-07-28 Jan Hubicka <hubicka@ucw.cz> OK for the trunk. Thanks, Jeff
Thanks, Jeff. Checked in. Bingfeng > -----Original Message----- > From: Jeff Law [mailto:law@redhat.com] > Sent: 31 July 2014 04:43 > To: Bingfeng Mei; Richard Biener > Cc: Andi Kleen; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH] PR61868 > > On 07/30/14 09:20, Bingfeng Mei wrote: > > Yes, that fix is better. Here are updated patches. LTO-bootstrapped > and tested. OK? > > > > Bingfeng > > > > Index: ChangeLog > > =================================================================== > > --- ChangeLog (revision 213152) > > +++ ChangeLog (working copy) > > @@ -1,3 +1,10 @@ > > +2014-07-29 Bingfeng Mei <bmei@broadcom.com> > > + > > + PR lto/61868 > > + * toplev.c (init_random_seed): Move piece of code never called > to > > + set_random_seed. > > + (set_random_seed): see above. > > + > > 2014-07-28 Jan Hubicka <hubicka@ucw.cz> > OK for the trunk. > > Thanks, > Jeff
Index: ChangeLog =================================================================== --- ChangeLog (revision 213152) +++ ChangeLog (working copy) @@ -1,3 +1,10 @@ +2014-07-29 Bingfeng Mei <bmei@broadcom.com> + + PR lto/61868 + * toplev.c (init_random_seed): Move piece of code never called to + set_random_seed. + (set_random_seed): see above. + 2014-07-28 Jan Hubicka <hubicka@ucw.cz> * cgraph.c (cgraph_node::create_indirect_edge): Copy speculative data. Index: toplev.c =================================================================== --- toplev.c (revision 213152) +++ toplev.c (working copy) @@ -282,16 +282,7 @@ init_local_tick (void) static void init_random_seed (void) { - if (flag_random_seed) - { - char *endp; - - /* When the driver passed in a hex number don't crc it again */ - random_seed = strtoul (flag_random_seed, &endp, 0); - if (!(endp > flag_random_seed && *endp == 0)) - random_seed = crc32_string (0, flag_random_seed); - } - else if (!random_seed) + if (!random_seed) random_seed = local_tick ^ getpid (); /* Old racey fallback method */ } @@ -314,6 +305,15 @@ set_random_seed (const char *val) { const char *old = flag_random_seed; flag_random_seed = val; + if (flag_random_seed) + { + char *endp; + + /* When the driver passed in a hex number don't crc it again */ + random_seed = strtoul (flag_random_seed, &endp, 0); + if (!(endp > flag_random_seed && *endp == 0)) + random_seed = crc32_string (0, flag_random_seed); + } return old; } Index: testsuite/ChangeLog =================================================================== --- testsuite/ChangeLog (revision 213152) +++ testsuite/ChangeLog (working copy) @@ -1,3 +1,8 @@ +2014-07-29 Bingfeng Mei <bmei@broadcom.com> + + PR lto/61868 + * gcc.dg/pr61868.c: New test. + 2014-07-28 Richard Biener <rguenther@suse.de> PR rtl-optimization/61801 Index: testsuite/gcc.dg/pr61868.c =================================================================== --- testsuite/gcc.dg/pr61868.c (revision 0) +++ testsuite/gcc.dg/pr61868.c (revision 0) @@ -0,0 +1,9 @@ +/* { dg-do compile } */ +/* { dg-options "-flto -frandom-seed=0x12345" } */ +extern int foo (int); +int main () +{ + foo (100); + return 0; +} +/* { dg-final { scan-assembler "\.gnu\.lto.*.12345" } } */