Message ID | AM5PR0802MB2610B32BE92CC11209D39CCC831B0@AM5PR0802MB2610.eurprd08.prod.outlook.com |
---|---|
State | New |
Headers | show
Return-Path: <gcc-patches-return-451796-incoming=patchwork.ozlabs.org@gcc.gnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3w832B3kByz9s4s for <incoming@patchwork.ozlabs.org>; Fri, 21 Apr 2017 01:39:13 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="Pom6Hhwx"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; q=dns; s= default; b=WksKzhTHvvderOEeDMth/IfelHgu00awk2C//hcy/kBz9UR6oy+Uk sPP0yHlRafyrLQuGjX/UfggfSxLN0GlEO1ApQ7JtJ+QX0/ABKzl1pvu7YW6Q/0DY CtNBuulBc4nVrJpNmC3Qiwj4oGBzJRmM1dHlx6mubyCyj893j51zBI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:date:message-id:references:in-reply-to :content-type:content-transfer-encoding:mime-version; s=default; bh=PBEKiWgbTcHbBvOGV3PYE5cfcrs=; b=Pom6Hhwxlymi59Mq/iN2GlMQfr+6 psJR7JU9pCusWLvk2d8O/hAJIu6z/GCGQEueuGTgaC3ldz6NBSBAFnnIth+1LO+Q D2zbV9+tVjUuKk2V8Z7m+HYJxgTdPhFH2980b1rtF7dOI6+9MFuzInV3TfVBlZXF /y/uL5RWmUmxD1A= Received: (qmail 40610 invoked by alias); 20 Apr 2017 15:38:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: <gcc-patches.gcc.gnu.org> List-Unsubscribe: <mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org> List-Archive: <http://gcc.gnu.org/ml/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-help@gcc.gnu.org> Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 40568 invoked by uid 89); 20 Apr 2017 15:38:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-22.2 required=5.0 tests=AWL, BAYES_50, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-exchange-antispam-report-cfa-test:6072148, Hx-exchange-antispam-report-cfa-test:93001095, Hx-exchange-antispam-report-cfa-test:20161123555025, Hx-exchange-antispam-report-cfa-test:201702281528075 X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-he1eur01on0048.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (104.47.0.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Apr 2017 15:38:43 +0000 Received: from AM5PR0802MB2610.eurprd08.prod.outlook.com (10.175.46.18) by VI1PR08MB2672.eurprd08.prod.outlook.com (10.175.245.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1034.10; Thu, 20 Apr 2017 15:38:42 +0000 Received: from AM5PR0802MB2610.eurprd08.prod.outlook.com ([10.175.46.18]) by AM5PR0802MB2610.eurprd08.prod.outlook.com ([10.175.46.18]) with mapi id 15.01.1047.013; Thu, 20 Apr 2017 15:38:41 +0000 From: Wilco Dijkstra <Wilco.Dijkstra@arm.com> To: GCC Patches <gcc-patches@gcc.gnu.org>, James Greenhalgh <James.Greenhalgh@arm.com> CC: nd <nd@arm.com>, Evandro Menezes <e.menezes@samsung.com>, "jim.wilson@linaro.org" <jim.wilson@linaro.org>, "Andrew.pinski@cavium.com" <Andrew.pinski@cavium.com> Subject: Re: [PATCH][AArch64] Improve address cost for -mcpu=generic Date: Thu, 20 Apr 2017 15:38:41 +0000 Message-ID: <AM5PR0802MB2610B32BE92CC11209D39CCC831B0@AM5PR0802MB2610.eurprd08.prod.outlook.com> References: <AM5PR0802MB261016962C37FD59ABF5B71683030@AM5PR0802MB2610.eurprd08.prod.outlook.com> In-Reply-To: <AM5PR0802MB261016962C37FD59ABF5B71683030@AM5PR0802MB2610.eurprd08.prod.outlook.com> authentication-results: arm.com; dkim=none (message not signed) header.d=none; arm.com; dmarc=none action=none header.from=arm.com; x-microsoft-exchange-diagnostics: 1; VI1PR08MB2672; 7:P2eh3/Puy7BmO8eKTGs1GPvjjIxQHMj2QADHlkRRypdeBlVgkwFRaBev/iyWRmEi0BGm8LyZynecO6a5KL46DKGbt3K6hEEE9baeLfhDSGU31yek/8HjT0W7CkBjytV8EDq4XEsSqxfFMBSfmTCqFptQW7kiQJo8S58E7o76n3/BxD+4sMPbkrLrQmzZ1g5kxizbP5oSPZPs9vqxNl6GqMZNIsDT5UkIxLi+R4rzBIArxdgtkggbLpu09dZm8uEeCofNt03kWFj2n+97ZpUogF7IbMm/1yT7D/zEjPdbCVhjKB6SKOjDTT3l5nxEu8MG7J3SyS0bWTYh7rdPMEWRPA== x-ms-office365-filtering-correlation-id: 08820c7e-13e7-44cd-99e9-08d48803526f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081); SRVR:VI1PR08MB2672; nodisclaimer: True x-microsoft-antispam-prvs: <VI1PR08MB267266F5EAE893A0289E9D22831B0@VI1PR08MB2672.eurprd08.prod.outlook.com> x-exchange-antispam-report-test: UriScan:(180628864354917); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(6072148); SRVR:VI1PR08MB2672; BCL:0; PCL:0; RULEID:; SRVR:VI1PR08MB2672; x-forefront-prvs: 02830F0362 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39410400002)(39450400003)(39840400002)(39860400002)(39850400002)(39400400002)(377424004)(66066001)(38730400002)(6636002)(74316002)(7696004)(33656002)(8936002)(55016002)(229853002)(81166006)(7736002)(54906002)(3660700001)(6506006)(53936002)(9686003)(2950100002)(99286003)(305945005)(2900100001)(77096006)(8676002)(122556002)(86362001)(2906002)(3280700002)(3846002)(50986999)(102836003)(53546009)(6116002)(4326008)(6246003)(76176999)(189998001)(25786009)(54356999)(5660300001)(41533002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR08MB2672; H:AM5PR0802MB2610.eurprd08.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2017 15:38:41.3746 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2672 |
diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 419b756efcb40e48880cd4529efc4f9f59938325..728ce7029f1e2b5161d9f317d10e564dd5a5f472 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -193,10 +193,10 @@ static const struct aarch64_flag_desc aarch64_tuning_flags[] = static const struct cpu_addrcost_table generic_addrcost_table = { { - 0, /* hi */ + 1, /* hi */ 0, /* si */ 0, /* di */ - 0, /* ti */ + 1, /* ti */ }, 0, /* pre_modify */ 0, /* post_modify */
ping From: Wilco Dijkstra Sent: 12 April 2017 14:08 To: GCC Patches Cc: nd; James Greenhalgh; Evandro Menezes; jim.wilson@linaro.org; Andrew.pinski@cavium.com Subject: [PATCH][AArch64] Improve address cost for -mcpu=generic All cores which add a cpu_addrcost_table use a non-zero value for HI and TI mode shifts (a non-zero value for general indexing also applies to all shifts). Given this, it makes no sense to use a different setting in generic_addrcost_table. So change it so that all supported cores, including -mcpu=generic, now generate the same: int f(short *p, short *q, long x) { return p[x] + q[x]; } lsl x2, x2, 1 ldrsh w3, [x0, x2] ldrsh w0, [x1, x2] add w0, w3, w0 ret Bootstrapped for AArch64. Any comments? OK for stage 1? ChangeLog: 2017-04-12 Wilco Dijkstra <wdijkstr@arm.com> * gcc/config/aarch64/aarch64.c (generic_addrcost_table): Change HI/TI mode setting. ---