From patchwork Thu Oct 14 15:54:12 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 67836 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 4C72F1007D4 for ; Fri, 15 Oct 2010 02:54:37 +1100 (EST) Received: (qmail 26342 invoked by alias); 14 Oct 2010 15:54:35 -0000 Received: (qmail 26325 invoked by uid 22791); 14 Oct 2010 15:54:33 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, TW_QN X-Spam-Check-By: sourceware.org Received: from mail-gx0-f175.google.com (HELO mail-gx0-f175.google.com) (209.85.161.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Oct 2010 15:54:27 +0000 Received: by gxk19 with SMTP id 19so55698gxk.20 for ; Thu, 14 Oct 2010 08:54:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.161.6 with SMTP id n6mr2234236muo.18.1287071653278; Thu, 14 Oct 2010 08:54:13 -0700 (PDT) Received: by 10.220.181.138 with HTTP; Thu, 14 Oct 2010 08:54:12 -0700 (PDT) In-Reply-To: <4CAB1B9D.3060803@ispras.ru> References: <4CAB1B9D.3060803@ispras.ru> Date: Thu, 14 Oct 2010 08:54:12 -0700 Message-ID: Subject: Re: [PATCH] Fix PR45570 From: "H.J. Lu" To: Andrey Belevantsev Cc: GCC Patches , "Vladimir N. Makarov" X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org 2010/10/5 Andrey Belevantsev : > Hello, > > As explained in the PR trail, this is the variant of PR40101 when we cannot > devise a positive seqno for a bookkeeping copy by examining insn's > neighbors.  Fixed by removing the assert and allowing the code of PR40101 > patch to provide an arbitrary positive value. > > Bootstrapped and regtested on ia64-linux, the testcase is also verified on > x86-64 as reported in the PR.  Ok for trunk? > > Andrey > > 2010-10-05  Andrey Belevantsev   > >        PR rtl-optimization/45570 > >        * sel-sched-ir.c (cfg_preds_1): When walking out of the region, > assert >        that we are pipelining outer loops.  Allow returning zero > predecessors. > >        * gcc.dg/pr45570.c: New test. > > I checked in this patch to fix typos in testcase. Index: gcc.dg/pr45570.c =================================================================== --- gcc.dg/pr45570.c (revision 165473) +++ gcc.dg/pr45570.c (working copy) @@ -1,5 +1,5 @@ -/* { dg-do compile { target powerpc*-*-* ia64-*-* x86_64-*-* } } */ -/* { dg-options "O3 -fselective-scheduling2 -fsel-sched-pipelining -fsel-sched-pipelining-outer-loops -ftracer" } */ +/* { dg-do compile { target powerpc*-*-* ia64-*-* i?86-*-* x86_64-*-* } } */ +/* { dg-options "-O3 -fselective-scheduling2 -fsel-sched-pipelining -fsel-sched-pipelining-outer-loops -ftracer" } */ void parser_get_next_char (char c, int qm, char *p) { @@ -26,33 +26,3 @@ parser_get_next_parameter (char *p) { parser_get_next_char (':', 1, p); } - -/* { dg-do compile { target powerpc*-*-* ia64-*-* x86_64-*-* } } */ -/* { dg-options "O3 -fselective-scheduling2 -fsel-sched-pipelining -fsel-sched-pipelining-outer-loops -ftracer" } */ -void -parser_get_next_char (char c, int qm, char *p) -{ - int quote_mode = 0; - for (; *p; p++) - { - if (qm) - { - if (quote_mode == 0 && *p == '"' && *(p - 1)) - { - quote_mode = 1; - continue; - } - if (quote_mode && *p == '"' && *(p - 1)) - quote_mode = 0; - } - if (quote_mode == 0 && *p == c && *(p - 1)) - break; - } -} - -void -parser_get_next_parameter (char *p) -{ - parser_get_next_char (':', 1, p); -} - Index: ChangeLog =================================================================== --- ChangeLog (revision 165473) +++ ChangeLog (working copy) @@ -1,3 +1,7 @@ +2010-10-14 H.J. Lu + + * gcc.dg/pr45570.c: Fix typos. Also run for i?86-*-*. + 2010-10-14 Joseph Myers PR c/45969