From patchwork Sat Oct  9 05:04:12 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patchwork-Submitter: "H.J. Lu" <hjl.tools@gmail.com>
X-Patchwork-Id: 67314
Return-Path: 
 <gcc-patches-return-274954-incoming=patchwork.ozlabs.org@gcc.gnu.org>
X-Original-To: incoming@patchwork.ozlabs.org
Delivered-To: patchwork-incoming@bilbo.ozlabs.org
Received: from sourceware.org (server1.sourceware.org [209.132.180.131])
	by ozlabs.org (Postfix) with SMTP id E3A48B6F06
	for <incoming@patchwork.ozlabs.org>;
	Sat,  9 Oct 2010 16:04:22 +1100 (EST)
Received: (qmail 23821 invoked by alias); 9 Oct 2010 05:04:20 -0000
Received: (qmail 23812 invoked by uid 22791); 9 Oct 2010 05:04:19 -0000
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=AWL, BAYES_00,
	DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM,
	RCVD_IN_DNSWL_NONE
X-Spam-Check-By: sourceware.org
Received: from mail-vw0-f47.google.com (HELO mail-vw0-f47.google.com)
	(209.85.212.47) by sourceware.org (qpsmtpd/0.43rc1) with
	ESMTP; Sat, 09 Oct 2010 05:04:14 +0000
Received: by vws9 with SMTP id 9so681370vws.20 for <gcc-patches@gcc.gnu.org>;
	Fri, 08 Oct 2010 22:04:12 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.203.12 with SMTP id fg12mr987341vcb.133.1286600652382;
	Fri, 08 Oct 2010 22:04:12 -0700 (PDT)
Received: by 10.220.202.9 with HTTP; Fri, 8 Oct 2010 22:04:12 -0700 (PDT)
In-Reply-To: <AANLkTin3uowh7Oh43nSZz4GrK2V5_SeCmJTHeDbf+QOD@mail.gmail.com>
References: <4CAC37E8.9060504@gmail.com>	<4CACC0FC.7070906@redhat.com>
	<4CACF6D7.4020308@gmail.com>	<4CAE332B.6090608@gmail.com>
	<AANLkTin3uowh7Oh43nSZz4GrK2V5_SeCmJTHeDbf+QOD@mail.gmail.com>
Date: Fri, 8 Oct 2010 22:04:12 -0700
Message-ID: <AANLkTimtQLbjMFjMjW3XYQZyJWu_8Bw4QN4MDO1qrBfq@mail.gmail.com>
Subject: Re: [PATCH,
	take2] Make LTO plugin object-file-format- and host- independent.
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Dave Korn <dave.korn.cygwin@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Unsubscribe: 
 <mailto:gcc-patches-unsubscribe-incoming=patchwork.ozlabs.org@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Delivered-To: mailing list gcc-patches@gcc.gnu.org

On Fri, Oct 8, 2010 at 9:45 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Oct 7, 2010 at 1:52 PM, Dave Korn <dave.korn.cygwin@gmail.com> wrote:
>> On 06/10/2010 23:23, Dave Korn wrote:
>>> On 06/10/2010 19:33, Richard Henderson wrote:
>>
>>>> Patch is ok.
>>>
>>>   Thanks :)
>>
>>  Committed revision 165133.  Will sync top-level to src/ in a few minutes.
>>
>
> This caused:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=45951
>

We can't do

. ${srcdir}/../gcc/config.gcc
case ${lto_binary_reader} in
  *coff*) LTO_FORMAT=coff ;;
  *elf*)  LTO_FORMAT=elf ;;
  *) AC_MSG_ERROR([LTO plugin is not supported on this target.]) ;;
esac

with noncanonical target. I am checking this patch as an obvious fix.

diff --git a/lto-plugin/configure.ac b/lto-plugin/configure.ac
index c43b264..4d9380e 100644
--- a/lto-plugin/configure.ac
+++ b/lto-plugin/configure.ac
@@ -1,5 +1,6 @@
 AC_PREREQ(2.64)
 AC_INIT([LTO plugin for ld], 0.1,,[lto-plugin])
+AC_CANONICAL_SYSTEM
 GCC_TOPLEV_SUBDIRS
 AM_INIT_AUTOMAKE([foreign no-dist])
 AM_MAINTAINER_MODE