From patchwork Thu Jun 18 20:54:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Stump X-Patchwork-Id: 486492 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id ADDED1401F6 for ; Fri, 19 Jun 2015 06:56:02 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=R8ugI1EI; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; q=dns; s= default; b=cJhXSkMjZqBgWBeC8RWEiNVIsge48PdBfi4jqo1ewDo5F+FWzl1oP ZHk2U9ea6aWs1jdif0yeGgYzv/1QukFvIoekbhxdvd4LxcADtLyb9Zv2L/9ZKk7y Wa79f0A0vsUFpofgoQFcQLKJUtAFri2Lp0Ojyws/dNKcIp16idplZA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=default; bh=3zCt8y9qXEmr8f2GpTwr6GL1ato=; b=R8ugI1EI4jC+bBR4HWc/f+kcSXH3 UpWvRxhJMQHnFnuiByVJBv3LLij6Dnjolp5wd/orPOAEodQP0Jco5/JbO3IDNLpc bMKoJHC5ruP+GvrkFgdPBb0TfNMD+xQEPAXQpZ9s7w2jY/y1yOvk8+pOKQaqWy7K AHAo4AScsQwHu5Q= Received: (qmail 61002 invoked by alias); 18 Jun 2015 20:55:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 60991 invoked by uid 89); 18 Jun 2015 20:55:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: resqmta-po-04v.sys.comcast.net Received: from resqmta-po-04v.sys.comcast.net (HELO resqmta-po-04v.sys.comcast.net) (96.114.154.163) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 18 Jun 2015 20:55:55 +0000 Received: from resomta-po-09v.sys.comcast.net ([96.114.154.233]) by resqmta-po-04v.sys.comcast.net with comcast id hwtm1q00D52QWKC01wvtwG; Thu, 18 Jun 2015 20:55:53 +0000 Received: from [IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d] ([IPv6:2001:558:6045:a4:40c6:7199:cd03:b02d]) by resomta-po-09v.sys.comcast.net with comcast id hwvr1q00C2ztT3H01wvroM; Thu, 18 Jun 2015 20:55:52 +0000 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: libiberty TAGS From: Mike Stump In-Reply-To: <874mm4bvq7.fsf@igel.home> Date: Thu, 18 Jun 2015 13:54:51 -0700 Cc: GCC Patches Message-Id: References: <17242213-EF29-4BDE-929B-AB383C8AA9B2@comcast.net> <874mm4bvq7.fsf@igel.home> To: Andreas Schwab X-IsSubscribed: yes On Jun 18, 2015, at 1:35 PM, Andreas Schwab wrote: > Mike Stump writes: > >> + cd $(srcdir) && etags `for i in $(CFILES); do echo $(srcdir)/$$i ; done` > > This doesn't work with a relative $(srcdir). Sure it does. I had tested with: srcdir = ../../gcc/libiberty which is a pretty typical relative srcdir, is it not? Anyway, I see your point. How about: Ok? diff --git a/libiberty/Makefile.in b/libiberty/Makefile.in index f06cc69..11e5ce6 100644 --- a/libiberty/Makefile.in +++ b/libiberty/Makefile.in @@ -409,8 +409,9 @@ stamp-noasandir: etags tags: TAGS etags-subdir +VPATH = @srcdir@ TAGS: $(CFILES) - etags `for i in $(CFILES); do echo $(srcdir)/$$i ; done` + cd $(srcdir) && etags $(CFILES) # The standalone demangler (c++filt) has been moved to binutils. # But make this target work anyway for demangler hacking.