From patchwork Sat Jul 22 15:53:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 1811302 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=8.43.85.97; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.a=rsa-sha256 header.s=default header.b=TQaLgWIE; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4R7WF05pwCz1yZ7 for ; Sun, 23 Jul 2023 01:53:50 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1162F385E45D for ; Sat, 22 Jul 2023 15:53:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1162F385E45D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1690041228; bh=1Se8DXsIU/aQMB8fPCAGAjWdOZ/B74+FemXdVVYnTNU=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=TQaLgWIEPxnr3kQpppZPdw9nU1hS3JOVxrQG+1dQbyc5Sf7pprBNSDUMCGG28wU8A TSEQEm3I2O6mW7bannxn01oZR5AvmzvZFV1MMDLOfFgvtHoROCJc9cP5fokXCOfA9N aCbm64UNDU+yDmjS2uvzUs7UUDJgNkRW7jdjKw8Y= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id 730653853D1A for ; Sat, 22 Jul 2023 15:53:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 730653853D1A Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1b8ad356fe4so18582135ad.2 for ; Sat, 22 Jul 2023 08:53:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690041207; x=1690646007; h=to:subject:from:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1Se8DXsIU/aQMB8fPCAGAjWdOZ/B74+FemXdVVYnTNU=; b=B2nnA5oWr2rLqlWCWhkvVb8Gbe6/jld+rGZlbT3LvhkkbG3RiQEyv/uP0mXkqu6F/3 Yz0Kqc5u1sl45RlmTbmF3B5/QEw2gYRUC9JjdKI/AKhIMdFk+J0/wGYiw5zor6q4c+2B 8re23MzLGw5oS/4tY4vXWEDdARYoImQpAHw2zM4VT+76F5NMgXKOoEemD2cL/WdXzvDz /lB/EyYQ/4JRneWVc4r8KOGztOSiRMuxdEPjny2hMOVsyJjrnlcsU9TW/C/gyrOyDUNb 5eA0TXpIRIwJIo5FUCUXOrvh+6h4s27xQLKN46WkhzICm3dQb1RRAHWnh4Ccki3TLHtq ihUQ== X-Gm-Message-State: ABy/qLanStw9VJ4ilJOzOznPk5m32Ja6ew4lzgek38iIM8y4ac0nco+a DYFIZ9+kSzO6W5Nj8omAZOxb7ltlYlF84g== X-Google-Smtp-Source: APBJJlFXCYFc7KjCI18GHQzUFTUcxshAtXB5OjaYFeI02YlYmQk99Y+2l10/v/KMtxXW/7URuWu6Ew== X-Received: by 2002:a17:902:ecc3:b0:1bb:141c:3034 with SMTP id a3-20020a170902ecc300b001bb141c3034mr5265177plh.12.1690041206865; Sat, 22 Jul 2023 08:53:26 -0700 (PDT) Received: from [172.31.1.103] ([172.56.168.196]) by smtp.gmail.com with ESMTPSA id t19-20020a1709028c9300b001993a1fce7bsm1665673plo.196.2023.07.22.08.53.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Jul 2023 08:53:26 -0700 (PDT) Message-ID: <9cd24eab-f811-01fd-72f1-36c4c7a7f1ea@gmail.com> Date: Sat, 22 Jul 2023 09:53:24 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US Subject: [committed] Fix length computation bug in bfin port To: "gcc-patches@gcc.gnu.org" X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_SBL_CSS, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jeff Law via Gcc-patches From: Jeff Law Reply-To: Jeff Law Errors-To: gcc-patches-bounces+incoming=patchwork.ozlabs.org@gcc.gnu.org Sender: "Gcc-patches" The tester seemed to occasionally ping-pong a compilation failure on the builtin-bitops-1.c test. I long suspected it was something like length computations. I finally got a few minutes to dig into it, and sure enough the blackfin port was claiming the "ones" operation was 2 bytes when it is in fact 4 bytes. This fixes the compilation failure for the builtin-bitops-1.c test. Sadly, it doesn't fix any of the other failures on the bfin port. Committed to the trunk. Jeff commit bb095e8a343db043a0cd0b0da9b2ab1186d1a1ed Author: Jeff Law Date: Sat Jul 22 09:47:21 2023 -0600 [committed] Fix length computation bug in bfin port The tester seemed to occasionally ping-pong a compilation failure on the builtin-bitops-1.c test. I long suspected it was something like length computations. I finally got a few minutes to dig into it, and sure enough the blackfin port was claiming the "ones" operation was 2 bytes when it is in fact 4 bytes. This fixes the compilation failure for the builtin-bitops-1.c test. Sadly, it doesn't fix any of the other failures on the bfin port. Committed to the trunk. gcc/ * config/bfin/bfin.md (ones): Fix length computation. diff --git a/gcc/config/bfin/bfin.md b/gcc/config/bfin/bfin.md index 9b5ab071778..c6b174dc3bd 100644 --- a/gcc/config/bfin/bfin.md +++ b/gcc/config/bfin/bfin.md @@ -1401,7 +1401,8 @@ (define_insn "ones" (popcount:SI (match_operand:SI 1 "register_operand" "d"))))] "" "%h0 = ONES %1;" - [(set_attr "type" "alu0")]) + [(set_attr "type" "alu0") + (set_attr "length" "4")]) (define_expand "popcountsi2" [(set (match_dup 2)