From patchwork Fri Aug 16 21:50:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 1148468 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-507154-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="HEBiACnM"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 469H7r0rgcz9sML for ; Sat, 17 Aug 2019 07:51:02 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=JCicDRS9J+FlO5+3o/tfUX7TsX8HfsDAyzaKxBB0brtTaBBmIG D+gRvIkFyEdjC3QERMLOXHbF78OcRqD67HW0mH4YUOwjhsQY8+DxUv1K57cc8DV9 XPJmn74LXx0T8h6e0cjyERrijD8WLmnwAT/iiBOu4dHMJJc/Bcr31wFXY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=9rUnecZ2PYZzuCD/H65ZtWuN04M=; b=HEBiACnM7gqB/nQO87WK +3GkSl4RAp6JwOunRR7TvIEFUk/AA6Sz4FDtjjxoCqC21FBti52tckwGpEGb0T5Z E8BwUttC3PRhH05L8LPCA5jsI++0cMDoUK1YW8D8SOhhfTDwIIv/zMKMdUkL2JGC +Eh5SU1MCHtTiOCbhWwrlvU= Received: (qmail 43575 invoked by alias); 16 Aug 2019 21:50:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 43567 invoked by uid 89); 16 Aug 2019 21:50:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.5 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Aug 2019 21:50:54 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4BC7D5AFDE for ; Fri, 16 Aug 2019 21:50:53 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-5.rdu2.redhat.com [10.10.112.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9C0BE18A26 for ; Fri, 16 Aug 2019 21:50:52 +0000 (UTC) To: gcc-patches From: Jeff Law Subject: [committed] Fix SH test compromised by recent forwprop changes Openpgp: preference=signencrypt Message-ID: <95e9e0f9-0e04-6b68-5504-f39fc2dba286@redhat.com> Date: Fri, 16 Aug 2019 15:50:51 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 X-IsSubscribed: yes My tester threw regressions for the SH targets overnight. This was bisect down to this patch: commit ce1d21d251fee17a70ee9f8ff9e57620126f28c7 (refs/bisect/bad) Author: rguenth Date: Fri Aug 16 09:27:34 2019 +0000 2019-08-16 Richard Biener * tree-ssa-forwprop.c (simplify_builtin_call): Do not remove stmt at gsi_p, instead replace it with a NOP removed later. (pass_forwprop::execute): Fully propagate lattice, DCE stmts that became dead because of that. fortran/ * trans-intrinsic.c (gfc_conv_intrinsic_findloc): Initialize forward_branch to avoid bogus uninitialized warning. * gcc.dg/tree-ssa/forwprop-31.c: Adjust. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@274563 138bc75d-0d04-0410-961f-82ee72b054a4 After looking at the .optimized dump as well as the resulting assembly it's quite clear that after Richi's change the resulting code is better (smaller & fewer branches). The test still seems useful and can be restored to testing its original intent by disabling forwprop. So that's what I've done. Installing on the trunk momentarily. Jeff diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index b9a752cedff..408897e47f4 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2019-08-16 Jeff Law + + * gcc.target/sh/pr54236-6.c: Use -fno-tree-forwprop. + 2019-08-16 Martin Sebor * gcc.dg/struct-ret-1.c: Enable on all targets. diff --git a/gcc/testsuite/gcc.target/sh/pr54236-6.c b/gcc/testsuite/gcc.target/sh/pr54236-6.c index cc477927d2a..93bfeb36951 100644 --- a/gcc/testsuite/gcc.target/sh/pr54236-6.c +++ b/gcc/testsuite/gcc.target/sh/pr54236-6.c @@ -9,7 +9,7 @@ */ /* { dg-do compile } */ -/* { dg-options "-O2" } */ +/* { dg-options "-O2 -fno-tree-forwprop" } */ /* { dg-final { scan-assembler-times {tst #1,r0} 1 } } */ /* { dg-final { scan-assembler-times {subc r} 1 } } */