From patchwork Mon Jan 9 10:04:05 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: FX Coudert X-Patchwork-Id: 712537 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3txrNY5qmSz9sDF for ; Mon, 9 Jan 2017 21:04:28 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="buNNva5W"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :message-id:content-type:mime-version:subject:date:in-reply-to :cc:to:references; q=dns; s=default; b=iQDOubXt7A4SgcrtXymWfbeZx BocC19wfh0SLRC3+INWMAB9u4FLkx+gcRVyUnVS4L/M1saZ61bErmb8Q1P+W+FYI zPPNdzkSrAUt+jrv+RbOQKRq3zyeEFU7VwNiItoxihHJD3Ti+d6SzSK9YRVOTffP KargIykLZ8qON+jJQw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :message-id:content-type:mime-version:subject:date:in-reply-to :cc:to:references; s=default; bh=GM/gm69NnRBXf5Yd0d+7QFmAJMM=; b= buNNva5WoAbEUxfYJkLO9HKGT1el4ImZyGRiZXLXkJzQzqE2fg6n0/9KYicqlyoa XdOOFae0tTa3ThxjlzQfBxahk9+h3ZtaGYaQyU0xe83/BsMjovw5HVdvMlCXzvbz rPphDgmpQ5wsRpyCR7Mfh0TW0tPZqqHfeLXQY0S5BiY= Received: (qmail 120228 invoked by alias); 9 Jan 2017 10:04:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 120195 invoked by uid 89); 9 Jan 2017 10:04:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=no version=3.3.2 spammy=H*r:192.168.100, HX-Received:Mon, sk:fxcoude, fxcoudertgccgnuorg X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wm0-f65.google.com Received: from mail-wm0-f65.google.com (HELO mail-wm0-f65.google.com) (74.125.82.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Jan 2017 10:04:09 +0000 Received: by mail-wm0-f65.google.com with SMTP id r126so522756wmr.3; Mon, 09 Jan 2017 02:04:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=fwwgmCV7C9JTNWpUJjiYslmoSib+Ade1AhwqirovPGQ=; b=Lx0Ib/BUs1pV5OlGNnCKa+BsVV+gV328Zl6guFA0qYEfPTwrmQQ8MEQXQ/bWXXlK2K LX5Aocrq9m5HfJSlGITfY0iwtzec96A272RzFUVVI5ePoFin2zRR96+PqUcdU6tei1Yp RvB6nflFQG05PZCNIDWSGIN2B5soe+trpQmciAb4PaLU+zcnX9tXUWVKnq6EB2ZCE6p5 ppD1kaRL7y1Q5ZYALF6Au7AO9qIK58iaZd9LJqzIvs+qZq6mrVs4FdhCJ51TJ66/WuuU tN9qy47jDMfbrBiBypP4B/rznBQlVK+8IYicnH+xlKeVIoh3OVUOFALThtYK7nD2velV jrFQ== X-Gm-Message-State: AIkVDXIcu7pXdlJTF5V5EsVWMPazJf9pSiR/f7ln7MmKk4dW5/zcyk9XdwqGAGsw0Vtaaw== X-Received: by 10.223.169.114 with SMTP id u105mr11361062wrc.173.1483956247696; Mon, 09 Jan 2017 02:04:07 -0800 (PST) Received: from [192.168.100.5] (chp127.enscp.fr. [193.51.253.127]) by smtp.gmail.com with ESMTPSA id x7sm122891384wjp.18.2017.01.09.02.04.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jan 2017 02:04:05 -0800 (PST) From: FX Message-Id: <929E41CA-3ADF-4C09-90D5-CD13660F5E35@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 10.2 \(3259\)) Subject: Re: [patch,libgomp] Make libgomp Fortran modules multilib-aware Date: Mon, 9 Jan 2017 11:04:05 +0100 In-Reply-To: <765E0C1E-597F-427F-909A-1DD909512431@gmail.com> Cc: GCC Patches , Fortran List To: Jack Howarth , Richard Henderson , Jakub Jelinek References: <4795FF84-EC6B-448F-991E-AAA8948D5EE4@gmail.com> <93D9F5BF-2BFD-4DC9-957E-EB3CAA41E7D9@gmail.com> <765E0C1E-597F-427F-909A-1DD909512431@gmail.com> Given lack of review of this Fortran-specific patch for libgomp, can a Fortran maintainer approve it please? FX > *ping* > > This patch from May makes libgomp install its Fortran modules in the correct multilib-aware directories, following what libgfortran does. > > > > >> The attached patch allows libgomp to install its Fortran modules in the correct multilib-aware directories, just like libgfortran does. >> Without it, multilib Fortran OpenMP code using the modules fails to compile because the modules are not found: >> >> $ gfortran -fopenmp a.f90 >> $ gfortran -fopenmp a.f90 -m32 >> a.f90:1:6: >> >> use omp_lib >> 1 >> Fatal Error: Can't open module file ‘omp_lib.mod’ for reading at (1): No such file or directory >> compilation terminated. >> >> >> >> Bootstrapped and tested on x86_64-apple-darwin15. OK to commit? >> >> FX >> >> >> >> >> >> >> 2016-05-03 Francois-Xavier Coudert >> >> PR libgomp/60670 >> * Makefile.am: Make fincludedir multilib-aware. >> * Makefile.in: Regenerate. Index: libgomp/Makefile.am =================================================================== --- libgomp/Makefile.am (revision 235843) +++ libgomp/Makefile.am (working copy) @@ -10,7 +10,7 @@ config_path = @config_path@ search_path = $(addprefix $(top_srcdir)/config/, $(config_path)) $(top_srcdir) \ $(top_srcdir)/../include -fincludedir = $(libdir)/gcc/$(target_alias)/$(gcc_version)/finclude +fincludedir = $(libdir)/gcc/$(target_alias)/$(gcc_version)$(MULTISUBDIR)/finclude libsubincludedir = $(libdir)/gcc/$(target_alias)/$(gcc_version)/include vpath % $(strip $(search_path))