From patchwork Sat Nov 18 08:05:13 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 839229 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-467274-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="pv81Dd6N"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yf6y61mPtz9ryr for ; Sat, 18 Nov 2017 19:06:26 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=MOBCzU4LHtj+0cnfdVGPyo6QfodmIOVF3+n6PGlJA4K/6AKEOz Elvi6bWIouWArO0AoEkxr2T/fNG+lYWkvAMiMwHnq29aZj8Y8VbW6DkXAcxVWQTg 6qrs6SypbdQQi7PLcWtQ28KJY+CQmNHej1bCG4iZIFBEq59qU93g8jGrY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=y4JgaVEWCGXUslWgAl3H7rYf8lY=; b=pv81Dd6NstcfqEcLzpva 7Q4O8b2j8OtjrhZl2YM6uzo6xiiiIQxm/oclm0HrFkCNmVIjHe9LoR7aFPgY4MaR Z+BEkRB71p7naaiSMSD7LbA0Db91xm/cyAnRWKhq+V1jmz3AWbNkSfT5W210SU5L xkwam1Ke9O3rGprWy80Abbo= Received: (qmail 26491 invoked by alias); 18 Nov 2017 08:06:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 25596 invoked by uid 89); 18 Nov 2017 08:05:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KB_WAM_FROM_NAME_SINGLEWORD, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=visit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 18 Nov 2017 08:05:16 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AF8A21546B for ; Sat, 18 Nov 2017 08:05:15 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-12.rdu2.redhat.com [10.10.112.12]) by smtp.corp.redhat.com (Postfix) with ESMTP id 320FD60DCE for ; Sat, 18 Nov 2017 08:05:14 +0000 (UTC) To: gcc-patches From: Jeff Law Subject: [RFA][PATCH] 9/n Finish moving BB_VISITED handling into range analyzer Message-ID: <888a1033-3bfe-aa25-534f-3bfdcb43f8e9@redhat.com> Date: Sat, 18 Nov 2017 01:05:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 X-IsSubscribed: yes I didn't want to rebase my patchset yet again to fix this minor goof. I moved initialization of BB_VISITED into the range analyzer, but forgot to move setting it as we visit each block into the analyzer. This fixes that oversight. Bootstrapped and regression tested on x86. OK for the trunk? Jeff * gimple-ssa-evrp.c (evrp_dom_walker::before_dom_children): Do not set BB_VISITED here. * gimple-ssa-evrp-analyze.c (evrp_range_analyzer::enter): Set BB_VISITED here instead. commit 0455c00f320dc1136ca742e46ca5a184e144b0e6 Author: Jeff Law Date: Fri Nov 17 15:15:36 2017 -0500 FIx bb_visited handling diff --git a/gcc/gimple-ssa-evrp-analyze.c b/gcc/gimple-ssa-evrp-analyze.c index 4f33c644a74..9e581834d08 100644 --- a/gcc/gimple-ssa-evrp-analyze.c +++ b/gcc/gimple-ssa-evrp-analyze.c @@ -61,6 +61,7 @@ evrp_range_analyzer::enter (basic_block bb) stack.safe_push (std::make_pair (NULL_TREE, (value_range *)NULL)); record_ranges_from_incoming_edge (bb); record_ranges_from_phis (bb); + bb->flags |= BB_VISITED; } /* Find new range for NAME such that (OP CODE LIMIT) is true. */ diff --git a/gcc/gimple-ssa-evrp.c b/gcc/gimple-ssa-evrp.c index 5fa9cfb3538..27a983dd9ae 100644 --- a/gcc/gimple-ssa-evrp.c +++ b/gcc/gimple-ssa-evrp.c @@ -228,8 +228,6 @@ evrp_dom_walker::before_dom_children (basic_block bb) } } - bb->flags |= BB_VISITED; - return taken_edge; }