| Message ID | 87zj5jc9y1.fsf@redhat.com |
|---|---|
| State | New |
| Headers | show |
Hi Nick, On Tue, 5 May 2015, Nick Clifton wrote: > I recently contributes a patch to enhance the MSP430 backend with the > ability to automatically distribute code and data between high and low > memory regions. Below is a patch to update the html documentation > with a description of this new feature. Is it OK to apply ? as maintainer of the port you do not need anyone else's approval. That said, I am always happy to provide a second pair of eyes, so here are some comments: > Index: htdocs/gcc-5/changes.html > =================================================================== > + <li><p>The MSP430 compiler now has the ability to automatically distribute code > + and data between low (less than 64K) memory and high memory. Should that be "addresses below ..." or something like that, since the system would still have more than 64K of memory, not less? > + This only > + applies parts Is a "to" missing here? > + <p>Two new command line options - <code>-mcode-region=[lower|upper|either]</code> "command-line options" Does this really apply to GCC 5, or GCC 6 and the (new) gcc-6/changes.html? Gerald
Hi Gerald, > as maintainer of the port you do not need anyone else's approval. Thanks - have checked the (editted) patch in. > That said, I am always happy to provide a second pair of eyes, so > here are some comments: Thanks for those too. I have made the appropriate changes following your suggestions. > Does this really apply to GCC 5, or GCC 6 and the (new) gcc-6/changes.html? GCC 6. I had forgotten to run "cvs update -d" in the wwwdocs directory and so only saw the gcc-5 directory. Doh. I have now applied the patch to the gcc-6/changes.html file. Cheers Nick
Index: htdocs/gcc-5/changes.html =================================================================== RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-5/changes.html,v retrieving revision 1.120 diff -u -3 -p -r1.120 changes.html --- htdocs/gcc-5/changes.html 1 May 2015 22:44:45 -0000 1.120 +++ htdocs/gcc-5/changes.html 5 May 2015 15:31:03 -0000 @@ -859,6 +859,27 @@ here</a>.</p> when compiling for soft-float targets.</li> </ul> +<h3 id="msp430">MSP430</h3> + <ul> + <li><p>The MSP430 compiler now has the ability to automatically distribute code + and data between low (less than 64K) memory and high memory. This only + applies parts that actually have both memory regions and only if the + linker script for the part has been specifically set up to support this + feature.</p> + + <p>A new attribute of <code>either</code> can be applied to both functions + and data, and this tells the compiler to place the object into low memory + if there is room and into high memory otherwise. Two other new attributes + - <code>lower</code> and <code>upper</code> - can be used to explicitly + state that an object should be placed in the specified memory region. If + there is not enough left in that region the compilation will fail.</p> + + <p>Two new command line options - <code>-mcode-region=[lower|upper|either]</code> + and <code>-mdata-region=[lower|upper|either]</code> - can be used to tell + the compiler what to do with objects that do not have one of these new + attributes.</p></li> + </ul> + <h3 id="nds32">NDS32</h3> <ul> <li>The variadic function ABI implementation is now compatible with