From patchwork Fri Oct 30 13:27:25 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 538306 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id DCA8114031C for ; Sat, 31 Oct 2015 00:27:49 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=ONeRP/iK; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; q=dns; s=default; b=d4dwDYS0zNyVB8zu OQrqKYpVw+C/jWH+55tEM8HRx/qe8byU3R5PDfwD6N8dxoXx49LpW+MbWkXOh+6o zwy7OU9U+pBHHUu+damv5q/xO7fdVGSklMzFfEwYrNA8KDcnYMoqBcY3sXLZ9bNH Z4SSkcFmRsA7cJhp+B+l3crkp5o= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=default; bh=dL5ll+gqxTioziHEG+0q/n cbwxs=; b=ONeRP/iKmIw5YJ+jI0hjqvegqUtL+B/eMSkk3KC3J/wJjTZAciGyrv 43ayE8hK+n/+QeeD05/CCOpNHl+C2kBXTyKWdZhDzb4qwfpFzCPGGek92bmnOXS4 gjb0xc+C7vw41fc8synP+BRjE4e0VcM5CgRs/+Uu6qtBug9rmKOaQ= Received: (qmail 7506 invoked by alias); 30 Oct 2015 13:27:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 7474 invoked by uid 89); 30 Oct 2015 13:27:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 30 Oct 2015 13:27:37 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-03.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Zs9iP-0004Vx-F9 from Thomas_Schwinge@mentor.com ; Fri, 30 Oct 2015 06:27:33 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-03.mgc.mentorg.com (137.202.0.108) with Microsoft SMTP Server id 14.3.224.2; Fri, 30 Oct 2015 13:27:32 +0000 From: Thomas Schwinge To: James Norris , , CC: Tobias Burnus Subject: Re: [gomp4] declare directive [3/5] In-Reply-To: <5575AEEB.6020902@codesourcery.com> References: <5575ADCB.6030107@codesourcery.com> <5575AEEB.6020902@codesourcery.com> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/24.5.1 (i586-pc-linux-gnu) Date: Fri, 30 Oct 2015 14:27:25 +0100 Message-ID: <87ziz032rm.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Hi! On Mon, 8 Jun 2015 10:04:11 -0500, James Norris wrote: > --- a/gcc/fortran/gfortran.h > +++ b/gcc/fortran/gfortran.h > @@ -1174,6 +1183,7 @@ enum > OMP_LIST_FROM, > OMP_LIST_REDUCTION, > OMP_LIST_DEVICE_RESIDENT, > + OMP_LIST_LINK, > OMP_LIST_USE_DEVICE, > OMP_LIST_CACHE, > OMP_LIST_NUM I noticed (my means of hitting a segmentation fault) that this was missing an update to the clause_names in gcc/fortran/openmp.c:resolve_omp_clauses. (Yes, I agree that is a strange, non-obvious dependency that this function needs to be updated for OMP_LIST_* changes...) Fixed on gomp-4_0-branch in r229576: commit a5246d7b6c91e0800eeb6355bf5e4c63d27aafb2 Author: tschwinge Date: Fri Oct 30 13:24:35 2015 +0000 Fix OMP_LIST_LINK handling gcc/fortran/ * openmp.c (resolve_omp_clauses): Add "LINK" to clause_names. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@229576 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/fortran/ChangeLog.gomp | 4 ++++ gcc/fortran/openmp.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) Grüße Thomas diff --git gcc/fortran/ChangeLog.gomp gcc/fortran/ChangeLog.gomp index 7fe3eac..592dd8d 100644 --- gcc/fortran/ChangeLog.gomp +++ gcc/fortran/ChangeLog.gomp @@ -1,3 +1,7 @@ +2015-10-30 Thomas Schwinge + + * openmp.c (resolve_omp_clauses): Add "LINK" to clause_names. + 2015-10-29 Thomas Schwinge * openmp.c (gfc_match_omp_map_clause): Remove allow_sections diff --git gcc/fortran/openmp.c gcc/fortran/openmp.c index a2c5105..32779f7 100644 --- gcc/fortran/openmp.c +++ gcc/fortran/openmp.c @@ -3197,7 +3197,7 @@ resolve_omp_clauses (gfc_code *code, gfc_omp_clauses *omp_clauses, static const char *clause_names[] = { "PRIVATE", "FIRSTPRIVATE", "LASTPRIVATE", "COPYPRIVATE", "SHARED", "COPYIN", "UNIFORM", "ALIGNED", "LINEAR", "DEPEND", "MAP", - "TO", "FROM", "REDUCTION", "DEVICE_RESIDENT", "USE_DEVICE", + "TO", "FROM", "REDUCTION", "DEVICE_RESIDENT", "LINK", "USE_DEVICE", "CACHE" }; if (omp_clauses == NULL)