From patchwork Thu Jan 8 14:48:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 426665 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 857F81400F1 for ; Fri, 9 Jan 2015 01:48:43 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; q=dns; s=default; b=F+fViM8+aa9BuNh3 +bGGeXCcOTV4eCPENKqCYElSAxcKiCy1SN5huh8nfDmWbQh6JEjOB2c6p1FyEAZH /4qAHoPHrgqcQ7dTWxByAfNtSzLp7zf/HWYBvmmMwvl59fVUx4vm+sus+wzNBIJR 4arY0s1kHm9IiNWZrnG8N4ykaJc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=default; bh=6TZJrkJTsBCbI+I7kdQAsg VqV5I=; b=DWJTjyaoWFFLM/J7i6jp8hrtPjmbFllMPVZ4WgO6ygbifQgJZYVEdd GCuSwh2wUCF4DvUBi6HF7MqW8G00QyxTPVWVKJUUlYO7CZIJlQiHLlQ+w6wHhvrN FfsmPAdAMJZ8Jrz1qxQYVgTcGCahANKInyAMNX0ATw1j3DnKzCKWE= Received: (qmail 5235 invoked by alias); 8 Jan 2015 14:48:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 5218 invoked by uid 89); 8 Jan 2015 14:48:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS, UNWANTED_LANGUAGE_BODY autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Jan 2015 14:48:26 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-03.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Y9ENp-0002ZK-2Z from Thomas_Schwinge@mentor.com ; Thu, 08 Jan 2015 06:48:21 -0800 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-03.mgc.mentorg.com (137.202.0.108) with Microsoft SMTP Server id 14.3.224.2; Thu, 8 Jan 2015 14:48:19 +0000 From: Thomas Schwinge To: Ilya Verbin , Jakub Jelinek CC: , Kirill Yukhin , Andrey Turetskiy Subject: Re: [PATCH 3/4] Add libgomp plugin for Intel MIC In-Reply-To: <87k31x4321.fsf@kepler.schwinge.homeip.net> References: <20141021171323.GA47586@msticlxl57.ims.intel.com> <20141021172413.GD47586@msticlxl57.ims.intel.com> <20141022092205.GL10376@tucnak.redhat.com> <20141023154112.GA65020@msticlxl57.ims.intel.com> <20141024143521.GF10376@tucnak.redhat.com> <20141024150844.GA16821@msticlxl57.ims.intel.com> <20141024151858.GG10376@tucnak.redhat.com> <20141027121556.GB41265@msticlxl57.ims.intel.com> <20141106182536.GQ5026@tucnak.redhat.com> <20141110143006.GA50497@msticlxl57.ims.intel.com> <87k31x4321.fsf@kepler.schwinge.homeip.net> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Thu, 8 Jan 2015 15:48:09 +0100 Message-ID: <87y4pd2us6.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Hi! On Fri, 12 Dec 2014 10:42:30 +0100, I wrote: > On Mon, 10 Nov 2014 17:30:38 +0300, Ilya Verbin wrote: > > --- /dev/null > > +++ b/liboffloadmic/plugin/Makefile.am > > @@ -0,0 +1,123 @@ > > +# Plugin for offload execution on Intel MIC devices. > > + AM_LDFLAGS = -L$(liboffload_dir)/.libs -L$(libgomp_dir)/.libs -loffloadmic_target -lcoi_device -lmyo-service -lgomp -rdynamic > > Given that this plugin wishes to link against libgomp, don't we have to > make sure that libgomp has actually been built before that is attempted, > and the following (untested) patch would be required? As shown by a »make -j1« build: yes, we have to. As obvious, committed to trunk in r219344: commit fb5eef67f6b041cd0bc4f1f8d62c1a000d59f497 Author: tschwinge Date: Thu Jan 8 14:46:22 2015 +0000 liboffloadmic/plugin: Depend on libgomp being built. [...] Making all in plugin make[6]: Entering directory `[...]/build-gcc-offload-x86_64-intelmicemul-linux-gnu/x86_64-intelmicemul-linux-gnu/32/liboffloadmic/plugin' [...] [...]/build-gcc-offload-x86_64-intelmicemul-linux-gnu/./gcc/xg++ -B[...]/build-gcc-offload-x86_64-intelmicemul-linux-gnu/./gcc/ -nostdinc++ -nostdinc++ -I[...]/build-gcc-offload-x86_64-intelmicemul-linux-gnu/x86_64-intelmicemul-linux-gnu/32/libstdc++-v3/include/x86_64-intelmicemul-linux-gnu -I[...]/build-gcc-offload-x86_64-intelmicemul-linux-gnu/x86_64-intelmicemul-linux-gnu/32/libstdc++-v3/include -I[...]/source-gcc/libstdc++-v3/libsupc++ -I[...]/source-gcc/libstdc++-v3/include/backward -I[...]/source-gcc/libstdc++-v3/testsuite/util -L[...]/build-gcc-offload-x86_64-intelmicemul-linux-gnu/x86_64-intelmicemul-linux-gnu/32/libstdc++-v3/src -L[...]/build-gcc-offload-x86_64-intelmicemul-linux-gnu/x86_64-intelmicemul-linux-gnu/32/libstdc++-v3/src/.libs -L[...]/build-gcc-offload-x86_64-intelmicemul-linux-gnu/x86_64-intelmicemul-linux-gnu/32/libstdc++-v3/libsupc++/.libs -B/x86_64-intelmicemul-linux-gnu/bin/ -B/x86_64-intelmicemul-linux-gnu/lib/ -isystem /x86_64-intelmicemul-linux-gnu/include -isystem /x86_64-intelmicemul-linux-gnu/sys-include -m32 -L./../.libs -L./../../libgomp/.libs -loffloadmic_target -lcoi_device -lmyo-service -lgomp -rdynamic ../ofldbegin.o offload_target_main.o ../ofldend.o -o offload_target_main /usr/bin/ld: cannot find -lgomp collect2: error: ld returned 1 exit status * Makefile.def (dependencies) : Depend on all-target-libgomp. * Makefile.in: Regenerate. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@219344 138bc75d-0d04-0410-961f-82ee72b054a4 --- ChangeLog | 6 ++++++ Makefile.def | 2 +- Makefile.in | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) Grüße, Thomas diff --git ChangeLog ChangeLog index 325f4cc..9012087 100644 --- ChangeLog +++ ChangeLog @@ -1,3 +1,9 @@ +2015-01-08 Thomas Schwinge + + * Makefile.def (dependencies) : Depend on + all-target-libgomp. + * Makefile.in: Regenerate. + 2015-01-06 Eric Botcazou * MAINTAINERS (CPU Port Maintainers): Add myself for Visium port. diff --git Makefile.def Makefile.def index ffab409..15ab613 100644 --- Makefile.def +++ Makefile.def @@ -551,7 +551,7 @@ dependencies = { module=configure-target-libvtv; on=all-target-libstdc++-v3; }; // generated by the libgomp configure. Unfortunately, due to the use of // recursive make, we can't be that specific. dependencies = { module=all-target-libstdc++-v3; on=configure-target-libgomp; }; -dependencies = { module=all-target-liboffloadmic; on=configure-target-libgomp; }; +dependencies = { module=all-target-liboffloadmic; on=all-target-libgomp; }; dependencies = { module=install-target-libgo; on=install-target-libatomic; }; dependencies = { module=install-target-libgfortran; on=install-target-libquadmath; }; diff --git Makefile.in Makefile.in index 7355bf1..428898a 100644 --- Makefile.in +++ Makefile.in @@ -48893,7 +48893,7 @@ all-stage3-target-libstdc++-v3: maybe-configure-stage3-target-libgomp all-stage4-target-libstdc++-v3: maybe-configure-stage4-target-libgomp all-stageprofile-target-libstdc++-v3: maybe-configure-stageprofile-target-libgomp all-stagefeedback-target-libstdc++-v3: maybe-configure-stagefeedback-target-libgomp -all-target-liboffloadmic: maybe-configure-target-libgomp +all-target-liboffloadmic: maybe-all-target-libgomp install-target-libgo: maybe-install-target-libatomic install-target-libgfortran: maybe-install-target-libquadmath install-target-libgfortran: maybe-install-target-libgcc