From patchwork Tue Feb 17 18:25:55 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 440679 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5C7BA140192 for ; Wed, 18 Feb 2015 05:26:16 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; q=dns; s=default; b=Ewyv/+pi81W98l/Z uVvXFoQQl+VPgVZdKHjAISGf8V1GWje4m3qWUnd8+SzL1VNm2qgLtf2dYD9FeJ0M ejR08VgxL7nx12hbg+R7WbzSi0uZaMVWp9BriKrKsEwzC5sbgNaHUvoalGEYNjzM MCbHXXt/UXxkNDKVoOXi4jh4ioI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=default; bh=D+1d1C30tZUhle7OEGmoHQ +k6HQ=; b=ICeXAeTb1cyGV2/ZaKOnwdlNXqqpBozea92IXxATps+PVtR5i0Mguf vxVyaypLtOfF0hmMKnTWKdJ3hwQW1bCwlZJE1iDepvr5usLJ3P5t09CJYxt3GZiO ZHCxsb/bD/7bbMSOhoRzuKtELmNYkKUnIdzTyT23YCNUk7bw09qIE= Received: (qmail 24949 invoked by alias); 17 Feb 2015 18:26:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 24937 invoked by uid 89); 17 Feb 2015 18:26:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Feb 2015 18:26:06 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1YNmqQ-0007NP-GL from Thomas_Schwinge@mentor.com ; Tue, 17 Feb 2015 10:26:02 -0800 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Tue, 17 Feb 2015 18:26:00 +0000 From: Thomas Schwinge To: CC: Jakub Jelinek , Julian Brown Subject: Re: [gomp4] libgomp updates In-Reply-To: <87y4q5sw35.fsf@schwinge.name> References: <87oar1ud7y.fsf@schwinge.name> <87y4q5sw35.fsf@schwinge.name> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Tue, 17 Feb 2015 19:25:55 +0100 Message-ID: <87twykfl8s.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Hi! On Thu, 18 Dec 2014 00:19:42 +0100, I wrote: > On Wed, 17 Dec 2014 23:24:17 +0100, I wrote: > > Committed to gomp-4_0-branch in r218839: > > > > commit 1c4f05a68c6d0d5b6137bb6d85a293d16727b389 > > Author: tschwinge > > Date: Wed Dec 17 22:23:02 2014 +0000 > > > > libgomp updates. > > libgomp/ > > * libgomp-plugin.h: Rename GOMP_PLUGIN_notify to > > GOMP_PLUGIN_debug. Change all users. > > --- libgomp/libgomp-plugin.c > > +++ libgomp/libgomp-plugin.c > > void > > +GOMP_PLUGIN_debug (int kind, const char *msg, ...) > > +{ > > + va_list ap; > > + > > + va_start (ap, msg); > > + gomp_debug (kind, msg, ap); > > + va_end (ap); > > +} > > + > > +void > > GOMP_PLUGIN_error (const char *msg, ...) > > { > > va_list ap; > > @@ -59,16 +71,6 @@ GOMP_PLUGIN_error (const char *msg, ...) > > } > > > > void > > -GOMP_PLUGIN_notify (const char *msg, ...) > > -{ > > - va_list ap; > > - > > - va_start (ap, msg); > > - gomp_vnotify (msg, ap); > > - va_end (ap); > > -} Here, I introduced a bug, and please, nobody (!) ask me how long it took to track down that one... :'-( I hit this while debugging something: I found that GOMP_PLUGIN_debug only worked "a little bit" (some arguments did not get printed) -- I suspected (..., and tried to track down...) strack corruption and what not, but not such a stupid typo in combination with C's poor type system... Committed to trunk in r220770: commit 84551a30dc6b717eb8684578b0463e951270a5e8 Author: tschwinge Date: Tue Feb 17 18:24:07 2015 +0000 libgomp: Make GOMP_PLUGIN_debug actually work... libgomp/ * libgomp-plugin.c (GOMP_PLUGIN_debug): Fix typo. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@220770 138bc75d-0d04-0410-961f-82ee72b054a4 --- libgomp/ChangeLog | 4 ++++ libgomp/libgomp-plugin.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) Grüße, Thomas diff --git libgomp/ChangeLog libgomp/ChangeLog index 2c32d9e..8477c3b 100644 --- libgomp/ChangeLog +++ libgomp/ChangeLog @@ -1,4 +1,8 @@ 2015-02-17 Thomas Schwinge + + * libgomp-plugin.c (GOMP_PLUGIN_debug): Fix typo. + +2015-02-17 Thomas Schwinge Cesar Philippidis * oacc-ptx.h (GOACC_INTERNAL_PTX): Add GOACC_tid, GOACC_ntid, diff --git libgomp/libgomp-plugin.c libgomp/libgomp-plugin.c index ffb22e9..f448ba9 100644 --- libgomp/libgomp-plugin.c +++ libgomp/libgomp-plugin.c @@ -55,7 +55,7 @@ GOMP_PLUGIN_debug (int kind, const char *msg, ...) va_list ap; va_start (ap, msg); - gomp_debug (kind, msg, ap); + gomp_vdebug (kind, msg, ap); va_end (ap); }