From patchwork Tue Oct 27 10:33:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 536541 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B936B1401F6 for ; Tue, 27 Oct 2015 21:34:25 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=NNc4/sX8; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; q=dns; s=default; b=bx9Ob3oCtFEhrOCe 59+NeoFIp6VqPK7nNEQ9vnJETMiTfWM+s72CAoqtzGSvbyQtxBxVhoS88Uux+BZi TE7JAmxA5dfyTtIy6QNjS8juAlYTymv4MJ2QpLBO+qDjg4Q8QaZ6ZcvqvPxELzXD Dd2MJYrA8Y7O0i7lsXwpb6RHTT0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=default; bh=wdbQFbmqJgV0Q729JuYmzu BxQUw=; b=NNc4/sX8copZ4EAP3lwle5mey0hCp9zL3OrldJx9klpKEbwobQc+7N tIBVh6Oj+0TH50Ht8GIDRe6uxCM2HZ/RLAew7IdIfAY0FdAKuF1JX9WCI1jdihrh tEeQw93mmL6IOxEyuYMTqmZGb4QlwMn1lC+5adtttu7aprCY6ngNM= Received: (qmail 25794 invoked by alias); 27 Oct 2015 10:34:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 25775 invoked by uid 89); 27 Oct 2015 10:34:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 27 Oct 2015 10:34:16 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41447) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1Zr1a2-0003d9-Li for gcc-patches@gnu.org; Tue, 27 Oct 2015 06:34:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zr1Zw-0006Ce-Ex for gcc-patches@gnu.org; Tue, 27 Oct 2015 06:34:14 -0400 Received: from relay1.mentorg.com ([192.94.38.131]:38586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zr1Zw-0006Ca-9t for gcc-patches@gnu.org; Tue, 27 Oct 2015 06:34:08 -0400 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Zr1Zu-0002am-Cl from Thomas_Schwinge@mentor.com ; Tue, 27 Oct 2015 03:34:06 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Tue, 27 Oct 2015 10:34:05 +0000 From: Thomas Schwinge To: Jakub Jelinek CC: "gcc-patches@gnu.org" , Tom de Vries Subject: Re: [testsuite, committed, PR68063] Add missing private clause in libgomp.c++/member-2.C In-Reply-To: <20151027100815.GE478@tucnak.redhat.com> References: <562A1099.4030108@mentor.com> <878u6o7jvk.fsf@kepler.schwinge.homeip.net> <20151027100815.GE478@tucnak.redhat.com> User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/24.5.1 (i586-pc-linux-gnu) Date: Tue, 27 Oct 2015 11:33:53 +0100 Message-ID: <87twpc61ny.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 Hi! On Tue, 27 Oct 2015 11:08:15 +0100, Jakub Jelinek wrote: > On Tue, Oct 27, 2015 at 10:15:11AM +0100, Thomas Schwinge wrote: > > ... looks a bit as if it might need to get the same patch applied that > > Tom has applied to libgomp.c++/member-2.C: > > You're right, member-2.C is a templatized version of member-1.C, > a change to add private (R::r) to that corresponding member-1.C taskloop > directive is preapproved. Tested, and committed in r229411: commit 540c8b2a12162472a4f644b7b533041a813a0332 Author: tschwinge Date: Tue Oct 27 10:32:32 2015 +0000 [PR testsuite/68063] Add missing private clause in libgomp.c++/member-1.C PR testsuite/68063 * testsuite/libgomp.c++/member-1.C (A::m1): Add missing private clause. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@229411 138bc75d-0d04-0410-961f-82ee72b054a4 --- libgomp/ChangeLog | 5 +++++ libgomp/testsuite/libgomp.c++/member-1.C | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) Grüße Thomas diff --git libgomp/ChangeLog libgomp/ChangeLog index ca34af8..0194503 100644 --- libgomp/ChangeLog +++ libgomp/ChangeLog @@ -1,3 +1,8 @@ +2015-10-27 Thomas Schwinge + + PR testsuite/68063 + * testsuite/libgomp.c++/member-1.C (A::m1): Add missing private clause. + 2015-10-27 James Norris * testsuite/libgomp.oacc-c-c++-common/combdir-1.c: New file. diff --git libgomp/testsuite/libgomp.c++/member-1.C libgomp/testsuite/libgomp.c++/member-1.C index d2d0c5b..c7c1ba4 100644 --- libgomp/testsuite/libgomp.c++/member-1.C +++ libgomp/testsuite/libgomp.c++/member-1.C @@ -151,7 +151,7 @@ A::m1 () { f = false; #pragma omp single - #pragma omp taskloop lastprivate (a, t, b, n) + #pragma omp taskloop lastprivate (a, t, b, n) private (R::r) for (int i = 0; i < 30; i++) { int q = omp_get_thread_num ();