From df7625c3af004a81c13d54bb8810e03932eeb59a Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <tschwinge@baylibre.com>
Date: Sat, 24 Feb 2024 00:29:14 +0100
Subject: [PATCH] GCN:
'--param=gcn-preferred-vectorization-factor=[default,32,64]'
..., and specify '--param=gcn-preferred-vectorization-factor=64' for
'gcc.target/gcn/[...]' test cases with 'scan-assembler' directives that
are specific to 64-lane vectors. This resolves regressions introduced
in commit 6dedafe166cc02ae87b6a0699ad61ce3ffc46803
"amdgcn: Prefer V32 on RDNA devices".
gcc/
* config/gcn/gcn.opt (--param=gcn-preferred-vectorization-factor):
New.
* config/gcn/gcn.cc (gcn_vectorize_preferred_simd_mode) Use it.
* doc/invoke.texi (Optimize Options): Document it.
gcc/testsuite/
* gcc.target/gcn/cond_fmaxnm_1.c: Specify
'--param=gcn-preferred-vectorization-factor=64'.
* gcc.target/gcn/cond_fmaxnm_2.c: Likewise.
* gcc.target/gcn/cond_fmaxnm_3.c: Likewise.
* gcc.target/gcn/cond_fmaxnm_4.c: Likewise.
* gcc.target/gcn/cond_fmaxnm_5.c: Likewise.
* gcc.target/gcn/cond_fmaxnm_6.c: Likewise.
* gcc.target/gcn/cond_fmaxnm_7.c: Likewise.
* gcc.target/gcn/cond_fmaxnm_8.c: Likewise.
* gcc.target/gcn/cond_fminnm_1.c: Likewise.
* gcc.target/gcn/cond_fminnm_2.c: Likewise.
* gcc.target/gcn/cond_fminnm_3.c: Likewise.
* gcc.target/gcn/cond_fminnm_4.c: Likewise.
* gcc.target/gcn/cond_fminnm_5.c: Likewise.
* gcc.target/gcn/cond_fminnm_6.c: Likewise.
* gcc.target/gcn/cond_fminnm_7.c: Likewise.
* gcc.target/gcn/cond_fminnm_8.c: Likewise.
* gcc.target/gcn/cond_shift_3.c: Likewise.
* gcc.target/gcn/cond_shift_4.c: Likewise.
* gcc.target/gcn/cond_shift_8.c: Likewise.
* gcc.target/gcn/cond_shift_9.c: Likewise.
* gcc.target/gcn/cond_smax_1.c: Likewise.
* gcc.target/gcn/cond_smin_1.c: Likewise.
* gcc.target/gcn/cond_umax_1.c: Likewise.
* gcc.target/gcn/cond_umin_1.c: Likewise.
* gcc.target/gcn/simd-math-1.c: Likewise.
* gcc.target/gcn/simd-math-5-char.c: Likewise.
* gcc.target/gcn/simd-math-5-long.c: Likewise.
* gcc.target/gcn/simd-math-5-short.c: Likewise.
* gcc.target/gcn/simd-math-5.c: Likewise.
* gcc.target/gcn/smax_1.c: Likewise.
* gcc.target/gcn/smin_1.c: Likewise.
* gcc.target/gcn/umax_1.c: Likewise.
* gcc.target/gcn/umin_1.c: Likewise.
---
gcc/config/gcn/gcn.cc | 14 +++++++++++++-
gcc/config/gcn/gcn.opt | 16 ++++++++++++++++
gcc/doc/invoke.texi | 8 ++++++++
gcc/testsuite/gcc.target/gcn/cond_fmaxnm_1.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_fmaxnm_2.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_fmaxnm_3.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_fmaxnm_4.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_fmaxnm_5.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_fmaxnm_6.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_fmaxnm_7.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_fmaxnm_8.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_fminnm_1.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_fminnm_2.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_fminnm_3.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_fminnm_4.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_fminnm_5.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_fminnm_6.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_fminnm_7.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_fminnm_8.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_shift_3.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_shift_4.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_shift_8.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_shift_9.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_smax_1.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_smin_1.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_umax_1.c | 2 ++
gcc/testsuite/gcc.target/gcn/cond_umin_1.c | 2 ++
gcc/testsuite/gcc.target/gcn/simd-math-1.c | 3 ++-
gcc/testsuite/gcc.target/gcn/simd-math-5-char.c | 3 +++
gcc/testsuite/gcc.target/gcn/simd-math-5-long.c | 3 +++
gcc/testsuite/gcc.target/gcn/simd-math-5-short.c | 3 +++
gcc/testsuite/gcc.target/gcn/simd-math-5.c | 3 +++
gcc/testsuite/gcc.target/gcn/smax_1.c | 2 ++
gcc/testsuite/gcc.target/gcn/smin_1.c | 2 ++
gcc/testsuite/gcc.target/gcn/umax_1.c | 2 ++
gcc/testsuite/gcc.target/gcn/umin_1.c | 2 ++
36 files changed, 107 insertions(+), 2 deletions(-)
@@ -5231,6 +5231,14 @@ gcn_vector_mode_supported_p (machine_mode mode)
static machine_mode
gcn_vectorize_preferred_simd_mode (scalar_mode mode)
{
+ bool v32;
+ if (gcn_preferred_vectorization_factor == 32)
+ v32 = true;
+ else if (gcn_preferred_vectorization_factor == 64)
+ v32 = false;
+ else if (gcn_preferred_vectorization_factor != -1)
+ gcc_unreachable ();
+ else if (TARGET_RDNA2_PLUS)
/* RDNA devices have 32-lane vectors with limited support for 64-bit vectors
(in particular, permute operations are only available for cases that don't
span the 32-lane boundary).
@@ -5238,7 +5246,11 @@ gcn_vectorize_preferred_simd_mode (scalar_mode mode)
From the RDNA3 manual: "Hardware may choose to skip either half if the
EXEC mask for that half is all zeros...". This means that preferring
32-lanes is a good stop-gap until we have proper wave32 support. */
- if (TARGET_RDNA2_PLUS)
+ v32 = true;
+ else
+ v32 = false;
+
+ if (v32)
switch (mode)
{
case E_QImode:
@@ -116,3 +116,19 @@ Compile for devices requiring XNACK enabled. Default \"any\" if USM is supported
msram-ecc=
Target RejectNegative Joined ToLower Enum(hsaco_attr_type) Var(flag_sram_ecc) Init(HSACO_ATTR_ANY)
Compile for devices with the SRAM ECC feature enabled, or not. Default \"any\".
+
+-param=gcn-preferred-vectorization-factor=
+Target Joined Enum(gcn_preferred_vectorization_factor) Var(gcn_preferred_vectorization_factor) Init(-1) Param
+--param=gcn-preferred-vectorization-factor=[default,32,64] Preferred vectorization factor.
+
+Enum
+Name(gcn_preferred_vectorization_factor) Type(int)
+
+EnumValue
+Enum(gcn_preferred_vectorization_factor) String(default) Value(-1)
+
+EnumValue
+Enum(gcn_preferred_vectorization_factor) String(32) Value(32)
+
+EnumValue
+Enum(gcn_preferred_vectorization_factor) String(64) Value(64)
@@ -17017,6 +17017,14 @@ loop. The default value is four.
@end table
+The following choices of @var{name} are available on GCN targets:
+
+@table @gcctabopt
+@item gcn-preferred-vectorization-factor
+Preferred vectorization factor: @samp{default}, @samp{32}, @samp{64}.
+
+@end table
+
The following choices of @var{name} are available on i386 and x86_64 targets:
@table @gcctabopt
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -ffast-math -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include <stdint.h>
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -ffast-math -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include <stdint.h>
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -ffast-math -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include <stdint.h>
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -ffast-math -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include <stdint.h>
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include "cond_fmaxnm_1.c"
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include "cond_fmaxnm_2.c"
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include "cond_fmaxnm_3.c"
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include "cond_fmaxnm_4.c"
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -ffast-math -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#define FN(X) __builtin_fmin##X
#include "cond_fmaxnm_1.c"
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -ffast-math -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#define FN(X) __builtin_fmin##X
#include "cond_fmaxnm_2.c"
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -ffast-math -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#define FN(X) __builtin_fmin##X
#include "cond_fmaxnm_3.c"
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -ffast-math -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#define FN(X) __builtin_fmin##X
#include "cond_fmaxnm_4.c"
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#define FN(X) __builtin_fmin##X
#include "cond_fmaxnm_1.c"
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#define FN(X) __builtin_fmin##X
#include "cond_fmaxnm_2.c"
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#define FN(X) __builtin_fmin##X
#include "cond_fmaxnm_3.c"
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#define FN(X) __builtin_fmin##X
#include "cond_fmaxnm_4.c"
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include <stdint.h>
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include <stdint.h>
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include <stdint.h>
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include <stdint.h>
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include <stdint.h>
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include <stdint.h>
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include <stdint.h>
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include <stdint.h>
@@ -2,7 +2,8 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -fno-math-errno -mstack-size=3000000 -fdump-tree-vect" } */
-
+/* The 'scan-tree-dump' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#undef PRINT_RESULT
#define VERBOSE 0
@@ -1,3 +1,6 @@
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
+
#define TYPE char
#include "simd-math-5.c"
@@ -1,3 +1,6 @@
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
+
#define TYPE long
#include "simd-math-5.c"
@@ -1,3 +1,6 @@
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
+
#define TYPE short
#include "simd-math-5.c"
@@ -1,6 +1,9 @@
/* Test that the auto-vectorizer uses the libgcc vectorized division and
modulus functions. */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
+
/* Setting it this way ensures the run tests use the same flag as the
compile tests. */
#pragma GCC optimize("O2")
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include <stdint.h>
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include <stdint.h>
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include <stdint.h>
@@ -1,5 +1,7 @@
/* { dg-do compile } */
/* { dg-options "-O2 -ftree-vectorize -dp" } */
+/* The 'scan-assembler' directives are specific to 64-lane vectors.
+ { dg-additional-options --param=gcn-preferred-vectorization-factor=64 } */
#include <stdint.h>
--
2.34.1