From patchwork Sat Jul 11 19:25:09 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 494032 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 65BD21402CC for ; Sun, 12 Jul 2015 05:25:44 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=NUvTlnhD; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:in-reply-to:references:date:message-id:mime-version :content-type; q=dns; s=default; b=LE2aDc97apLYK0+ZQ+HxRxzB8qYiI GaNe6IrLEU5WhyxTg+Y3NYS/YbuGehDpyjL6hqmSHMkZ+yW7KQtJF49ccTex7OEQ uYajNeIEZZs7oB2t3Zl97XLLbQvoNXztxi63/cJatRqsJWTmUTYNwvPj/6LT3ips zEeNy911sl8qb0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:in-reply-to:references:date:message-id:mime-version :content-type; s=default; bh=7Ss4IV6xmo/YQ/nmjI/akJE6j8I=; b=NUv TlnhD+brWIOclHdHLlNlsHdsCa1C+3vaQw3Y8ByqbAnlU80DBwjenkDuY4g48PPi YpwQIRiJRYCoGsasVvYaawhmUnKTvpExFTiZfMwH1j8c7bbaqZ2xURE6BE8K19mF rE0PbiyPtKF0O+AQSceJvoVtNLjGXS4SOP9u07eE= Received: (qmail 121611 invoked by alias); 11 Jul 2015 19:25:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 121598 invoked by uid 89); 11 Jul 2015 19:25:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 11 Jul 2015 19:25:35 +0000 Received: from svr-orw-fem-03.mgc.mentorg.com ([147.34.97.39]) by relay1.mentorg.com with esmtp id 1ZE0Oy-0004xt-2V from Thomas_Schwinge@mentor.com for gcc-patches@gcc.gnu.org; Sat, 11 Jul 2015 12:25:32 -0700 Received: from tftp-cs (147.34.91.1) by svr-orw-fem-03.mgc.mentorg.com (147.34.97.39) with Microsoft SMTP Server id 14.3.224.2; Sat, 11 Jul 2015 12:25:31 -0700 Received: by tftp-cs (Postfix, from userid 49978) id E76EBC22DF; Sat, 11 Jul 2015 12:25:31 -0700 (PDT) From: Thomas Schwinge To: Nathan Sidwell , GCC Patches Subject: [gomp4] Revert "Work around nvptx offloading compiler --enable-checking=yes, df, fold, rtl breakage" (was: fix df verify failure) In-Reply-To: <55A04174.8060401@acm.org> References: <55A04174.8060401@acm.org> <87a8v42xkh.fsf@kepler.schwinge.homeip.net> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sat, 11 Jul 2015 21:25:09 +0200 Message-ID: <87si8u4huy.fsf@schwinge.name> MIME-Version: 1.0 Hi! On Fri, 10 Jul 2015 18:04:36 -0400, Nathan Sidwell wrote: > I've committed this patch to fix a df verify crash Thomas pointed me at. Thanks! > Thomas, I think this means you can revert the workaround you just committed? Right. Committed in r225714: commit 687f194e535317024ca67c32b26bb277b6f266ae Author: tschwinge Date: Sat Jul 11 19:21:48 2015 +0000 Revert "Work around nvptx offloading compiler --enable-checking=yes,df,fold,rtl breakage" This reverts r225656; problem get addressed in r225695. gcc/ * df-core.c (df_analyze_1): Don't disable df_verify call. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@225714 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog.gomp | 4 ++++ gcc/df-core.c | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-) Grüße, Thomas diff --git gcc/ChangeLog.gomp gcc/ChangeLog.gomp index baff20c..1f57a9d 100644 --- gcc/ChangeLog.gomp +++ gcc/ChangeLog.gomp @@ -1,3 +1,7 @@ +2015-07-11 Thomas Schwinge + + * df-core.c (df_analyze_1): Don't disable df_verify call. + 2015-07-10 Nathan Sidwell * config/nvptx/nvptx.c (nvptx_reorg): Move df problem setting, set diff --git gcc/df-core.c gcc/df-core.c index 52cca8e..67040a1 100644 --- gcc/df-core.c +++ gcc/df-core.c @@ -1235,12 +1235,10 @@ df_analyze_1 (void) if (dump_file) fprintf (dump_file, "df_analyze called\n"); -#if /* TODO */ 0 #ifndef ENABLE_DF_CHECKING if (df->changeable_flags & DF_VERIFY_SCHEDULED) #endif df_verify (); -#endif /* Skip over the DF_SCAN problem. */ for (i = 1; i < df->num_problems_defined; i++)