From patchwork Tue Jul 7 12:47:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 492198 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 12828140285 for ; Tue, 7 Jul 2015 22:48:23 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=beh3ZAUj; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:in-reply-to:references:date:message-id:mime-version :content-type; q=dns; s=default; b=bN4G+RDQKVFHBg1KTkQnCJLQLqPMf jyXEJjdWYd+H916i5nUG0BBYUgwRcL14A3uLbxemH1QUmep8dVTzI7lWihpyNz6C vr72ZiW5qM/NG8jEr27CkTiKBENwRw55XlXQNTNdQ2sBQyULoFIj6dCMyzCKAxfS 1FBMcZ+pTkoFBs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:in-reply-to:references:date:message-id:mime-version :content-type; s=default; bh=nedf/a5QzkOODghmtfmNooc/eFs=; b=beh 3ZAUj09qtmsqZQfyXw/Q9HVn51asrq5552ldXSvDYt/FxFIh+Y9gDiVGwBQe2vMZ WEYZbzSoauZWJwH6kXe87+aL7q55eb3B+iT2a+ZmrJ+uHuIKjvhgORT/Ei5BlRTr h7P9PUCjzQsp7gikwrbdZq+0nv9AkTjEoMygh5sA= Received: (qmail 28088 invoked by alias); 7 Jul 2015 12:48:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 28074 invoked by uid 89); 7 Jul 2015 12:48:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 07 Jul 2015 12:48:09 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZCSI7-0004GO-UX from Thomas_Schwinge@mentor.com for gcc-patches@gcc.gnu.org; Tue, 07 Jul 2015 05:48:04 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Tue, 7 Jul 2015 13:48:02 +0100 From: Thomas Schwinge To: Chung-Lin Tang , gcc-patches Subject: [gomp4] libgomp: XFAIL libgomp.oacc-c-c++-common/reduction-4.c for acc_device_nvidia (was: implicit firstprivate and other testcase fixes) In-Reply-To: <5593F6D5.6020207@codesourcery.com> References: <5593F6D5.6020207@codesourcery.com> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Tue, 7 Jul 2015 14:47:57 +0200 Message-ID: <87mvz85e2q.fsf@schwinge.name> MIME-Version: 1.0 Hi! On Wed, 1 Jul 2015 22:19:01 +0800, Chung-Lin Tang wrote: > This patch "notices" the index variable of an acc loop (internally an OMP_FOR) > inside an OpenACC construct, and completes the implicit firstprivate > behavior as described in the spec. The firstprivate clauses and FIXME in > libgomp.oacc-c-c++-common/parallel-loop-2.h has also been removed together > in the patch. Thanks! > Also a typo-bug in testcase libgomp.oacc-c-c++-common/reduction-4.c is also corrected, > where reduction variable names are apparently wrong. > > Tested without regressions, and applied to gomp-4_0-branch. I'm seeing: WARNING: program timed out. FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/reduction-4.c -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test ... with: libgomp: cuStreamSynchronize error: launch timeout .... (also for C++), and applied in r225513: commit f03018ac39ed0193102fe29139d3c995caa02fd5 Author: tschwinge Date: Tue Jul 7 12:45:12 2015 +0000 libgomp: XFAIL libgomp.oacc-c-c++-common/reduction-4.c for acc_device_nvidia ... after r225250 changes. libgomp/ * testsuite/libgomp.oacc-c-c++-common/reduction-4.c: dg-xfail-run-if openacc_nvidia_accel_selected. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@225513 138bc75d-0d04-0410-961f-82ee72b054a4 --- libgomp/ChangeLog.gomp | 5 +++++ libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-4.c | 1 + 2 files changed, 6 insertions(+) Grüße, Thomas diff --git libgomp/ChangeLog.gomp libgomp/ChangeLog.gomp index dc0f0bf..5f3dfaf 100644 --- libgomp/ChangeLog.gomp +++ libgomp/ChangeLog.gomp @@ -1,3 +1,8 @@ +2015-07-07 Thomas Schwinge + + * testsuite/libgomp.oacc-c-c++-common/reduction-4.c: + dg-xfail-run-if openacc_nvidia_accel_selected. + 2015-06-24 James Norris * testsuite/libgomp.oacc-fortran/if-1.c: Fix syntax. diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-4.c libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-4.c index 416d960..c32f1db 100644 --- libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-4.c +++ libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-4.c @@ -1,4 +1,5 @@ /* { dg-do run { target { ! { hppa*-*-hpux* } } } } */ +/* { dg-xfail-run-if "libgomp: cuStreamSynchronize error: launch timeout" { openacc_nvidia_accel_selected } } */ /* complex reductions. */