diff mbox

[gomp4] libgomp: XFAIL libgomp.oacc-c-c++-common/reduction-4.c for acc_device_nvidia (was: implicit firstprivate and other testcase fixes)

Message ID 87mvz85e2q.fsf@schwinge.name
State New
Headers show

Commit Message

Thomas Schwinge July 7, 2015, 12:47 p.m. UTC 
Hi!

On Wed, 1 Jul 2015 22:19:01 +0800, Chung-Lin Tang <cltang@codesourcery.com> wrote:
> This patch "notices" the index variable of an acc loop (internally an OMP_FOR)
> inside an OpenACC construct, and completes the implicit firstprivate
> behavior as described in the spec. The firstprivate clauses and FIXME in
> libgomp.oacc-c-c++-common/parallel-loop-2.h has also been removed together
> in the patch.

Thanks!

> Also a typo-bug in testcase libgomp.oacc-c-c++-common/reduction-4.c is also corrected,
> where reduction variable names are apparently wrong.
> 
> Tested without regressions, and applied to gomp-4_0-branch.

I'm seeing:

    WARNING: program timed out.
    FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/reduction-4.c -DACC_DEVICE_TYPE_nvidia=1 -DACC_MEM_SHARED=0 execution test

... with:

    libgomp: cuStreamSynchronize error: launch timeout

.... (also for C++), and applied in r225513:

commit f03018ac39ed0193102fe29139d3c995caa02fd5
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Tue Jul 7 12:45:12 2015 +0000

    libgomp: XFAIL libgomp.oacc-c-c++-common/reduction-4.c for acc_device_nvidia
    
    ... after r225250 changes.
    
    	libgomp/
    	* testsuite/libgomp.oacc-c-c++-common/reduction-4.c:
    	dg-xfail-run-if openacc_nvidia_accel_selected.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@225513 138bc75d-0d04-0410-961f-82ee72b054a4
---
 libgomp/ChangeLog.gomp                                    | 5 +++++
 libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-4.c | 1 +
 2 files changed, 6 insertions(+)



Grüße,
 Thomas
diff mbox

Patch

diff --git libgomp/ChangeLog.gomp libgomp/ChangeLog.gomp
index dc0f0bf..5f3dfaf 100644
--- libgomp/ChangeLog.gomp
+++ libgomp/ChangeLog.gomp
@@ -1,3 +1,8 @@ 
+2015-07-07  Thomas Schwinge  <thomas@codesourcery.com>
+
+	* testsuite/libgomp.oacc-c-c++-common/reduction-4.c:
+	dg-xfail-run-if openacc_nvidia_accel_selected.
+
 2015-06-24  James Norris  <jnorris@codesourcery.com>
 
 	* testsuite/libgomp.oacc-fortran/if-1.c: Fix syntax.
diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-4.c libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-4.c
index 416d960..c32f1db 100644
--- libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-4.c
+++ libgomp/testsuite/libgomp.oacc-c-c++-common/reduction-4.c
@@ -1,4 +1,5 @@ 
 /* { dg-do run { target { ! { hppa*-*-hpux* } } } } */
+/* { dg-xfail-run-if "libgomp: cuStreamSynchronize error: launch timeout" { openacc_nvidia_accel_selected } } */
 
 /* complex reductions.  */