diff mbox series

GCN: Restore lost '__gfx90a__' target CPU definition (was: [Patch] GCN: Add pre-initial support for gfx1100)

Message ID 87msrwjsft.fsf@euler.schwinge.ddns.net
State New
Headers show
Series GCN: Restore lost '__gfx90a__' target CPU definition (was: [Patch] GCN: Add pre-initial support for gfx1100) | expand

Commit Message

Thomas Schwinge Feb. 19, 2024, 5:05 p.m. UTC 
Hi!

On 2024-01-07T20:20:19+0100, Tobias Burnus <burnus@net-b.de> wrote:
> --- a/gcc/config/gcn/gcn.h
> +++ b/gcc/config/gcn/gcn.h
> @@ -30,6 +30,8 @@
>  	builtin_define ("__CDNA2__");                                          \
>        else if (TARGET_RDNA2)                                                   \
>  	builtin_define ("__RDNA2__");                                          \
> +      else if (TARGET_RDNA3)                                                   \
> +	builtin_define ("__RDNA3__");                                          \
>        if (TARGET_FIJI)                                                         \
>  	{                                                                      \
>  	  builtin_define ("__fiji__");                                         \
> @@ -41,11 +43,13 @@
>  	builtin_define ("__gfx906__");                                         \
>        else if (TARGET_GFX908)                                                  \
>  	builtin_define ("__gfx908__");                                         \
> -      else if (TARGET_GFX90a)                                                  \
> -	builtin_define ("__gfx90a__");                                         \
> +      else if (TARGET_GFX1030)                                                 \
> +	builtin_define ("__gfx1030");                                          \
> +      else if (TARGET_GFX1100)                                                 \
> +	builtin_define ("__gfx1100__");                                        \
>    } while (0)

Supposedly it wasn't intentional that we lost gfx90a here -- I've pushed
to master branch commit 159174f25716c18a74a915cb01b9a28024ea7a3d
"GCN: Restore lost '__gfx90a__' target CPU definition", see attached.


Grüße
 Thomas
diff mbox series

Patch

From 159174f25716c18a74a915cb01b9a28024ea7a3d Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <tschwinge@baylibre.com>
Date: Thu, 8 Feb 2024 23:27:19 +0100
Subject: [PATCH] GCN: Restore lost '__gfx90a__' target CPU definition

Also, add some safeguards for the future.

Fix-up for commit 52a2c659ae6c21f84b6acce0afcb9b93b9dc71a0
"GCN: Add pre-initial support for gfx1100".

	gcc/
	* config/gcn/gcn.h (TARGET_CPU_CPP_BUILTINS): Restore lost
	'__gfx90a__' target CPU definition.  Add some safeguards for the future.
---
 gcc/config/gcn/gcn.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gcc/config/gcn/gcn.h b/gcc/config/gcn/gcn.h
index a17f16aacc40..c314c7b4ae8e 100644
--- a/gcc/config/gcn/gcn.h
+++ b/gcc/config/gcn/gcn.h
@@ -32,6 +32,8 @@ 
 	builtin_define ("__RDNA2__");                                          \
       else if (TARGET_RDNA3)                                                   \
 	builtin_define ("__RDNA3__");                                          \
+      else                                                                     \
+	gcc_unreachable ();                                                    \
       if (TARGET_FIJI)                                                         \
 	{                                                                      \
 	  builtin_define ("__fiji__");                                         \
@@ -43,10 +45,14 @@ 
 	builtin_define ("__gfx906__");                                         \
       else if (TARGET_GFX908)                                                  \
 	builtin_define ("__gfx908__");                                         \
+      else if (TARGET_GFX90a)                                                  \
+	builtin_define ("__gfx90a__");                                         \
       else if (TARGET_GFX1030)                                                 \
 	builtin_define ("__gfx1030");                                          \
       else if (TARGET_GFX1100)                                                 \
 	builtin_define ("__gfx1100__");                                        \
+      else                                                                     \
+	gcc_unreachable ();                                                    \
   } while (0)
 
 #define ASSEMBLER_DIALECT (TARGET_RDNA2_PLUS ? 1 : 0)
-- 
2.43.0