Message ID | 87fvacld85.fsf@kepler.schwinge.homeip.net |
---|---|
State | New |
Headers | show |
On 02/11/2015 03:44 PM, Thomas Schwinge wrote: > Note the global cold/hot labels. This confuses mkoffload, and it runs > into a busy loop due to what I understand to be a bug in skipping of > "strange" tokens, cited above, which such global labels would fall under. > Here is what might be a fix for this (but I didn't analyze the parsing > code in detail); OK for trunk? I'd rather fail if anything unexpected is seen. Things like -freorder-blocks-and-partition should be forced off in nvptx_option_override. Bernd
Hi! On Wed, 11 Feb 2015 16:20:51 +0100, Bernd Schmidt <bernds@codesourcery.com> wrote: > On 02/11/2015 03:44 PM, Thomas Schwinge wrote: > > Note the global cold/hot labels. This confuses mkoffload, and it runs > > into a busy loop due to what I understand to be a bug in skipping of > > "strange" tokens, cited above, which such global labels would fall under. > > Here is what might be a fix for this (but I didn't analyze the parsing > > code in detail); OK for trunk? Committed to trunk in r220769. > I'd rather fail if anything unexpected is seen. Things like > -freorder-blocks-and-partition should be forced off in > nvptx_option_override. Yes; that's basically what I suggested in my other email, <http://news.gmane.org/find-root.php?message_id=%3C87a90klcyb.fsf%40kepler.schwinge.homeip.net%3E>. Grüße, Thomas
--- gcc/config/nvptx/mkoffload.c +++ gcc/config/nvptx/mkoffload.c @@ -755,8 +755,9 @@ parse_file (Token *tok) if (comment) append_stmt (&fns, comment); - while (tok->kind && !tok->end) + do tok++; + while (tok->kind && !tok->end); } return tok; }