From patchwork Wed Mar 25 08:30:00 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 454278 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 2F9D31400B7 for ; Wed, 25 Mar 2015 19:30:26 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass reason="1024-bit key; unprotected key" header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=NklR24Fq; dkim-adsp=none (unprotected policy); dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; q=dns; s=default; b=JCtztSn4OCSlMLy9 Zj3pVsZ+3lKjCGFBdNSGWI453uof1UzY2BjxqOwhkk1vWSbhBbaLr2LbBpa9Wvhl kmn51/iXRqD/eCjsxc2zGwhr9UX2XjqFTYt/9a3caiHgaJnBwMc8Bu9VLKxbXZP5 X97+covZvSCpffLVXQTIYUqQUeE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=default; bh=tuVqeDIb0WvpZfG7UqHtKO aivTw=; b=NklR24Fq4c45jrgVKgxDSfzZXiqLP2dx9dvp973atBEHArJCUOWSjP xv08B5J9y0+ICnLBqQKYgBVsSlHxN94jzv8CSnSVhpXPoWFU9sETGPnAE/HQEUSU aQdlooXWgdYNGqPOzY/+mCQ2bmFUH5RpLIEX1Ij/metdyILdj0mUY= Received: (qmail 9400 invoked by alias); 25 Mar 2015 08:30:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 9384 invoked by uid 89); 25 Mar 2015 08:30:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Mar 2015 08:30:16 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-05.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1YaghX-0002o1-V8 from Thomas_Schwinge@mentor.com ; Wed, 25 Mar 2015 01:30:12 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-05.mgc.mentorg.com (137.202.0.112) with Microsoft SMTP Server id 14.3.224.2; Wed, 25 Mar 2015 08:30:10 +0000 From: Thomas Schwinge To: Tom de Vries CC: GCC Patches , Richard Biener , Jakub Jelinek Subject: Re: [PATCH][3/3][PR65460] Mark offloaded functions as parallelized In-Reply-To: <550DF11B.4020703@mentor.com> References: <5509B43E.802@mentor.com> <550AAD8B.9080900@mentor.com> <550C06BB.1050500@mentor.com> <550DF11B.4020703@mentor.com> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Wed, 25 Mar 2015 09:30:00 +0100 Message-ID: <87fv8t5vjr.fsf@schwinge.name> MIME-Version: 1.0 Hi Tom! On Sat, 21 Mar 2015 23:30:51 +0100, Tom de Vries wrote: > On 20-03-15 12:38, Tom de Vries wrote: > > On 19-03-15 12:05, Tom de Vries wrote: > >> On 18-03-15 18:22, Tom de Vries wrote: > >>> this patch fixes PR65460. > >>> > >>> The patch marks offloaded functions as parallelized, which means the parloops > >>> pass no longer attempts to modify that function. > >> > >> Updated patch to postpone mark_parallelized_function until the corresponding > >> cgraph_node is available, to ensure it works with the updated > >> mark_parallelized_function from patch 2/3. > > > > Updated to eliminate mark_parallelized_function. > > > > Bootstrapped and reg-tested on x86_64. > > > > OK for stage4? > > as requested, applied to gomp-4_0-branch. Thanks! Committed to gomp-4_0-branch in r221652: commit 68c0851cb7ce420d5d938d7f0d9247adf79190a5 Author: tschwinge Date: Wed Mar 25 08:28:09 2015 +0000 Use ChangeLog.gomp on gomp-4_0-branch. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@221652 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog | 34 ---------------------------------- gcc/ChangeLog.gomp | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 34 insertions(+), 34 deletions(-) Grüße, Thomas diff --git gcc/ChangeLog gcc/ChangeLog index 48dca87..e474fc8 100644 --- gcc/ChangeLog +++ gcc/ChangeLog @@ -1,37 +1,3 @@ -2015-03-21 Tom de Vries - - PR tree-optimization/65460 - * omp-low.c (expand_omp_target): Set parallelized_function on - cgraph_node for child_fn. - -2015-03-21 Tom de Vries - - backport from trunk: - 2015-03-21 Tom de Vries - - PR tree-optimization/65458 - * cgraph.c (cgraph_node::dump): Handle parallelized_function field. - * cgraph.h (cgraph_node): Add parallelized_function field. - * lto-cgraph.c (lto_output_node): Write parallelized_function field. - (input_overwrite_node): Read parallelized_function field. - * omp-low.c (expand_omp_taskreg, finalize_task_copyfn): Set - parallelized_function on cgraph_node for child_fn. - * tree-parloops.c: Add include of plugin-api.h, ipa-ref.h and cgraph.h. - Remove include of gt-tree-parloops.h. - (parallelized_functions): Remove static variable. - (parallelized_function_p): Rewrite using parallelized_function field of - cgraph_node. - (create_loop_fn): Remove adding to parallelized_functions. - * Makefile.in (GTFILES): Remove tree-parloops.c - -2015-03-21 Tom de Vries - - backport from trunk: - 2015-03-18 Tom de Vries - - * tree-parloops.c (parallelize_loops): Make static. - * tree-parloops.h (parallelize_loops): Remove extern declaration. - 2015-03-11 Thomas Schwinge * config/nvptx/nvptx.h (LIBSTDCXX): Define to "gcc". diff --git gcc/ChangeLog.gomp gcc/ChangeLog.gomp index 6ed6962..b499d04 100644 --- gcc/ChangeLog.gomp +++ gcc/ChangeLog.gomp @@ -1,3 +1,37 @@ +2015-03-21 Tom de Vries + + PR tree-optimization/65460 + * omp-low.c (expand_omp_target): Set parallelized_function on + cgraph_node for child_fn. + +2015-03-21 Tom de Vries + + backport from trunk: + 2015-03-21 Tom de Vries + + PR tree-optimization/65458 + * cgraph.c (cgraph_node::dump): Handle parallelized_function field. + * cgraph.h (cgraph_node): Add parallelized_function field. + * lto-cgraph.c (lto_output_node): Write parallelized_function field. + (input_overwrite_node): Read parallelized_function field. + * omp-low.c (expand_omp_taskreg, finalize_task_copyfn): Set + parallelized_function on cgraph_node for child_fn. + * tree-parloops.c: Add include of plugin-api.h, ipa-ref.h and cgraph.h. + Remove include of gt-tree-parloops.h. + (parallelized_functions): Remove static variable. + (parallelized_function_p): Rewrite using parallelized_function field of + cgraph_node. + (create_loop_fn): Remove adding to parallelized_functions. + * Makefile.in (GTFILES): Remove tree-parloops.c + +2015-03-21 Tom de Vries + + backport from trunk: + 2015-03-18 Tom de Vries + + * tree-parloops.c (parallelize_loops): Make static. + * tree-parloops.h (parallelize_loops): Remove extern declaration. + 2015-01-13 Thomas Schwinge * tree-core.h: Don't include "gomp-constants.h".