diff mbox

[gomp4] acc reductions with multiple variables

Message ID 87egtghcdy.fsf@kepler.schwinge.homeip.net
State New
Headers show

Commit Message

Thomas Schwinge Nov. 6, 2014, 10:06 a.m. UTC 
Hi!

On Fri, 31 Oct 2014 16:35:27 -0700, Cesar Philippidis <cesar@codesourcery.com> wrote:
> This patch does the following: [...]

> 	gcc/

> 	* omp-low.c (oacc_max_threads): New function.
> 	(lower_reduction_clauses): Use the GOACC thread builtin functions to
> 	determine the thread count. Handle multiple reduction variables.
> 	(expand_omp_for_static_nochunk): Likewise.
> 	(expand_omp_for_static_chunk): Likewise.
> 	(finalize_reduction_data): General cleanups.
> 	(process_reduction_data): Use acc_get_device_type to determine nthreads
> 	at runtime.

I fixed, conservatively, a bootstrap failure in gomp-4_branch's r217183:

commit 7b80846629e7ed87bfd9efe42a7b49712b38c5a6
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Thu Nov 6 10:04:25 2014 +0000

    Fix bootstrap failure.
    
        [...]/source-gcc/gcc/omp-low.c: In function 'void lower_reduction_clauses(tree, gimple_statement_base**, omp_context*)':
        [...]/source-gcc/gcc/omp-low.c:4611:70: error: 'tid' may be used uninitialized in this function [-Werror=maybe-uninitialized]
                lower_reduction_var_helper (stmt_seqp, ctx, tid, var, new_var);
                                                                              ^
        cc1plus: all warnings being treated as errors
        make[3]: *** [omp-low.o] Error 1
        make[3]: Leaving directory `[...]/build-gcc/gcc'
        make[2]: *** [all-stage2-gcc] Error 2
        make[2]: Leaving directory `[...]/build-gcc'
        make[1]: *** [stage2-bubble] Error 2
        make[1]: Leaving directory `[...]/build-gcc'
        make: *** [all] Error 2
    
    	gcc/
    	* omp-low.c (lower_reduction_clauses): Initialize tid.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@217183 138bc75d-0d04-0410-961f-82ee72b054a4
---
 gcc/ChangeLog.gomp | 4 ++++
 gcc/omp-low.c      | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)



Grüße,
 Thomas
diff mbox

Patch

diff --git gcc/ChangeLog.gomp gcc/ChangeLog.gomp
index d140a35..0bc9080 100644
--- gcc/ChangeLog.gomp
+++ gcc/ChangeLog.gomp
@@ -1,3 +1,7 @@ 
+2014-11-06  Thomas Schwinge  <thomas@codesourcery.com>
+
+	* omp-low.c (lower_reduction_clauses): Initialize tid.
+
 2014-11-05  Thomas Schwinge  <thomas@codesourcery.com>
 
 	* tree-core.h (enum omp_clause_code): Remove OMP_CLAUSE_HOST and
diff --git gcc/omp-low.c gcc/omp-low.c
index 0b45e69..23d9f5a8 100644
--- gcc/omp-low.c
+++ gcc/omp-low.c
@@ -4530,7 +4530,7 @@  lower_reduction_clauses (tree clauses, gimple_seq *stmt_seqp, omp_context *ctx)
 {
   gimple_seq sub_seq = NULL;
   gimple stmt;
-  tree x, c, tid;
+  tree x, c, tid = NULL_TREE;
   int count = 0;
 
   /* SIMD reductions are handled in lower_rec_input_clauses.  */