From patchwork Thu Nov 13 13:24:31 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 410412 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1E9871400DE for ; Fri, 14 Nov 2014 00:24:59 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; q=dns; s=default; b=moiC3ai089GOhaVe cW5vgCve+KyE5EEhymhv/9ipZufybjk/dnj+W9HQeqzQFZ1xZNmNOcq0bqzpGxA9 XMMtsWTn1+/0PThDIHinceAFJyckPPra1ZXoOw7wtU6BSALKpmTAnm7EYBStBuZ4 KItRYWkJxGuu0f2NcuRbz0TO9yc= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=default; bh=50hXtxcLW8xOtY6gKwj8Hy SFKuE=; b=Kehm32bsWpqODU1kTBCCuL3knUS8Z2AOCiYVrtUE9vzuNI5g9ybh4s +KxAFyRmRg1onSkcm+yTV75A0GprPBGEvo2bdKr235F0NDyPjmI3SdFt83C0Uz2C sWeZlGlCExVVSuO5Eltpf+Pvtiu5Ge+rgtZXoCKrQCfs575COVtWA= Received: (qmail 21859 invoked by alias); 13 Nov 2014 13:24:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 21847 invoked by uid 89); 13 Nov 2014 13:24:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Nov 2014 13:24:50 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1XouOE-0004t6-NH from Thomas_Schwinge@mentor.com for gcc-patches@gcc.gnu.org; Thu, 13 Nov 2014 05:24:47 -0800 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.181.6; Thu, 13 Nov 2014 13:24:45 +0000 From: Thomas Schwinge To: CC: Julian Brown , James Norris Subject: Re: [gomp4] [2/3] OpenACC 2.0 support for libgomp - new tests In-Reply-To: <20141014171142.14aa7de4@octopus> References: <20141014171142.14aa7de4@octopus> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Thu, 13 Nov 2014 14:24:31 +0100 Message-ID: <87bnobcjxs.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Hi! On Tue, 14 Oct 2014 17:11:42 +0100, Julian Brown wrote: > --- /dev/null > +++ b/libgomp/testsuite/libgomp.oacc-c/context-2.c > + float *h_X, [...] > + h_X = (float *) malloc (N * sizeof (float)); > + d_X = (float *) acc_copyin (&h_X[0], N * sizeof (float)); > +#pragma acc parallel copyin (h_X[0:N]), copy (h_Y2[0:N]) copyin (alpha) As made apparent by a testsuite regression, after gomp-4_0-branch commit r217482, , this needs to be changed as follows; committed to gomp-4_0-branch in r217484: commit 0a74cef871aefd56e577d19864f80e78b6af09e8 Author: tschwinge Date: Thu Nov 13 13:22:54 2014 +0000 libgomp testsuite: Fix data clause. ... after having extended libgomp to actually distinguish between "non-force"/"force" semantics. libgomp/ * testsuite/libgomp.oacc-c-c++-common/context-2.c: Fix data clause. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@217484 138bc75d-0d04-0410-961f-82ee72b054a4 --- libgomp/ChangeLog.gomp | 3 +++ libgomp/testsuite/libgomp.oacc-c-c++-common/context-2.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) Grüße, Thomas diff --git libgomp/ChangeLog.gomp libgomp/ChangeLog.gomp index 254846f..a5a58a0 100644 --- libgomp/ChangeLog.gomp +++ libgomp/ChangeLog.gomp @@ -1,5 +1,8 @@ 2014-11-13 Thomas Schwinge + * testsuite/libgomp.oacc-c-c++-common/context-2.c: Fix data + clause. + * target.c (gomp_map_vars_existing): Error out if "force" semantics. (gomp_map_vars): Actually pass kinds to gomp_map_vars_existing. diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/context-2.c libgomp/testsuite/libgomp.oacc-c-c++-common/context-2.c index 16464d5..6a52f74 100644 --- libgomp/testsuite/libgomp.oacc-c-c++-common/context-2.c +++ libgomp/testsuite/libgomp.oacc-c-c++-common/context-2.c @@ -149,7 +149,7 @@ main (int argc, char **argv) context_check (pctx); -#pragma acc parallel copyin (h_X[0:N]), copy (h_Y2[0:N]) copyin (alpha) +#pragma acc parallel present (h_X[0:N]), copy (h_Y2[0:N]) copyin (alpha) { int i;