From patchwork Wed Aug 5 14:21:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Sandiford X-Patchwork-Id: 504032 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id AA13C1402B9 for ; Thu, 6 Aug 2015 00:21:37 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=vgc3o+0g; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; q=dns; s=default; b=s78ZoS9WlS+14WD4 qtMtn6QswnxWcu/qLEn+IXA8zwnEk5Fe8QNCgI8eU89D38DKqgDtYUxPSNm5If6t miN33NhTMLj/IWkewDnmWUy4mrQKZ4kRD3cu55krJiGUI/Sl2kEQu6QxZtcuX0Nt 1INZSjhCLb8We0z007vJLy3tJv4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=default; bh=Z9wqB+LKlTGV9XTgoarwEV Sfx4I=; b=vgc3o+0gHGtp6ojHptXk0nQZsospXppXLejyDNGesW7KEKv/i678JA ffc6KqIJqi3wOzn8VAnr6z7klYcSPhi3eWDpXIlbijKLXRpsQgnS/451nQF7EoWI rJT4WHQ0Y6787J6hBE+Lzk8MWk21YvCMAJtlWbrfD+W0t8lNg2FcI= Received: (qmail 71166 invoked by alias); 5 Aug 2015 14:21:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 71152 invoked by uid 89); 5 Aug 2015 14:21:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Aug 2015 14:21:29 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-27-B3She60fTUmcho_EzbipQw-1; Wed, 05 Aug 2015 15:21:24 +0100 Received: from localhost ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 5 Aug 2015 15:21:24 +0100 From: Richard Sandiford To: gcc-patches@gcc.gnu.org Mail-Followup-To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: Remove bogus can_extend Date: Wed, 05 Aug 2015 15:21:24 +0100 Message-ID: <878u9pke8r.fsf@e105548-lin.cambridge.arm.com> User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-MC-Unique: B3She60fTUmcho_EzbipQw-1 Richard Henderson writes: > On 07/28/2015 01:36 PM, Richard Sandiford wrote: > > Index: gcc/target-insns.def > > =================================================================== > > --- gcc/target-insns.def 2015-07-28 20:56:29.721512028 +0100 > > +++ gcc/target-insns.def 2015-07-28 20:56:29.713512127 +0100 > > @@ -34,6 +34,7 @@ DEF_TARGET_INSN (allocate_stack, (rtx x0 > > DEF_TARGET_INSN (builtin_longjmp, (rtx x0)) > > DEF_TARGET_INSN (builtin_setjmp_receiver, (rtx x0)) > > DEF_TARGET_INSN (builtin_setjmp_setup, (rtx x0)) > > +DEF_TARGET_INSN (can_extend, (rtx x0, rtx x1)) > > DEF_TARGET_INSN (canonicalize_funcptr_for_compare, (rtx x0, rtx x1)) > > DEF_TARGET_INSN (casesi, (rtx x0, rtx x1, rtx x2, rtx x3, rtx x4)) > > DEF_TARGET_INSN (check_stack, (rtx x0)) > > Am I missing something? Where is the can_extend hook used? Gah. I'd even fixed this on my local machine but committed it on the work machine (where most of the testing was done). Tested on x86_64-linux-gnu and committed as obvious. Thanks for catching it. Richard gcc/ * target-insns.def (can_extend): Delete. diff --git a/gcc/target-insns.def b/gcc/target-insns.def index 0c64a6b..ef8e6b0 100644 --- a/gcc/target-insns.def +++ b/gcc/target-insns.def @@ -35,7 +35,6 @@ DEF_TARGET_INSN (atomic_test_and_set, (rtx x0, rtx x1, rtx x2)) DEF_TARGET_INSN (builtin_longjmp, (rtx x0)) DEF_TARGET_INSN (builtin_setjmp_receiver, (rtx x0)) DEF_TARGET_INSN (builtin_setjmp_setup, (rtx x0)) -DEF_TARGET_INSN (can_extend, (rtx x0, rtx x1)) DEF_TARGET_INSN (canonicalize_funcptr_for_compare, (rtx x0, rtx x1)) DEF_TARGET_INSN (casesi, (rtx x0, rtx x1, rtx x2, rtx x3, rtx x4)) DEF_TARGET_INSN (check_stack, (rtx x0))