From patchwork Thu Jul 5 14:29:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nick Clifton X-Patchwork-Id: 169211 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id A72D02C020B for ; Fri, 6 Jul 2012 01:34:30 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1342107271; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:Sender:Delivered-To; bh=GM6+lhappL916c2Wz+Uy awuy9X8=; b=Weai/KdeilPf4VjOL1fIvLzmc1JXpR15qAEUL5w5LL7SPb0FsBhx qsT26HKvCN4gcybomSjyJjyGVzusargMnbo4C2lVma7LVOcYHce59SXbFz7d0uUN IjlYs/oIrVNoBFJdOKBJSJjan37Qk2UZ1kCDdEm+4HDb6dQJps8UQ3E= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=AdDJHQOgYlQ3rpKV0aSusl/mfy4FsxmtOVIDwxqzBlF4Y/oNvJnmxfFHhzNwpA Ex068vcBXOX2T/lWVaWvN+bRwnCe2jip9dK/XBT7CQaZQd/PIEyVERhkx/F0s8s6 a8e/aPatQG94ATSZ8Fv49XPXeXV76sB9RXlAz7BCo2qFw=; Received: (qmail 15433 invoked by alias); 5 Jul 2012 15:34:25 -0000 Received: (qmail 14720 invoked by uid 22791); 5 Jul 2012 15:34:22 -0000 X-SWARE-Spam-Status: No, hits=-5.3 required=5.0 tests=AWL, BAYES_00, KAM_STOCKGEN, KHOP_RCVD_UNTRUST, RCVD_IN_DNSWL_HI, RCVD_IN_HOSTKARMA_W, SPF_HELO_PASS, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 05 Jul 2012 15:34:07 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q65FY6ex032451 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 5 Jul 2012 11:34:07 -0400 Received: from Cadeux.redhat.com (vpn1-4-40.ams2.redhat.com [10.36.4.40]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q65FY3Wt019727 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 5 Jul 2012 11:34:05 -0400 From: Nick Clifton To: law@redhat.com, aoliva@redhat.com Cc: gcc-patches@gcc.gnu.org Subject: RFA: MN10300: Call default_encode_section_info Date: Thu, 05 Jul 2012 15:29:17 +0100 Message-ID: <8762a28eo2.fsf@redhat.com> MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi Jeff, Hi Alex, This may count as an obvious fix, but I felt that I ought to check, just in case... Currently mn10300_encode_section_info() does not call default_encode_section_info(). This means that it misses out on possibly setting some important flags in the symbol, such as SYMBOL_FLAG_FUNCTION, SYMBOL_FLAG_LOCAL or the TLS encoding. Fixed by the following patch, and tested on an mn10300-elf toolchain. OK for mainline and 4.7/4.6 branches ? Cheers Nick gcc/ChangeLog 2012-07-05 Nick Clifton * config/mn10300/mn10300.c (mn10300_encode_section_info): Call default_encode_section_info. Index: gcc/config/mn10300/mn10300.c =================================================================== --- gcc/config/mn10300/mn10300.c (revision 189281) +++ gcc/config/mn10300/mn10300.c (working copy) @@ -2468,7 +2476,7 @@ may access it using GOTOFF instead of GOT. */ static void -mn10300_encode_section_info (tree decl, rtx rtl, int first ATTRIBUTE_UNUSED) +mn10300_encode_section_info (tree decl, rtx rtl, int first) { rtx symbol; @@ -2480,6 +2488,8 @@ if (flag_pic) SYMBOL_REF_FLAG (symbol) = (*targetm.binds_local_p) (decl); + + default_encode_section_info (decl, rtl, first); } /* Dispatch tables on the mn10300 are extremely expensive in terms of code