From patchwork Fri Jun 13 11:35:13 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 359532 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 5CB011400F0 for ; Fri, 13 Jun 2014 21:35:43 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; q=dns; s=default; b=y6ZYcPdIh4taxub5 XsOneH9u06tu81DFuCGugMPp2Hy/DSy33/YSWiRkKvGKzGwBxXjuZITSobe0cNZ3 Jt5fovyBgleT4xHJeO920k26Z9s7Pe21Mti+YYuvMK/JN5xqLE6rp0r6PcObecd0 EdKvQuBYTfhIokasskik2T0kc+I= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=default; bh=ywQo1UERC7uM9A+nEUubNe T4X7k=; b=MUT+qTkfO5ubQWFZW0R78twWIrmrarZC4qhAKiOY3lKPSwHgzLi7L5 n3j4YB/GdDkV08qjh1gNQ+FjzPUfMQGs2NleYoNe8n6+rztwaBj6f+zhGkRNhsAu psOd6L4Jfd2DnnOqfamKffKbleCUTDSQDZsxAO4u1WG0fdVS1X2Dw= Received: (qmail 27270 invoked by alias); 13 Jun 2014 11:35:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 27208 invoked by uid 89); 13 Jun 2014 11:35:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00 autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Jun 2014 11:35:23 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1WvPlQ-0003Rp-I5 from Thomas_Schwinge@mentor.com ; Fri, 13 Jun 2014 04:35:20 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Fri, 13 Jun 2014 04:35:20 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.2.247.3; Fri, 13 Jun 2014 12:35:18 +0100 From: Thomas Schwinge To: Ilmir Usmanov CC: "gcc-patches@gcc.gnu.org" , , Jakub Jelinek , , Cesar Philippidis Subject: Re: [patch][gomp4] openacc loops In-Reply-To: <538F24E2.5070507@samsung.com> References: <538E538E.9010304@codesourcery.com> <538F24E2.5070507@samsung.com> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Fri, 13 Jun 2014 13:35:13 +0200 Message-ID: <8761k511qm.fsf@schwinge.name> MIME-Version: 1.0 Hi Ilmir! On Wed, 4 Jun 2014 17:53:38 +0400, Ilmir Usmanov wrote: > you should update tree-pretty-print.c (I forgot this): > @@ -675,13 +675,13 @@ dump_omp_clause (pretty_printer *buffer, tree > clause, int spc, int flags) > > case OMP_CLAUSE_WORKER: > pp_string (buffer, "worker("); > - dump_generic_node (buffer, OMP_CLAUSE_DECL (clause), spc, flags, > false); > + dump_generic_node (buffer, OMP_CLAUSE_WORKER_EXPR (clause), spc, > flags, false); > pp_character(buffer, ')'); > break; > > case OMP_CLAUSE_VECTOR: > pp_string (buffer, "vector("); > - dump_generic_node (buffer, OMP_CLAUSE_DECL (clause), spc, flags, > false); > + dump_generic_node (buffer, OMP_CLAUSE_VECTOR_EXPR (clause), spc, > flags, false); > pp_character(buffer, ')'); > break; I assume, do similar changes also for other clauses, for which we have more specialized accessors available? We may not actually need/want that, but can simplify this later on. I checked in the following to gomp-4_0-branch, r211633: commit 86d4893c435bbcb2bc251aafde11f36e2e703a4c Author: tschwinge Date: Fri Jun 13 11:16:40 2014 +0000 Instead of OMP_CLAUSE_DECL, use more specific accessors for some clauses. gcc/ * tree-pretty-print.c (dump_omp_clause): Instead of OMP_CLAUSE_DECL, use more specific accessors for some clauses. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@211633 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog.gomp | 6 ++++++ gcc/tree-pretty-print.c | 16 ++++++++++------ 2 files changed, 16 insertions(+), 6 deletions(-) Grüße, Thomas diff --git gcc/ChangeLog.gomp gcc/ChangeLog.gomp index 75e47d0..51bab90 100644 --- gcc/ChangeLog.gomp +++ gcc/ChangeLog.gomp @@ -1,4 +1,10 @@ 2014-06-13 Thomas Schwinge + Ilmir Usmanov + + * tree-pretty-print.c (dump_omp_clause): Instead of + OMP_CLAUSE_DECL, use more specific accessors for some clauses. + +2014-06-13 Thomas Schwinge Cesar Philippidis * omp-low.c (extract_omp_for_data, scan_sharing_clauses): For diff --git gcc/tree-pretty-print.c gcc/tree-pretty-print.c index 22b82fe..82b0f7a 100644 --- gcc/tree-pretty-print.c +++ gcc/tree-pretty-print.c @@ -652,16 +652,17 @@ dump_omp_clause (pretty_printer *buffer, tree clause, int spc, int flags) case OMP_CLAUSE_GANG: pp_string (buffer, "gang("); - dump_generic_node (buffer, OMP_CLAUSE_DECL (clause), spc, flags, false); + dump_generic_node (buffer, OMP_CLAUSE_GANG_EXPR (clause), + spc, flags, false); pp_character(buffer, ')'); break; case OMP_CLAUSE_ASYNC: pp_string (buffer, "async"); - if (OMP_CLAUSE_DECL (clause)) + if (OMP_CLAUSE_ASYNC_EXPR (clause)) { pp_character(buffer, '('); - dump_generic_node (buffer, OMP_CLAUSE_DECL (clause), + dump_generic_node (buffer, OMP_CLAUSE_ASYNC_EXPR (clause), spc, flags, false); pp_character(buffer, ')'); } @@ -669,19 +670,22 @@ dump_omp_clause (pretty_printer *buffer, tree clause, int spc, int flags) case OMP_CLAUSE_WAIT: pp_string (buffer, "wait("); - dump_generic_node (buffer, OMP_CLAUSE_DECL (clause), spc, flags, false); + dump_generic_node (buffer, OMP_CLAUSE_WAIT_EXPR (clause), + spc, flags, false); pp_character(buffer, ')'); break; case OMP_CLAUSE_WORKER: pp_string (buffer, "worker("); - dump_generic_node (buffer, OMP_CLAUSE_DECL (clause), spc, flags, false); + dump_generic_node (buffer, OMP_CLAUSE_WORKER_EXPR (clause), + spc, flags, false); pp_character(buffer, ')'); break; case OMP_CLAUSE_VECTOR: pp_string (buffer, "vector("); - dump_generic_node (buffer, OMP_CLAUSE_DECL (clause), spc, flags, false); + dump_generic_node (buffer, OMP_CLAUSE_VECTOR_EXPR (clause), + spc, flags, false); pp_character(buffer, ')'); break;