From patchwork Fri Jul 17 08:37:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Schwinge X-Patchwork-Id: 497032 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id DC099140776 for ; Fri, 17 Jul 2015 18:38:02 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=YYJdu8DL; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; q=dns; s=default; b=Lqr8JeVWi692n9tm em5R9JGvWF5uC5K5p20OBQI5uPfrWGr2c8DmfWtjiQBTAMWlF/n4p1LDPCH03McV s3LVnEJmdTq32YLmCSI0a8RLS/So9mAftjcMfEyxnlLYQvCUc3kUsbzHRBeWl909 ZWtkMCefl1ODh3OsLQ2Ot1BYrXA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=default; bh=03cNelNpNZSoFBQWfcuUye 28mcc=; b=YYJdu8DLkczk3sX6xd6VxacbYb1pVatzgCl+jxCgaU1E2pYZo19D63 wIdOJa6Qcnj04cWM98OKzNvgHXiR5AjouEvwVu0IhunEvmJkH08jqidNXVRzzMuW jeV/3skLce3LAYex8S9LvpikaM5wt+LgTWWTFJ502WYDQC072kuco= Received: (qmail 52358 invoked by alias); 17 Jul 2015 08:37:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 52349 invoked by uid 89); 17 Jul 2015 08:37:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 17 Jul 2015 08:37:53 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZG19R-0004Z9-At from Thomas_Schwinge@mentor.com for gcc-patches@gcc.gnu.org; Fri, 17 Jul 2015 01:37:49 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-02.mgc.mentorg.com (137.202.0.106) with Microsoft SMTP Server id 14.3.224.2; Fri, 17 Jul 2015 09:37:47 +0100 From: Thomas Schwinge To: Nathan Sidwell CC: , GCC Patches Subject: Re: [gomp] Fix PTX worker spill/fill In-Reply-To: <55A7DA98.5020404@acm.org> References: <55A7DA98.5020404@acm.org> <877fq41epd.fsf@kepler.schwinge.homeip.net> <55A7D5DD.2070600@mentor.com> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) Date: Fri, 17 Jul 2015 10:37:38 +0200 Message-ID: <87615jw565.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Hi! On Thu, 16 Jul 2015 12:23:52 -0400, Nathan Sidwell wrote: > I've committed this patch to fix a bug in the worker spill/fill code. We ended > up not incrementing the pointer, resulting in the stack frame being filled with > the same value. > > Thanks to Jim for finding the failure. > --- config/nvptx/nvptx.c (revision 225831) > +++ config/nvptx/nvptx.c (working copy) > @@ -1257,7 +1257,7 @@ nvptx_gen_wcast (rtx reg, propagate_mask > > emit_insn (res); > emit_insn (gen_adddi3 (data->ptr, data->ptr, > - GEN_INT (GET_MODE_SIZE (GET_MODE (res))))); > + GEN_INT (GET_MODE_SIZE (GET_MODE (reg))))); > res = get_insns (); > end_sequence (); > } Nice; this is actually the change to resolve the FAIL for libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c I had reported in . (The testsuite/libgomp.oacc-c-c++-common/parallel-loop-1.c regression reported earlier in that thread remains to be addressed.) Committed to gomp-4_0-branch in r225922: commit 7961bf7049729aebadf639a52174be14010da499 Author: tschwinge Date: Fri Jul 17 08:30:10 2015 +0000 libgomp: Remove XFAIL libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c for acc_device_nvidia Problem got addressed in r225896. libgomp/ * testsuite/libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c: Remove XFAIL. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@225922 138bc75d-0d04-0410-961f-82ee72b054a4 --- libgomp/ChangeLog.gomp | 5 +++++ .../libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c | 3 --- 2 files changed, 5 insertions(+), 3 deletions(-) Grüße, Thomas diff --git libgomp/ChangeLog.gomp libgomp/ChangeLog.gomp index b2e4b2c..0293ad5 100644 --- libgomp/ChangeLog.gomp +++ libgomp/ChangeLog.gomp @@ -1,3 +1,8 @@ +2015-07-17 Thomas Schwinge + + * testsuite/libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c: + Remove XFAIL. + 2015-07-15 Nathan Sidwell * plugin/plugin-nvptx.c (nvptx_exec): Show grid dimensions in diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c libgomp/testsuite/libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c index a710849..b070773 100644 --- libgomp/testsuite/libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c +++ libgomp/testsuite/libgomp.oacc-c-c++-common/private-vars-loop-gang-5.c @@ -1,6 +1,3 @@ -/* main: Assertion `arr[i] == i + (i % 8) * 2' failed. - { dg-xfail-run-if "TODO" { openacc_nvidia_accel_selected } { "*" } { "" } } */ - #include /* Test of gang-private array variable declared on loop directive, with