From patchwork Fri Jul 21 14:05:56 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Sidwell X-Patchwork-Id: 792144 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-458655-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="MCO4EXfe"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xDXcW6gFJz9s7g for ; Sat, 22 Jul 2017 00:06:18 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type; q=dns; s=default; b=L8DXZ62toqkeXMgMf MMhnseqZZTVkRDHFk0XzVkGPPIJ1twhF4inBGviO461BEDREkpDwowi2ur4M0mfW gRbP2AaQTiA0IhdiuK35Exd6KOHlAdV0CsNYnw9sx6IEXZFWs1S2PxQB14/LO6pc 6bGV39W5LqVqDghjqWi4mVm5Zs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type; s=default; bh=mPKZvLdUbHS3YHHGV5ygdCa 12LI=; b=MCO4EXfeD0TdNk0JCZ8qTn/r4LWe5HL/hVMpWCtJ2AeEtv2i+U475QR wp0yA1oulg+apsjydytMB1sP2PgT0GJsVe3iSHtu9oHwLu/t2wT05FHcVYTWI9q+ 2fFQNIvNAAI8FN2iTOfnaE7AN031CyfkROyiF29r8UVq6dgQ9HuQ= Received: (qmail 44778 invoked by alias); 21 Jul 2017 14:06:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 44730 invoked by uid 89); 21 Jul 2017 14:06:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.6 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_2, GIT_PATCH_3, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=shortterm, short-term X-HELO: mail-yw0-f196.google.com Received: from mail-yw0-f196.google.com (HELO mail-yw0-f196.google.com) (209.85.161.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Jul 2017 14:06:01 +0000 Received: by mail-yw0-f196.google.com with SMTP id v193so2220346ywg.0 for ; Fri, 21 Jul 2017 07:06:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language; bh=YXRYRaig0Fi7MEuxfOCYg6Bz8D+tFCeyL2VKN5RpCEQ=; b=a5UnY4h1BIxxafoTAb/sniijqFDUtgovOKTJr+ggOFsoNYUd2F6/RQ+pGIQ6r8qjsE UfNpX6uF5TBvs9nFZku7rx8DZtccbpA+U87div80jsxyXRBUDl7MVJr6Sj2wGqj/UDeR 35UOV4uqxyYSJSY7xzuHhZ9S01jnM5lyGrJlhVpf+bI3iFFLLtF1mkHxz/v1w9DQ7nfg h0hscYVU2+UcUsY5VLn98e15tIojZYQshStuh1lulbuUK9UtReB8jwovvcUFiWEb1Xmy AVVxU9IC5aO4nfM8KUS+lAwfHVo/3NRCp60VoVwfpNRXmA99NfGgmdcdHAuloOiGzffC NLgw== X-Gm-Message-State: AIVw112B71uT/66ZMYfj7ofdBiXwM3/M1D1wAw/Uc+ivw3W64jfLzMv5 vEzyV3NsTfrqfA== X-Received: by 10.129.101.195 with SMTP id z186mr6615776ywb.267.1500645959619; Fri, 21 Jul 2017 07:05:59 -0700 (PDT) Received: from ?IPv6:2620:10d:c0a3:20fb:7500:e7fb:4a6f:2254? ([2620:10d:c091:200::3:fb48]) by smtp.googlemail.com with ESMTPSA id y129sm1682093ywc.54.2017.07.21.07.05.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Jul 2017 07:05:58 -0700 (PDT) Subject: Re: Deprecate DBX/stabs? To: Richard Biener Cc: Jim Wilson , GCC Patches , Jason Merrill , Jim Wilson , Jan Hubicka , Mike Stump , iain@codesourcery.com, Nick Clifton , 10walls@gmail.com References: <8377f2cd-577c-60b2-63ac-f2619ebe63aa@acm.org> <6af64e4b-403e-2b88-3067-cd0dc4da64d8@linaro.org> <000f20c2-86fb-9d71-dc66-03167de00142@acm.org> <0be1446d-d866-f3b9-8691-3df4cc088211@acm.org> <0170999F-BBCE-41AE-BC3F-36E8AF53A7C6@gmail.com> From: Nathan Sidwell Message-ID: <7a102a02-fddd-d983-c3c8-a3968cfeca9d@acm.org> Date: Fri, 21 Jul 2017 10:05:56 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: On 07/21/2017 09:16 AM, Richard Biener wrote: > On Fri, Jul 21, 2017 at 3:07 PM, Nathan Sidwell wrote: > +#ifndef DBX_DEBBUG_OK > ^^^ > typo? The patch doesn't define this anywhere - I suggest to add it to > defaults.h > as 0 and use #if? Also would need documenting if this is supposed to be a > target macro. Like this? I've now included XCOFF, as it's a subset of DBX. Nothing appears to default to it. nathan 2017-07-21 Nathan Sidwell * defaults.h (DBX_DEBUG_DEPRECATED): New. * toplev.c (process_options): Warn about DBX/SDB being deprecated. * doc/tm.texi.in (DBX_DEBUG_DEPRECATED): Document. * doc/tm.texi: Updated. Index: defaults.h =================================================================== --- defaults.h (revision 250426) +++ defaults.h (working copy) @@ -889,6 +889,12 @@ see the files COPYING3 and COPYING.RUNTI #define SDB_DEBUGGING_INFO 0 #endif +/* DBX debugging is deprecated, and will generate a note if you + default to it. */ +#ifndef DBX_DEBUG_DEPRECATED +#define DBX_DEBUG_DEPRECATED 1 +#endif + /* If more than one debugging type is supported, you must define PREFERRED_DEBUGGING_TYPE to choose the default. */ Index: doc/tm.texi =================================================================== --- doc/tm.texi (revision 250426) +++ doc/tm.texi (working copy) @@ -9553,6 +9553,14 @@ user can always get a specific type of o @c prevent bad page break with this line These are specific options for DBX output. +DBX debug data is deprecated and is expected to be removed. + +@defmac DBX_DEBUG_DEPRECATED +Defined this macro to 1 if GCC should not warn about defaulting to DBX +or XCOFF debug output. This is intended to give maintainers notice of +deprecation, but not be unnecessarily invasive. Defining this macro is +a short-term measure. You need to plan for DBX's removal. +@end defmac @defmac DBX_DEBUGGING_INFO Define this macro if GCC should produce debugging output for DBX Index: doc/tm.texi.in =================================================================== --- doc/tm.texi.in (revision 250426) +++ doc/tm.texi.in (working copy) @@ -6842,6 +6842,14 @@ user can always get a specific type of o @c prevent bad page break with this line These are specific options for DBX output. +DBX debug data is deprecated and is expected to be removed. + +@defmac DBX_DEBUG_DEPRECATED +Defined this macro to 1 if GCC should not warn about defaulting to DBX +or XCOFF debug output. This is intended to give maintainers notice of +deprecation, but not be unnecessarily invasive. Defining this macro is +a short-term measure. You need to plan for DBX's removal. +@end defmac @defmac DBX_DEBUGGING_INFO Define this macro if GCC should produce debugging output for DBX Index: toplev.c =================================================================== --- toplev.c (revision 250426) +++ toplev.c (working copy) @@ -1413,6 +1413,12 @@ process_options (void) debug_info_level = DINFO_LEVEL_NONE; } + if (DBX_DEBUG_DEPRECATED + && write_symbols == PREFERRED_DEBUGGING_TYPE + && (PREFERRED_DEBUGGING_TYPE == DBX_DEBUG + || PREFERRED_DEBUGGING_TYPE == XCOFF_DEBUG)) + inform (UNKNOWN_LOCATION, "DBX/XCOFF (stabs) debugging is deprecated"); + if (flag_dump_final_insns && !flag_syntax_only && !no_backend) { FILE *final_output = fopen (flag_dump_final_insns, "w");