From patchwork Fri May 17 19:28:13 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Stump X-Patchwork-Id: 244693 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 77BDB2C00A7 for ; Sat, 18 May 2013 05:28:24 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; q=dns; s=default; b=PSDmBuz4Ix4xYQHSh rYjmZOWYsJ5dckbQdg3iIbORfoovqv1SIb7LIJGID7Z/OmTnAuEN1qVZ4uSomz1d Db7dktf1C+RDn2zdI9RmSLKYwJjWr1kZjtIo4gUygZoUNPGhnhwKItbgxE35Ops9 6jEbOcrraang3hoizoMbTZNlw0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :content-type:mime-version:subject:from:in-reply-to:date:cc :message-id:references:to; s=default; bh=ixtLW15CkSCIkdf/JlSKbrV EmvE=; b=tx/Cs3vLZy2yOffHuVOcjsSVypJDcmjteQzgEbQZFupHUHkBA55fwdI XIlO2E/vVB/NSjCzWZh1WV76utyrpLP4L73l7jfKViBEnu9+5w/dtFWe1qkiaFC8 RQp+WwSfWWaS0PSJ5VkJ/kgMl/ESsfjSOnUJpIHRjLAsXCGxYlQM= Received: (qmail 20276 invoked by alias); 17 May 2013 19:28:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 20266 invoked by uid 89); 17 May 2013 19:28:18 -0000 X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=BAYES_00, FREEMAIL_FROM, KHOP_THREADED, RCVD_IN_DNSWL_NONE, RCVD_IN_HOSTKARMA_NO, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.1 Received: from qmta07.emeryville.ca.mail.comcast.net (HELO qmta07.emeryville.ca.mail.comcast.net) (76.96.30.64) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 17 May 2013 19:28:17 +0000 Received: from omta12.emeryville.ca.mail.comcast.net ([76.96.30.44]) by qmta07.emeryville.ca.mail.comcast.net with comcast id d6M01l0050x6nqcA77UGyu; Fri, 17 May 2013 19:28:16 +0000 Received: from bag6-1-pt.tunnel.tserv3.fmt2.ipv6.he.net ([IPv6:2001:470:1f04:ae1::2]) by omta12.emeryville.ca.mail.comcast.net with comcast id d7UE1l0080P3DwE8Y7UFGy; Fri, 17 May 2013 19:28:16 +0000 Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) Subject: Re: web ICEs on subreg From: Mike Stump In-Reply-To: Date: Fri, 17 May 2013 12:28:13 -0700 Cc: Mike Stump , GCC Patches , Kenneth Zadeck Message-Id: <73FC2263-1672-47EE-A8B4-D57399F64DB2@comcast.net> References: To: David Edelsohn X-Virus-Found: No On May 16, 2013, at 5:26 PM, David Edelsohn wrote: > This patch is creating new segfaults for 32 bit POWER AIX. Thanks for the heads up. Fixed in r199030. 2013-05-17 Mike Stump PR rtl-optimization/57304 * web.c (union_match_dups): Ensure that DF_REF_LOC exists before accessing DF_REF_REAL_LOC. ------------------------------ Index: web.c =================================================================== --- web.c (revision 199016) +++ web.c (working copy) @@ -133,9 +133,10 @@ union_match_dups (rtx insn, struct web_e entry = type == OP_IN ? use_entry : def_entry; for (; *ref; ref++) { - if (DF_REF_LOC (*ref) == recog_data.operand_loc[op]) + rtx *l = DF_REF_LOC (*ref); + if (l == recog_data.operand_loc[op]) break; - if (DF_REF_REAL_LOC (*ref) == recog_data.operand_loc[op]) + if (l && DF_REF_REAL_LOC (*ref) == recog_data.operand_loc[op]) break; } @@ -143,9 +144,10 @@ union_match_dups (rtx insn, struct web_e { for (ref = use_link, entry = use_entry; *ref; ref++) { - if (DF_REF_LOC (*ref) == recog_data.operand_loc[op]) + rtx *l = DF_REF_LOC (*ref); + if (l == recog_data.operand_loc[op]) break; - if (DF_REF_REAL_LOC (*ref) == recog_data.operand_loc[op]) + if (l && DF_REF_REAL_LOC (*ref) == recog_data.operand_loc[op]) break; } }