From patchwork Thu Dec 17 14:06:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Sidwell X-Patchwork-Id: 1417694 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=sourceware.org; envelope-from=gcc-patches-bounces@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=Mhl0IU6p; dkim-atps=neutral Received: from sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CxYhq1KJHz9sW1 for ; Fri, 18 Dec 2020 01:07:06 +1100 (AEDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EC9543894C18; Thu, 17 Dec 2020 14:07:03 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by sourceware.org (Postfix) with ESMTPS id 9EFC2381DCCB for ; Thu, 17 Dec 2020 14:07:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9EFC2381DCCB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nathanmsidwell@gmail.com Received: by mail-qk1-x72f.google.com with SMTP id i67so18867715qkf.11 for ; Thu, 17 Dec 2020 06:07:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:to:from:subject:message-id:date:user-agent:mime-version :content-language; bh=+ImsCtpzuqTiiP6Zu7TpVi4DnkmFZpBn+gOU0R35tPg=; b=Mhl0IU6pp9R2IpSy6tpUpjlcz8E4C37wAEPYScKjcVtfGQEHtXDo08fnjL9DNEYrQG D0FVQ1jP/IPzrenE2s1b07DR1h968sr4DD+32wC5hGmBgnsQkvCQkMYbfpXbA/u/iEod DX+zPn12slh6LQio1Sxo+FY7+lCuLsGINTKU28mZ4ruHFpH1kimI6kdjyeGVAzJtoKlp 4dAiOqexvvlWfjqXsnuojel4UV3OsOVuH231ciPmPGWa3DnEcvrxq1BJHkjUE+H/7MZ8 kkAvrSmZJkMkJ+fb3Mke0xxI9MRNhkmYYwqQFBCaLufaNstIwyhMPXRWD/pmALP4Tg86 Oz6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version:content-language; bh=+ImsCtpzuqTiiP6Zu7TpVi4DnkmFZpBn+gOU0R35tPg=; b=sc5OxV1jjOh8AheQDqPkPDB7IHt+xEJlgbadz6pRIWA5xxHF7u+Oc+NlKHvpxV4/CY xWGAuWuOOyUCayuWF9bvgn+K9nb2q29UUKVtxpjaBpC1tbPQhA45QIaUvkQiGc5DH39r Qx8laCQLEf9GnW8PZyWPUBLI59Lw86owxrCyE9Yv2sH6GneA6wxCMEoaCK7tjc1/Iko7 h0dVxMEenAHG2htaXTFkH/mkv4Ax6vBSh1bu+V4pFGWj2pFNQTmDByIx6RupwpIYP01e 7Z8KHWAC5Zb92wiAKR1fLgw8CzPAc9sEnxpCiPPOAe3OV4OLoeOHN/m5LV53WAah0hy+ fX7Q== X-Gm-Message-State: AOAM533NVzlmtKu6/GlcVy/fxBsLOj9VIfDgP/qG3IuXMJL9rlGOCL2l ArOPbEmdITfEjT73+JbHTQo= X-Google-Smtp-Source: ABdhPJz2ayuKILASdCPtoVc1fYkWQmyYSA0OlpiyFTrJHG3/oMlSv8z7XgDtAhknw9aFRw64GjghcQ== X-Received: by 2002:a37:8546:: with SMTP id h67mr16655332qkd.474.1608214021191; Thu, 17 Dec 2020 06:07:01 -0800 (PST) Received: from ?IPv6:2620:10d:c0a8:1102:e0c4:86e9:6418:b0da? ([2620:10d:c091:480::1:c154]) by smtp.googlemail.com with ESMTPSA id r5sm3233730qti.28.2020.12.17.06.06.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Dec 2020 06:06:58 -0800 (PST) To: GCC Patches From: Nathan Sidwell Subject: bootstrap: Don't use strsignal [PR 98300] Message-ID: <708e46d4-2d8b-247f-0120-0548d20b0f25@acm.org> Date: Thu, 17 Dec 2020 09:06:57 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 Content-Language: en-US X-Spam-Status: No, score=-10.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces@gcc.gnu.org Sender: "Gcc-patches" Sadly strsignal is nonportable, so signal numbers it is then. c++tools/ * server.cc (crash_signal): Don't use strsignal. pushing to trunk diff --git i/c++tools/server.cc w/c++tools/server.cc index 6457dc5b878..8514ef6293b 100644 --- i/c++tools/server.cc +++ w/c++tools/server.cc @@ -213,7 +213,8 @@ static void ATTRIBUTE_NORETURN ATTRIBUTE_COLD crash_signal (int sig) { signal (sig, SIG_DFL); - internal_error ("signal %s", strsignal (sig)); + // strsignal is not portable :( + internal_error ("signal %d", sig); } /* A fatal error of some kind. */