From patchwork Tue Nov 27 15:24:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 1003884 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-490992-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="mF6b3aVa"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4346zN1j1pz9rxp for ; Wed, 28 Nov 2018 02:25:03 +1100 (AEDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=YDXi8E3kvOZ672P2ytYCpMLX/Ow4NuMREkUp58iPkcn6/OnzC9 WeHStIqYHFvXIBCs7QtK6y1AiiWcalHeRG4NJWf/pPdcXcBKGDgo5d7KoQLUtVFk MTr5405MUn04Op+D0E46Cl32c3hmD46v4XBiBRixfEgPYqQlqn8W/v/NQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=WCxxoZb0WFwT/JZEhfL+w+Ui+6Q=; b=mF6b3aVaEW7GQMcghC5r 7i3kB+IRMD/5Iyi9VF6KXVoTD2W5//hQ+jO2KwJer77GsLO/abmwuV9GcUveuZ6r EAdpiXjbCmfgMEQf7P0TSlABgb27/pgMx1E8rxy+NN0Jw4B2ZBgUc7Gn3/2KDeQd xjMEi+oYSWyxt1rgA1G3Z50= Received: (qmail 48839 invoked by alias); 27 Nov 2018 15:24:47 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 46954 invoked by uid 89); 27 Nov 2018 15:24:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=microblaze X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Nov 2018 15:24:22 +0000 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CDBAFC0C8B9E for ; Tue, 27 Nov 2018 15:24:20 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-27.rdu2.redhat.com [10.10.112.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3ADCB26354 for ; Tue, 27 Nov 2018 15:24:20 +0000 (UTC) To: gcc-patches From: Jeff Law Subject: [committed] Trivial fix to microblaze port Openpgp: preference=signencrypt Message-ID: <62bf9d37-eb9f-f49a-ce7a-aa9fead0f29d@redhat.com> Date: Tue, 27 Nov 2018 08:24:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 X-IsSubscribed: yes The recent changes to the move_by_pieces API were slightly incomplete. They failed to update the mips and microblaze ports (there may be others, that's what has complained so far). This patch fixes the microblaze port. I've verified we can build it through libgcc. The tester will run a more complete build later today. Committed to the trunk. I'll be fixing the MIPS port momentarily. Jeff * config/microblaze/microblaze.c (microblaze_block_move_straight): Use RETURN_BEGIN in call to move_by_pieces. (microblaze_expand_block_move): Likewise. diff --git a/gcc/config/microblaze/microblaze.c b/gcc/config/microblaze/microblaze.c index 06aa50e2556..6c4a62c3113 100644 --- a/gcc/config/microblaze/microblaze.c +++ b/gcc/config/microblaze/microblaze.c @@ -1180,7 +1180,7 @@ microblaze_block_move_straight (rtx dest, rtx src, HOST_WIDE_INT length) src = adjust_address (src, BLKmode, offset); dest = adjust_address (dest, BLKmode, offset); move_by_pieces (dest, src, length - offset, - MIN (MEM_ALIGN (src), MEM_ALIGN (dest)), 0); + MIN (MEM_ALIGN (src), MEM_ALIGN (dest)), RETURN_BEGIN); } } @@ -1269,7 +1269,7 @@ microblaze_expand_block_move (rtx dest, rtx src, rtx length, rtx align_rtx) { if (INTVAL (length) <= MAX_MOVE_BYTES) { - move_by_pieces (dest, src, bytes, align, 0); + move_by_pieces (dest, src, bytes, align, RETURN_BEGIN); return true; } else