From patchwork Thu Aug 22 15:44:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Matz X-Patchwork-Id: 1975632 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=mXa/Jznn; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hMx0wfpV; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=mXa/Jznn; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=hMx0wfpV; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org (client-ip=2620:52:3:1:0:246e:9693:128c; helo=server2.sourceware.org; envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=patchwork.ozlabs.org) Received: from server2.sourceware.org (server2.sourceware.org [IPv6:2620:52:3:1:0:246e:9693:128c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WqSGV4Lfnz1ybW for ; Fri, 23 Aug 2024 01:45:54 +1000 (AEST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6E97B387543C for ; Thu, 22 Aug 2024 15:45:52 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 9885C3860C08 for ; Thu, 22 Aug 2024 15:44:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9885C3860C08 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9885C3860C08 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724341458; cv=none; b=b217BIhJwo+8ziTrkzuEE5L5tQrem6oQLXGXEqkpbiZ8TDkCuWFtIauR5bkWDKZv30YpMrEMc/G3M3NDQIavadJUw1DPJOrrtC0QFlGA4ri7GPs9h00KDZd6wVFiSl7ZhEgSJeHkl2DqbO85DfXOwpPFBmxNkhxrHR6uJYhvpDE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1724341458; c=relaxed/simple; bh=SQwC3XaswUMG3uYkjjbMiRUq1qIYdVlyQ8/naaSp4FY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=wbSTIQTR8Lg/vLMTgxSCNQG2we6m1b0uN/ndhg7IocT6S82zAYxKvhWTh1f05olzf++us1xkAtcPytJdM27ltqhj5JrxBCU1rStDuVd8Xv2PkJXQ8ced5tHys1BPVAYr01oGRWnqPfNCsdWli2s9z/gugdmuR4q81g05Rn868wk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from knuth.suse.de (unknown [IPv6:2a07:de40:a101:3:9249:faff:fe06:959]) by smtp-out1.suse.de (Postfix) with ESMTP id 5759B222C3 for ; Thu, 22 Aug 2024 15:44:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1724341455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=IkhJ4oL8o+T1X9NkUtl8rKct6kd0q+qz23CdiiFR3Vk=; b=mXa/JznnoyWCMeI+rv8zDwbpomDchbVfKqFiMjpo3utTTDl4W7ARfmMAF/2YKg1upwp6/F e8JghvbPDXohah/VjmZ3ndnzP1gwyimr5zBe12RsGmIGbjC5zc0i2f7EsPcXmezWedEb54 9E0x7XFIFZn53CqCc8muxXKM7CWTayg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1724341455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=IkhJ4oL8o+T1X9NkUtl8rKct6kd0q+qz23CdiiFR3Vk=; b=hMx0wfpVC9v67cvjE42kFp4c/Oo+869sztyHUgnw9drsCh3J+A1JBmH4V5PhaX9oSgaPZu vFNoqLWHMhg9dwDA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="mXa/Jznn"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=hMx0wfpV DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1724341455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=IkhJ4oL8o+T1X9NkUtl8rKct6kd0q+qz23CdiiFR3Vk=; b=mXa/JznnoyWCMeI+rv8zDwbpomDchbVfKqFiMjpo3utTTDl4W7ARfmMAF/2YKg1upwp6/F e8JghvbPDXohah/VjmZ3ndnzP1gwyimr5zBe12RsGmIGbjC5zc0i2f7EsPcXmezWedEb54 9E0x7XFIFZn53CqCc8muxXKM7CWTayg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1724341455; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=IkhJ4oL8o+T1X9NkUtl8rKct6kd0q+qz23CdiiFR3Vk=; b=hMx0wfpVC9v67cvjE42kFp4c/Oo+869sztyHUgnw9drsCh3J+A1JBmH4V5PhaX9oSgaPZu vFNoqLWHMhg9dwDA== Received: by knuth.suse.de (Postfix, from userid 10510) id 43D2D4C591F; Thu, 22 Aug 2024 17:44:15 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by knuth.suse.de (Postfix) with ESMTP id 429E74C591E for ; Thu, 22 Aug 2024 17:44:15 +0200 (CEST) Date: Thu, 22 Aug 2024 17:44:15 +0200 (CEST) From: Michael Matz To: gcc-patches@gcc.gnu.org Subject: final: go down ASHIFT in walk_alter_subreg Message-ID: <5afdf2da-8e44-bc4d-8654-796a9f8b9ee5@suse.de> MIME-Version: 1.0 X-Spamd-Result: default: False [1.39 / 50.00]; BAYES_HAM(-3.00)[99.99%]; HFILTER_HOSTNAME_UNKNOWN(2.50)[]; RDNS_NONE(2.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; HFILTER_HELO_IP_A(1.00)[knuth.suse.de]; HFILTER_HELO_NORES_A_OR_MX(0.30)[knuth.suse.de]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; RCVD_NO_TLS_LAST(0.10)[]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; URIBL_BLOCKED(0.00)[knuth.suse.de:helo,suse.de:mid,suse.de:dkim]; RECEIVED_HELO_LOCALHOST(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_ONE(0.00)[1]; ARC_NA(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; MISSING_XM_UA(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_DN_NONE(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gcc-patches@gcc.gnu.org]; DWL_DNSWL_BLOCKED(0.00)[suse.de:dkim]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim] X-Spam-Score: 1.39 X-Rspamd-Queue-Id: 5759B222C3 X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Bar: + X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org when experimenting with m68k plus LRA one of the changes in the backend is to accept ASHIFTs (not only MULT) as scale code for address indices. When then not turning on LRA but using reload those addresses are presented to it which chokes on them. While reload is going away the change to make them work doesn't really hurt (and generally seems useful, as MULT and ASHIFT really are no different). So just add it. PR target/116413 * final.cc (walk_alter_subreg): Recurse on AHIFT. --- gcc/final.cc | 1 + 1 file changed, 1 insertion(+) --- Regstrapped on x86-64-linux. Okay? diff --git a/gcc/final.cc b/gcc/final.cc index eb9e065d9f0..5d911586de5 100644 --- a/gcc/final.cc +++ b/gcc/final.cc @@ -3146,6 +3146,7 @@ walk_alter_subreg (rtx *xp, bool *changed) case PLUS: case MULT: case AND: + case ASHIFT: XEXP (x, 0) = walk_alter_subreg (&XEXP (x, 0), changed); XEXP (x, 1) = walk_alter_subreg (&XEXP (x, 1), changed); break;