From patchwork Wed Jan 25 10:12:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyrill Tkachov X-Patchwork-Id: 719623 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3v7gpS4Mxyz9srY for ; Wed, 25 Jan 2017 21:12:32 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="wZMgz5uQ"; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; q=dns; s=default; b=bsH02PNEZl0R7k82f pAl5YpBNt1c7uey+2sDpQFunmLao2wcW7Ijwc7YG/NrAIY6FSdsdhhqqGoaHJPrW tXwtpn63oIDI2XZ+ndTNQQ4K4UaVAS624eC5TYHlHZAULh/xXhXSq6B0pe6fJ0bP 3HpdvF9in0ISKHcUbE5jltQoOQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; s=default; bh=mgPhynvId1ZhdTpXSdAXV8N GiCs=; b=wZMgz5uQS1Ax8DeYAxDQT6jGUlel1cbEywdUY9ACxzCkOZQlI/KPr4D b3ZGgkYULY3OTPY1cC56SL7wRRs6bEOZ/SgpVtY3oGwUdBsjzWDbNJACq5gi97zw /pveQh84Rt5A0CQuotVRdYRxqnrt9p0kQKGMJID07In+095bO0N4= Received: (qmail 60457 invoked by alias); 25 Jan 2017 10:12:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 60437 invoked by uid 89); 25 Jan 2017 10:12:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 Jan 2017 10:12:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9FC3F707; Wed, 25 Jan 2017 02:12:08 -0800 (PST) Received: from [10.2.207.77] (e100706-lin.cambridge.arm.com [10.2.207.77]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D380A3F242; Wed, 25 Jan 2017 02:12:07 -0800 (PST) Message-ID: <588879F6.2010905@foss.arm.com> Date: Wed, 25 Jan 2017 10:12:06 +0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Jeff Law , GCC Patches CC: Sandra Loosemore , "gerald@pfeifer.com" Subject: Re: [PATCH][doc] Correct optimisation levels documentation for -fstore-merging References: <58863D28.6070906@foss.arm.com> <758d0cb6-e182-c303-0b6a-107958560a49@redhat.com> In-Reply-To: <758d0cb6-e182-c303-0b6a-107958560a49@redhat.com> On 23/01/17 23:39, Jeff Law wrote: > On 01/23/2017 10:28 AM, Kyrill Tkachov wrote: >> Hi all, >> >> I had forgotten to update the -fstore-merging documentation from a >> previous iteration of the pass >> and it says that it's enabled at -O and higher. The option is in fact >> enabled at -O2 and higher, as well as -Os. >> This patch clarifies that. >> >> Is this ok? Or is there a more preferred style of listing optimisation >> levels? >> >> Thanks, >> Kyrill >> >> 2016-01-23 Kyrylo Tkachov >> >> * doc/invoke.texi (-fstore-merging): Correct default optimization >> levels at which it is enabled. > I think you also need to remove -fstore-merging from list of options turned on by -O: > > @option{-O} turns on the following optimization flags: > [ ... ] > -fstore-merging @gol > > > And instead add it to the list of options enabled at -O2 and higher which immediately follows. > > OK with those changes. Thanks Jeff, Sandra. I've done that. Committing this version to trunk. Kyrill 2016-01-25 Kyrylo Tkachov * doc/invoke.texi (-fstore-merging): Correct default optimization levels at which it is enabled. (-O): Move -fstore-merging from list to... (-O2): ... Here. > > jeff diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 45af80c..59ab394 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -7012,7 +7012,6 @@ compilation time. -fsplit-wide-types @gol -fssa-backprop @gol -fssa-phiopt @gol --fstore-merging @gol -ftree-bit-ccp @gol -ftree-ccp @gol -ftree-ch @gol @@ -7072,6 +7071,7 @@ also turns on the following optimization flags: -frerun-cse-after-loop @gol -fsched-interblock -fsched-spec @gol -fschedule-insns -fschedule-insns2 @gol +-fstore-merging @gol -fstrict-aliasing -fstrict-overflow @gol -ftree-builtin-call-dce @gol -ftree-switch-conversion -ftree-tail-merge @gol @@ -8342,7 +8342,7 @@ early. This flag is enabled by default at @option{-O} and higher. Perform merging of narrow stores to consecutive memory addresses. This pass merges contiguous stores of immediate values narrower than a word into fewer wider stores to reduce the number of instructions. This is enabled by default -at @option{-O} and higher. +at @option{-O2} and higher as well as @option{-Os}. @item -ftree-ter @opindex ftree-ter