diff mbox

[ARM] Fix testism with pure-code tests for non Cortex-M targets

Message ID 5800965D.6090302@arm.com
State New
Headers show

Commit Message

Andre Vieira (lists) Oct. 14, 2016, 8:25 a.m. UTC
Hi there,

This patch makes sure the pure-code tests only run for Cortex-M targets.
I was hoping '![check_effective_target_arm_arm_ok]' would do the trick
but it seems the options passed with RUNTESTFLAGS take precedence over
the one in the check. Anyhow, I now use 'check_effective_target_cortex_m'.

Is this OK for trunk?

Ran these tests for a ARMv7-A.

Cheers,
Andre


gcc/testsuite/ChangeLog:
2016-10-14  Andre Vieira  <andre.simoesdiasvieira@arm.com>

  *  gcc.target/arm/pure-code/pure-code.exp: Adjust targets to test for.

Comments

Kyrill Tkachov Oct. 20, 2016, 9:46 a.m. UTC | #1
Hi Andre,

On 14/10/16 09:25, Andre Vieira (lists) wrote:
> Hi there,
>
> This patch makes sure the pure-code tests only run for Cortex-M targets.
> I was hoping '![check_effective_target_arm_arm_ok]' would do the trick
> but it seems the options passed with RUNTESTFLAGS take precedence over
> the one in the check. Anyhow, I now use 'check_effective_target_cortex_m'.
>
> Is this OK for trunk?
> Ran these tests for a ARMv7-A.
>
> Cheers,
> Andre
>
>
> gcc/testsuite/ChangeLog:
> 2016-10-14  Andre Vieira  <andre.simoesdiasvieira@arm.com>
>
>    *  gcc.target/arm/pure-code/pure-code.exp: Adjust targets to test for.
Your ChangeLog entry seems truncated.

Ok with a proper ChangeLog entry.
Thanks,
Kyrill
Kyrill Tkachov Oct. 20, 2016, 10:02 a.m. UTC | #2
On 20/10/16 10:46, Kyrill Tkachov wrote:
> Hi Andre,
>
> On 14/10/16 09:25, Andre Vieira (lists) wrote:
>> Hi there,
>>
>> This patch makes sure the pure-code tests only run for Cortex-M targets.
>> I was hoping '![check_effective_target_arm_arm_ok]' would do the trick
>> but it seems the options passed with RUNTESTFLAGS take precedence over
>> the one in the check. Anyhow, I now use 'check_effective_target_cortex_m'.
>>
>> Is this OK for trunk?
>> Ran these tests for a ARMv7-A.
>>
>> Cheers,
>> Andre
>>
>>
>> gcc/testsuite/ChangeLog:
>> 2016-10-14  Andre Vieira  <andre.simoesdiasvieira@arm.com>
>>
>>    *  gcc.target/arm/pure-code/pure-code.exp: Adjust targets to test for.
> Your ChangeLog entry seems truncated.

Oh, I see what you're saying here.
I think it would be more descriptive to say
"Require arm_cortex_m effective target."

Kyrill

>
> Ok with a proper ChangeLog entry.
> Thanks,
> Kyrill
>
diff mbox

Patch

From a5f9063dd8e3c6405c40a7e99d0bf322dc6d58a9 Mon Sep 17 00:00:00 2001
From: Andre Simoes Dias Vieira <andre.simoesdiasvieira@arm.com>
Date: Mon, 10 Oct 2016 15:32:44 +0100
Subject: [PATCH] Fix testism for non Cortex-M targets

---
 gcc/testsuite/gcc.target/arm/pure-code/pure-code.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/testsuite/gcc.target/arm/pure-code/pure-code.exp b/gcc/testsuite/gcc.target/arm/pure-code/pure-code.exp
index 1abe7782c0e5dbb6e2deef25f4bea9415664f942..aaace952aaa09d6bcfb684909adc325c50d9be0e 100644
--- a/gcc/testsuite/gcc.target/arm/pure-code/pure-code.exp
+++ b/gcc/testsuite/gcc.target/arm/pure-code/pure-code.exp
@@ -28,7 +28,7 @@  if ![info exists DEFAULT_CFLAGS] then {
 # The -mpure-code option is only available for M-profile targets that support
 # thumb2.
 if {[check_effective_target_arm_thumb2_ok]
-    && ![check_effective_target_arm_arm_ok]} then {
+    && [check_effective_target_arm_cortex_m]} then {
 # Initialize `dg'.
 dg-init
 
-- 
1.9.1