| Message ID | 57D00F32.9010801@foss.arm.com |
|---|---|
| State | New |
| Headers | show |
On 09/07/2016 06:59 AM, Kyrill Tkachov wrote: > Hi all, > > The duplicate mode check in synth can just be deleted IMO. It was > introduced as part of r139821 that was > a much larger change introducing size/speed differentiation to the RTL > midend. So I think it's just a typo/copy-pasto. > > Tested on aarch64-none-elf. > Ok? > > Thanks, > Kyrill > > 2016-09-07 Kyrylo Tkachov <kyrylo.tkachov@arm.com> > > PR middle-end/77426 > * expmed.c (synth_mult): Delete duplicate mode check. OK. jeff
diff --git a/gcc/expmed.c b/gcc/expmed.c index 1cedf023c8e8916d887bd3a9d9a723e3cc2354f7..a5da8836f21debcda3b834cb869348ea6cb33414 100644 --- a/gcc/expmed.c +++ b/gcc/expmed.c @@ -2572,7 +2572,6 @@ synth_mult (struct algorithm *alg_out, unsigned HOST_WIDE_INT t, entry_ptr = alg_hash_entry_ptr (hash_index); if (entry_ptr->t == t && entry_ptr->mode == mode - && entry_ptr->mode == mode && entry_ptr->speed == speed && entry_ptr->alg != alg_unknown) {
Hi all, The duplicate mode check in synth can just be deleted IMO. It was introduced as part of r139821 that was a much larger change introducing size/speed differentiation to the RTL midend. So I think it's just a typo/copy-pasto. Tested on aarch64-none-elf. Ok? Thanks, Kyrill 2016-09-07 Kyrylo Tkachov <kyrylo.tkachov@arm.com> PR middle-end/77426 * expmed.c (synth_mult): Delete duplicate mode check.