From patchwork Wed Mar 23 17:34:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 601305 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3qVcC24kMSz9s1h for ; Thu, 24 Mar 2016 04:34:52 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=bf6vFSDn; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=Ew1rbwYN55Zj5yRUwbx/+CNwS7jWM87b/Hve02695SCQYWv6CW hDeDc9jIRksJVWPe21+SnP1LFmb7vd6nDe00PZmvJLdeDPXai5he0B6VXm12jzrN gE1JOFYREbUhHjD++UV0F+0vti4BXbC8o5w4EGWM+XE4dutSHP4xz5hy4= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:message-id:date:mime-version:content-type; s= default; bh=eeT9mXmTKLgwje0fZWiNaulVZJY=; b=bf6vFSDnqha9TxuVYi3O pO5eNJyJS7OvVK1t2mJKxkXa55LmLRbex+l4hr+9fVv+/ZcP/lMFUSbMj9wqRUgD tA9k5j6cvZeWBLeq81YMi2+Z1n1+ig70NGTUWZL0e6+EMoXQe2elCguhqtHcAYmz Ns9O94c9S/Okq2/Yu9nvSlw= Received: (qmail 113938 invoked by alias); 23 Mar 2016 17:34:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 113922 invoked by uid 89); 23 Mar 2016 17:34:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=928, 47, 57, gang X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 23 Mar 2016 17:34:32 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1aimfu-0005em-9X from Tom_deVries@mentor.com for gcc-patches@gcc.gnu.org; Wed, 23 Mar 2016 10:34:30 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Wed, 23 Mar 2016 17:34:28 +0000 To: GCC Patches CC: Thomas Schwinge From: Tom de Vries Subject: [committed, testsuite] Add missing initializations in oacc testcases Message-ID: <56F2D39F.6040304@mentor.com> Date: Wed, 23 Mar 2016 18:34:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 Hi, I've run: - the goacc.exp testcases, and - the target-libgomp oacc testcases with -Wuninitialized, and found a few missing initalizations. Fixed and committed as attached. Thanks, - Tom Add missing initializations in oacc testcases 2016-03-23 Tom de Vries * c-c++-common/goacc/kernels-default.c (foo): Add missing initialization. * gfortran.dg/goacc/private-3.f95 (test): Same. * gfortran.dg/goacc/routine-5.f90 (gang, worker, vector, seq): Add missing use param. * testsuite/libgomp.oacc-fortran/reduction-2.f90: Add missing initialization of lresult and lvresult. * testsuite/libgomp.oacc-fortran/reduction-3.f90: Same. --- gcc/testsuite/c-c++-common/goacc/kernels-default.c | 2 +- gcc/testsuite/gfortran.dg/goacc/private-3.f95 | 1 + gcc/testsuite/gfortran.dg/goacc/routine-5.f90 | 4 ++++ libgomp/testsuite/libgomp.oacc-fortran/reduction-2.f90 | 4 ++-- libgomp/testsuite/libgomp.oacc-fortran/reduction-3.f90 | 4 ++-- 5 files changed, 10 insertions(+), 5 deletions(-) diff --git a/gcc/testsuite/c-c++-common/goacc/kernels-default.c b/gcc/testsuite/c-c++-common/goacc/kernels-default.c index 58cd5e1..cb031c1 100644 --- a/gcc/testsuite/c-c++-common/goacc/kernels-default.c +++ b/gcc/testsuite/c-c++-common/goacc/kernels-default.c @@ -4,7 +4,7 @@ void foo (void) { - unsigned int i; + unsigned int i = 0; #pragma acc kernels { i++; diff --git a/gcc/testsuite/gfortran.dg/goacc/private-3.f95 b/gcc/testsuite/gfortran.dg/goacc/private-3.f95 index 3490263..a7c6d81 100644 --- a/gcc/testsuite/gfortran.dg/goacc/private-3.f95 +++ b/gcc/testsuite/gfortran.dg/goacc/private-3.f95 @@ -14,6 +14,7 @@ program test ! !$acc end parallel !$acc parallel private (k) + k = 0 !$acc loop reduction (+:k) do i = 1, n k = k + 1 diff --git a/gcc/testsuite/gfortran.dg/goacc/routine-5.f90 b/gcc/testsuite/gfortran.dg/goacc/routine-5.f90 index 68c5149..5037a31 100644 --- a/gcc/testsuite/gfortran.dg/goacc/routine-5.f90 +++ b/gcc/testsuite/gfortran.dg/goacc/routine-5.f90 @@ -5,6 +5,7 @@ module param end module param subroutine gang (a) + use param !$acc routine gang integer, intent (inout) :: a(N) integer :: i @@ -31,6 +32,7 @@ subroutine gang (a) end subroutine gang subroutine worker (a) + use param !$acc routine worker integer, intent (inout) :: a(N) integer :: i @@ -57,6 +59,7 @@ subroutine worker (a) end subroutine worker subroutine vector (a) + use param !$acc routine vector integer, intent (inout) :: a(N) integer :: i @@ -83,6 +86,7 @@ subroutine vector (a) end subroutine vector subroutine seq (a) + use param !$acc routine seq integer, intent (inout) :: a(N) integer :: i diff --git a/libgomp/testsuite/libgomp.oacc-fortran/reduction-2.f90 b/libgomp/testsuite/libgomp.oacc-fortran/reduction-2.f90 index 3d99668..96955ce 100644 --- a/libgomp/testsuite/libgomp.oacc-fortran/reduction-2.f90 +++ b/libgomp/testsuite/libgomp.oacc-fortran/reduction-2.f90 @@ -92,8 +92,8 @@ program reduction_2 if (result.ne.vresult) call abort - result = 1 - vresult = 1 + lresult = .true. + lvresult = .true. ! '.and.' reductions diff --git a/libgomp/testsuite/libgomp.oacc-fortran/reduction-3.f90 b/libgomp/testsuite/libgomp.oacc-fortran/reduction-3.f90 index d0b590e..ecf7fbe 100644 --- a/libgomp/testsuite/libgomp.oacc-fortran/reduction-3.f90 +++ b/libgomp/testsuite/libgomp.oacc-fortran/reduction-3.f90 @@ -92,8 +92,8 @@ program reduction_3 if (result.ne.vresult) call abort - result = 1 - vresult = 1 + lresult = .true. + lvresult = .true. ! '.and.' reductions