diff mbox

[AArch64] Fix gcc.target/aarch64/vect-reduc-or_1.c for -mcpu=cortex-a57

Message ID 56E2E21A.4010006@foss.arm.com
State New
Headers show

Commit Message

Kyrill Tkachov March 11, 2016, 3:19 p.m. UTC
Hi all,

I've been seeing this test FAIL for a toolchain configured with --with-cpu=cortex-a57 in the
scan vectoriser dump check because the cost model for -mtune=cortex-a57 decides not to vectorise.

This patch disables the vectoriser cost model and makes this test pass on all
configurations. I think this test is supposed to test the capabilities of the vectoriser
rather than the cost model decisions (we'd have to add a specific -mtune option otherwise)

Ok for trunk?

Thanks,
Kyrill

2016-03-11  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

     * gcc.target/aarch64/vect-reduc-or_1.c: Add -fno-vect-cost-model to
     dg-options.

Comments

James Greenhalgh March 11, 2016, 3:34 p.m. UTC | #1
On Fri, Mar 11, 2016 at 03:19:54PM +0000, Kyrill Tkachov wrote:
> Hi all,
> 
> I've been seeing this test FAIL for a toolchain configured with
> --with-cpu=cortex-a57 in the scan vectoriser dump check because the cost
> model for -mtune=cortex-a57 decides not to vectorise.
> 
> This patch disables the vectoriser cost model and makes this test pass on all
> configurations. I think this test is supposed to test the capabilities of the
> vectoriser rather than the cost model decisions (we'd have to add a specific
> -mtune option otherwise)
> 
> Ok for trunk?

Looks like the obvious fix to the problem you describe.

OK.

Thanks,
James

> 2016-03-11  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
> 
>     * gcc.target/aarch64/vect-reduc-or_1.c: Add -fno-vect-cost-model to
>     dg-options.
diff mbox

Patch

diff --git a/gcc/testsuite/gcc.target/aarch64/vect-reduc-or_1.c b/gcc/testsuite/gcc.target/aarch64/vect-reduc-or_1.c
index cfb1231d69bbabac3da931cee2fd3fd786a29305..6261e9d1ea6fa8949d392543e08b880477a1ed5d 100644
--- a/gcc/testsuite/gcc.target/aarch64/vect-reduc-or_1.c
+++ b/gcc/testsuite/gcc.target/aarch64/vect-reduc-or_1.c
@@ -1,5 +1,5 @@ 
 /* { dg-do run } */
-/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-all" } */
+/* { dg-options "-O2 -ftree-vectorize -fdump-tree-vect-all -fno-vect-cost-model" } */
 /* Write a reduction loop to be reduced using whole vector right shift.  */
 
 extern void abort (void);