From patchwork Mon Feb 8 08:42:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 580172 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id ADB9F14032A for ; Mon, 8 Feb 2016 19:42:41 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=w7vHivVp; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=w/5pm4WnJwQkp9bpHC5jwjsqloKqS3K8HUddx5lm/vzEP05q8s 5zoGgHogRU1N9849f48/3DEnlryyDDCXkRxpRSJ4696n5RtEr794b7ePGh8mflJX cuGVbyhkMdEFECqiHLMJuv4W6TVgo8W9HCUvxFsLyCTdA6AgKvjYPNL1E= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=2meUNQPM7Ajzw4I9m8nL9z5JD/E=; b=w7vHivVplSLCbRdwYe4b weUhEcBC1aK864t9d8IUTmuvKNVKhX3qVDqCZlAqETizO98o4NCaENwwhslcpaqS o918YjxOvkMdUXdCUaCqvaxIhqxcgiK6MBhNmsc5lrH+RTGGSYj5r3UGaicbIp9h aEvofAoJxmxf3mC2wTogUBc= Received: (qmail 7341 invoked by alias); 8 Feb 2016 08:42:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 7322 invoked by uid 89); 8 Feb 2016 08:42:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 08 Feb 2016 08:42:34 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 2C6248F4F4 for ; Mon, 8 Feb 2016 08:42:33 +0000 (UTC) Received: from slagheap.utah.redhat.com (ovpn-113-84.phx2.redhat.com [10.3.113.84]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u188gWAg024239 for ; Mon, 8 Feb 2016 03:42:33 -0500 To: gcc-patches@gcc.gnu.org From: Jeff Law Subject: [PATCH] Fix split-path-2.c on targets with unsigned characters by default Message-ID: <56B854F8.90309@redhat.com> Date: Mon, 8 Feb 2016 01:42:32 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 X-IsSubscribed: yes Andreas pointed out the test was failing on aarch64. It turns out it's got to be failing on all targets where characters are unsigned by default as the test assumes characters are signed by default. Opps. The fix is pretty obvious. Just make the array of chars be signed chars. Installed after verifying x86-linux still passes and hand verification of aarch64 as well. Sorry for the breakage. jeff commit b32ded8cd0158d88155116bde4685a36c4802878 Author: law Date: Mon Feb 8 08:40:00 2016 +0000 PR tree-optimization/68541 * gcc.dg/tree-ssa/split-path-2.c: Make char array explicitly signed. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@233208 138bc75d-0d04-0410-961f-82ee72b054a4 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 6940136..6aa927d 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,5 +1,8 @@ 2016-02-08 Jeff Law + PR tree-optimization/68541 + * gcc.dg/tree-ssa/split-path-2.c: Make char array explicitly signed. + PR tree-optimization/65917 * gcc.dg/tree-ssa/20030922-2.c: No longer xfailed. diff --git a/gcc/testsuite/gcc.dg/tree-ssa/split-path-2.c b/gcc/testsuite/gcc.dg/tree-ssa/split-path-2.c index aeb926e..8f503f2 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/split-path-2.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/split-path-2.c @@ -2,7 +2,7 @@ /* { dg-options "-O2 -fsplit-paths -fdump-tree-split-paths-details " } */ int -foo(char *p, int n) +foo(signed char *p, int n) { int s = 0; int i;