From patchwork Tue Jan 26 12:47:57 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Bruel X-Patchwork-Id: 573234 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id B97AD140B04 for ; Tue, 26 Jan 2016 23:48:18 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=S0A2bUvm; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=OoMGnkREMaMbL3mt1nlM++o9Z+cayMHAzQdGqTSSrZThhUlc7W vYSVdNUaDzwCKmQDzt6Og/wGO9vAvxmqRLAhGRWGr0Z9Bn0yrm3hb67XBZAj7jH9 wklasZEDn7B5sPzRAjNVpal50285DbV+Hx0eMLdAX/TUj5Yvxl31Jwj4k= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:message-id:date:mime-version:content-type; s= default; bh=bKUlY565YaN+GCEgA/sG7otsYoQ=; b=S0A2bUvm+oe4rhD9sWWR yT2apQI3Y5hvC7/kX+ryeBdu4fJeGHf6nb0cPaHCPknD9dH3DmmYAXzkCmDUw/ud kv+2W7pS1lyjkGSwax7h7lOYfjEl0TNrAXRQwrfZ1FY/pDC2KEKokbdpZOKQv+A6 rEWhwiS067aeUUk5bedLZo0= Received: (qmail 118654 invoked by alias); 26 Jan 2016 12:48:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 118603 invoked by uid 89); 26 Jan 2016 12:48:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=BAYES_00, KAM_ASCII_DIVIDERS, KAM_LAZY_DOMAIN_SECURITY, KHOP_DYNAMIC, RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=UD:target-supports.exp, Hx-languages-length:4245, adheres X-HELO: mx07-00178001.pphosted.com Received: from mx07-00178001.pphosted.com (HELO mx07-00178001.pphosted.com) (62.209.51.94) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 26 Jan 2016 12:48:07 +0000 Received: from pps.filterd (m0046037.ppops.net [127.0.0.1]) by m0046037.ppops.net (8.15.0.59/8.15.0.59) with SMTP id u0QCkjfu001232; Tue, 26 Jan 2016 13:48:00 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by m0046037.ppops.net with ESMTP id 20p29kj5un-1 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 26 Jan 2016 13:48:00 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id D419131; Tue, 26 Jan 2016 12:47:09 +0000 (GMT) Received: from Webmail-eu.st.com (safex1hubcas4.st.com [10.75.90.69]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 9DA65145F; Tue, 26 Jan 2016 12:47:58 +0000 (GMT) Received: from [164.129.122.197] (164.129.122.197) by webmail-eu.st.com (10.75.90.13) with Microsoft SMTP Server (TLS) id 8.3.389.2; Tue, 26 Jan 2016 13:47:58 +0100 To: , CC: From: Christian Bruel Subject: [PATCH, ARM testsuite] Committed: Remove arm_crypto_pragma selector X-No-Archive: yes Message-ID: <56A76AFD.6070301@st.com> Date: Tue, 26 Jan 2016 13:47:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-01-26_05:, , signatures=0 X-IsSubscribed: yes The arm_crypto_selector_ok has become obsoleted by the recent fixes in #pragma GCC target preprocessor macros. Removed it as obvious, as discussed on IRC. Index: gcc/ChangeLog 2016-01-26 Christian Bruel * doc/sourcebuild.texi (arm_crypto_pragma_ok): Remove. 2016-01-26 Christian Bruel * lib/target-supports.exp (check_effective_target_arm_crypto_pragma_ok_nocache): Remove. (check_effective_target_arm_crypto_pragma_ok): Likewise. Index: gcc/doc/sourcebuild.texi =================================================================== --- gcc/doc/sourcebuild.texi (revision 232818) +++ gcc/doc/sourcebuild.texi (working copy) @@ -1511,12 +1511,6 @@ Target generates decimal floating point instructio @item arm32 ARM target generates 32-bit code. -@item arm_crypto_pragma_ok -@anchor{arm_crypto_pragma_ok} -ARM target supports pragma target @code{fpu=crypto-neon-fp-armv8}. -This may need @code{-mfpu=crypto-neon-fp-armv8} or equivalent options. -Some multilibs may be incompatible with these options. - @item arm_eabi ARM target adheres to the ABI for the ARM Architecture. @@ -2059,12 +2053,6 @@ The supported values of @var{feature} for directiv are: @table @code -@item arm_crypto_pragma -Crypto extension pragma support. Only ARM targets support this -feature, and only then in certain modes; see the -@ref{arm_crypto_pragma_ok,,arm_crypto_pragma_ok effective target -keyword}. - @item arm_fp @code{__ARM_FP} definition. Only ARM targets support this feature, and only then in certain modes; see the @ref{arm_fp_ok,,arm_fp_ok effective target Index: gcc/testsuite/gcc.target/arm/attr-crypto.c =================================================================== --- gcc/testsuite/gcc.target/arm/attr-crypto.c (revision 232818) +++ gcc/testsuite/gcc.target/arm/attr-crypto.c (working copy) @@ -2,7 +2,6 @@ /* Make sure we can force fpu=vfp before switching using the pragma. */ /* { dg-require-effective-target arm_fp_ok } */ -/* { dg-require-effective-target arm_crypto_pragma_ok } */ /* { dg-options "-O2 -march=armv8-a" } */ /* { dg-add-options arm_fp } */ Index: gcc/testsuite/lib/target-supports.exp =================================================================== --- gcc/testsuite/lib/target-supports.exp (revision 232818) +++ gcc/testsuite/lib/target-supports.exp (working copy) @@ -2852,52 +2852,6 @@ proc add_options_for_arm_crypto { flags } { return "$flags $et_arm_crypto_flags" } -# Return 1 if this is an ARM target supporting pragma target -# fpu=crypto-neon-fp-armv8, possibly needing -mfloat-abi=softfp or -# equivalent options. Some multilibs may be incompatible with these -# options. Also set et_arm_crypto_pragma_flags to the best options to -# add. - -proc check_effective_target_arm_crypto_pragma_ok_nocache { } { - global et_arm_crypto_pragma_flags - set et_arm_crypto_pragma_flags "" - if { [check_effective_target_arm_v8_neon_ok] } { - foreach flags {"" "-mfloat-abi=softfp" "-mfpu=crypto-neon-fp-armv8" "-mfpu=crypto-neon-fp-armv8 -mfloat-abi=softfp"} { - if { [check_no_compiler_messages_nocache arm_crypto_pragmaok object { - #pragma GCC target ("fpu=crypto-neon-fp-armv8") - #include "arm_neon.h" - uint8x16_t - foo (uint8x16_t a, uint8x16_t b) - { - return vaeseq_u8 (a, b); - } - } "[add_options_for_arm_v8_neon ""] $flags"] } { - set et_arm_crypto_pragma_flags "[add_options_for_arm_v8_neon ""] $flags" - return 1 - } - } - } - - return 0 -} - -# Return 1 if this is an ARM target supporting pragma target -# -mfpu=crypto-neon-fp-armv8. - -proc check_effective_target_arm_crypto_pragma_ok { } { - return [check_cached_effective_target arm_crypto_pragma_ok \ - check_effective_target_arm_crypto_pragma_ok_nocache] -} - -# Add options for crypto extensions pragma. -proc add_options_for_arm_crypto_pragma { flags } { - if { ! [check_effective_target_arm_crypto_pragma_ok] } { - return "$flags" - } - global et_arm_crypto_pragma_flags - return "$flags $et_arm_crypto_pragma_flags" -} - # Add the options needed for NEON. We need either -mfloat-abi=softfp # or -mfloat-abi=hard, but if one is already specified by the # multilib, use it. Similarly, if a -mfpu option already enables