From patchwork Thu Nov 5 11:29:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom de Vries X-Patchwork-Id: 540361 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 1F0721401B5 for ; Thu, 5 Nov 2015 22:30:15 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b=E+PVL6ax; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; q=dns; s=default; b=E9tL7rEodEAlX/24G ZS7Vaafq6U2a7k3yok4dX3EgqZ6IxOdtPr4Yv9MUDFQGuq6nQq8u4Jz6kRI7Y41h 3Lu3v9uzV/07wOHOKPZJLfJZwePx+rdaOTCw5A0dteEw9XaccLyH9rboYsoza2hb ZYR6gVTgG/4TlnPm7fLzHADFwE= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; s=default; bh=FA9UIDmMZZ23QsXsunNnICq Uw2U=; b=E+PVL6axeCs0FLpHr9RSTOr1k1FejiqZ06S6xUWMvOTzog16yNVcpps SfwYmFQTCyfac2kxCBsW0WwlAVLirznNhP/sVD0xOFBI3mgqhtVwtqiGkSYTBeHc Hgs0nOViHpAfPQchuWxPX5iG/BYNZEZub4DDCYHLPzOht8fKi5nw= Received: (qmail 125561 invoked by alias); 5 Nov 2015 11:30:07 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 125544 invoked by uid 89); 5 Nov 2015 11:30:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL, BAYES_00, SPF_PASS, T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: fencepost.gnu.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (208.118.235.10) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 05 Nov 2015 11:30:05 +0000 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58051) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ZuIjz-0001Bt-9J for gcc-patches@gnu.org; Thu, 05 Nov 2015 06:30:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZuIjv-00042S-Jb for gcc-patches@gnu.org; Thu, 05 Nov 2015 06:30:02 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:44935) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZuIjv-00042O-Dl for gcc-patches@gnu.org; Thu, 05 Nov 2015 06:29:59 -0500 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZuIju-0005FY-OH from Tom_deVries@mentor.com ; Thu, 05 Nov 2015 03:29:59 -0800 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Thu, 5 Nov 2015 11:29:57 +0000 Subject: [gomp4, committed, 9/9] Remove BUILT_IN_GOACC_KERNELS_INTERNAL To: "gcc-patches@gnu.org" References: <563B2C99.90308@mentor.com> CC: Jakub Jelinek From: Tom de Vries Message-ID: <563B3DA5.6050605@mentor.com> Date: Thu, 5 Nov 2015 12:29:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <563B2C99.90308@mentor.com> X-detected-operating-system: by eggs.gnu.org: Windows NT kernel [generic] [fuzzy] X-Received-From: 192.94.38.131 On 05/11/15 11:16, Tom de Vries wrote: > Hi, > > now that we have committed -foffload-alias in gomp-4_0-branch ( > https://gcc.gnu.org/ml/gcc-patches/2015-11/msg00214.html ), we no longer > need the kernels region to be a part of the original function when doing > alias analysis. > > So, we no longer have the need to postpone splitting off the kernels > region into a seperate function until after alias analysis, but we can > do this at the same time as when we expand the parallel region. > > The following patch series implements that: > > 1 Move expansion of kernels region back to first omp-expand > 2 Update gate_oacc_kernels to handle oacc function > 3 Revert "Add skip_stmt parm to pass_dominator::get_sese ()" > 4 Revert "Add pass_dominator::sese_mode_p ()" > 5 Handle oacc function in parloops > 6 Update goacc kernels C testcases > 7 Update goacc kernels Fortran testcases > 8 Release_defs in expand_omp_atomic_fetch_op > 9 Remove BUILT_IN_GOACC_KERNELS_INTERNAL > > [ The patch series is broken up into logical bits, but intended as > single commit. Various things in kernels support will be broken in > intermediate stages. ] > > Committed to gomp-4_0-branch. > > I'll post the patches in reply to this message. This patch removes the no longer needed BUILT_IN_GOACC_KERNELS_INTERNAL builtin. Thanks, - Tom Remove BUILT_IN_GOACC_KERNELS_INTERNAL 2015-11-04 Tom de Vries * omp-builtins.def (BUILT_IN_GOACC_KERNELS_INTERNAL): Remove DEF_GOACC_BUILTIN_FNSPEC. * omp-low.c (expand_omp_target): Remove handling of BUILT_IN_GOACC_KERNELS_INTERNAL. --- gcc/omp-builtins.def | 5 ----- gcc/omp-low.c | 1 - 2 files changed, 6 deletions(-) diff --git a/gcc/omp-builtins.def b/gcc/omp-builtins.def index 0478eaf..6908f94 100644 --- a/gcc/omp-builtins.def +++ b/gcc/omp-builtins.def @@ -43,11 +43,6 @@ DEF_GOACC_BUILTIN_FNSPEC (BUILT_IN_GOACC_ENTER_EXIT_DATA, BT_FN_VOID_INT_SIZE_PTR_PTR_PTR_INT_INT_VAR, ATTR_FNSPEC_DOT_DOT_DOT_r_r_r_NOTHROW_LIST, ATTR_NOTHROW_LIST, "...rrr") -DEF_GOACC_BUILTIN_FNSPEC (BUILT_IN_GOACC_KERNELS_INTERNAL, - "GOACC_kernels_internal", - BT_FN_VOID_INT_OMPFN_SIZE_PTR_PTR_PTR_VAR, - ATTR_FNSPEC_DOT_DOT_DOT_r_r_r_NOTHROW_LIST, - ATTR_NOTHROW_LIST, "...rrr") DEF_GOACC_BUILTIN (BUILT_IN_GOACC_PARALLEL, "GOACC_parallel_keyed", BT_FN_VOID_INT_OMPFN_SIZE_PTR_PTR_PTR_VAR, ATTR_NOTHROW_LIST) diff --git a/gcc/omp-low.c b/gcc/omp-low.c index 84accd9..643d017 100644 --- a/gcc/omp-low.c +++ b/gcc/omp-low.c @@ -12994,7 +12994,6 @@ expand_omp_target (struct omp_region *region) depend = build_int_cst (ptr_type_node, 0); args.quick_push (depend); break; - case BUILT_IN_GOACC_KERNELS_INTERNAL: case BUILT_IN_GOACC_PARALLEL: { set_oacc_fn_attrib (child_fn, clauses, &args); -- 1.9.1